Skip to contentSkip to conversation

ASoC: pxa: pxa-ssp: small leak in probe()

PATCH Applied Dan Carpenter 2 participants 2 messages Jul 31, 2014

Subsystems (4)
Sound Kernel janitors ASoC PXA2xx/PXA3xx support
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ASoC: pxa: pxa-ssp: small leak in probe()

There is a small memory leak if probe() fails.

Fixes 2023c90c3a2c ('ASoC: pxa: pxa-ssp: add DT bindings')
Signed-off-by Dan Carpenter <[email protected]>
sound/soc/pxa/pxa-ssp.c +2 -1
index 199a8b3..0109f6c2 100644
@@ -723,7 +723,8 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)
 		ssp_handle = of_parse_phandle(dev->of_node, "port", 0);
 		if (!ssp_handle) {
 			dev_err(dev, "unable to get 'port' phandle\n");
-			return -ENODEV;
+			ret = -ENODEV;
+			goto err_priv;
 		}
 
 		priv->ssp = pxa_ssp_request_of(ssp_handle, "SoC audio");
maintainer Applied
#1 lore raw
Quoted 1 line · Dan Carpenter

There is a small memory leak if probe() fails.

Applied, thanks.