staging: lustre: bitwise vs logical typo

PATCH New Dan Carpenter 1 participant 1 message Jul 31, 2014

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2014-07-31 15:21 UTC #0 lore raw

PATCH 1/1 staging: lustre: bitwise vs logical typo

Bitwise AND was intended here obviously.

Signed-off-by Dan Carpenter <[email protected]>

---
Static analysis. I wasn't able to compile this.

Also lustre needs an entry in MAINTAINERS because otherwise get_maintainer.pl still sends everything to Peng Tao only.

drivers/staging/lustre/lustre/obdecho/echo.c +1 -1

index f3b7429..dae1599 100644
@@ -125,7 +125,7 @@ static int echo_create(const struct lu_env *env, struct obd_export *exp,
 		return -EINVAL;
 	}
 
-	if (!(oa->o_mode && S_IFMT)) {
+	if (!(oa->o_mode & S_IFMT)) {
 		CERROR("echo obd: no type!\n");
 		return -ENOENT;
 	}