Skip to contentSkip to conversation

ptpd2: fix static linking

PATCH New Gustavo Zacarias 2 participants 2 messages Jul 30, 2014 – Jul 31, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ptpd2: fix static linking

Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d to avoid missing libraries needed by libpcap. Fixes:
http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/

---
 package/ptpd2/ptpd2.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/ptpd2/ptpd2.mk +4 -0
index 3133726..6a6ae60 100644
@@ -13,6 +13,10 @@ PTPD2_AUTORECONF = YES
 PTPD2_LICENSE = BSD-2c
 PTPD2_LICENSE_FILES = COPYRIGHT
 
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+	PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
+endif
+
 ifeq ($(BR2_PACKAGE_NETSNMP),y)
 	PTPD2_CONF_ENV += ac_cv_path_PATH_NET_SNMP_CONFIG=$(STAGING_DIR)/usr/bin/net-snmp-config
 	PTPD2_DEPENDENCIES += netsnmp
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/1 ptpd2: fix static linking

Dear Gustavo Zacarias,

Quoted 14 lines · Gustavo Zacarias

Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d to avoid missing libraries needed by libpcap. Fixes:
http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/

---
 package/ptpd2/ptpd2.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/ptpd2/ptpd2.mk +0 -0
index 3133726..6a6ae60 100644

package/ptpd2/ptpd2.mk PTPD2_AUTORECONF = YES · line 19

Quoted 7 lines
package/ptpd2/ptpd2.mk +4 -0
@@ -13,6 +13,10 @@ PTPD2_AUTORECONF = YES
 PTPD2_LICENSE = BSD-2c
 PTPD2_LICENSE_FILES = COPYRIGHT
 
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+	PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
+endif
+

Applied, thanks. However, I continue to be worried about all those fixups we do all over the place for static linking, instead of fixing upstream properly. If upstream suddenly fixes static linking, we won't even notice.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com