Skip to contentSkip to conversation

package/dnsmasq: Fix link error with gettext

PATCH New Bernd Kuhls 2 participants 2 messages Jul 31, 2014

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/dnsmasq: Fix link error with gettext

-lintl needs to be added at the end of the link command, Makefile has variable LIBS for this purpose, so use it instead of LDFLAGS.

Fixes
http://autobuild.buildroot.net/results/276/276581f6dbbe330799c3a7eaa26b453e38a22907/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/dnsmasq/dnsmasq.mk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/dnsmasq/dnsmasq.mk +2 -2
index 71d2f30..6e97c68 100644
@@ -37,7 +37,7 @@ endif
 # NLS requires IDN so only enable it (i18n) when IDN is true
 ifeq ($(BR2_PACKAGE_DNSMASQ_IDN),y)
 	DNSMASQ_DEPENDENCIES += libidn $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext) host-gettext
-	DNSMASQ_MAKE_OPT += LDFLAGS+="-lidn $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)"
+	DNSMASQ_MAKE_OPT += LIBS+="$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)"
 	DNSMASQ_COPTS += -DHAVE_IDN
 	DNSMASQ_I18N = $(if $(BR2_ENABLE_LOCALE),-i18n)
 endif

@@ -58,7 +58,7 @@ ifeq ($(BR2_PACKAGE_DNSMASQ_LUA),y)
 
 # liblua uses dlopen when dynamically linked
 ifneq ($(BR2_PREFER_STATIC_LIB),y)
-	DNSMASQ_MAKE_OPT += LIBS="-ldl"
+	DNSMASQ_MAKE_OPT += LIBS+="-ldl"
 endif
 
 define DNSMASQ_ENABLE_LUA
Signature · 1 line
1.7.10.4
Applied
#1 lore raw

PATCH 1/1 package/dnsmasq: Fix link error with gettext

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

-lintl needs to be added at the end of the link command, Makefile has variable LIBS for this purpose, so use it instead of LDFLAGS.

Fixes
http://autobuild.buildroot.net/results/276/276581f6dbbe330799c3a7eaa26b453e38a22907/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/dnsmasq/dnsmasq.mk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks. I didn't know that doing

	make LIBS+=-lfoo LIBS+=-lbar

was actually working. But I tried, and it does.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com