Skip to contentSkip to conversation

dm9000: NULL dereferences on error in probe()

PATCH Applied Dan Carpenter 2 participants 2 messages Aug 1, 2014 – Aug 2, 2014

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 dm9000: NULL dereferences on error in probe()

The dm9000_release_board() function is called with NULL ->data_req and ->addr_req pointers if dm9000_probe() fails.

Signed-off-by Dan Carpenter <[email protected]>

---
Old bug, but not serious.

drivers/net/ethernet/davicom/dm9000.c +4 -2
index 13723c9..23084fb 100644
@@ -817,10 +817,12 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
 
 	/* release the resources */
 
-	release_resource(db->data_req);
+	if (db->data_req)
+		release_resource(db->data_req);
 	kfree(db->data_req);
 
-	release_resource(db->addr_req);
+	if (db->addr_req)
+		release_resource(db->addr_req);
 	kfree(db->addr_req);
 }