Skip to contentSkip to conversation

How to pass reboot arguments to secure firmware with PSCI spec

Query Jisheng Zhang 2 participants 4 messages Aug 1, 2014

lore
Share & tools
lore

Jisheng Zhang

author Reviewed-by Rob Herring Acked-by Catalin Marinas
#0 lore raw

Hi Catalin and Will,

I noticed that the following commit implement reboot via. PSCI SYSTEM_RESET function. So my question is how to handle the reboot arguments?

Quoted 3 lines

static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd)

{
      invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0);

How to pass cmd to secure firmware?

Quoted 1 line

}

Thanks in advance,
Jisheng

commit e71246a23acbc89e9cb4ebf1558d60e65733479f

Author: Ashwin Chaugule <[email protected]>
Date:   Thu Apr 17 14:38:41 2014 -0400

PSCI: Add initial support for PSCIv0.2 functions

The PSCIv0.2 spec defines standard values of function IDs and introduces a few new functions. Detect version of PSCI and appropriately select the right PSCI functions.

#1 lore raw
Quoted 5 lines · Jisheng Zhang

Hi Catalin and Will,

I noticed that the following commit implement reboot via. PSCI SYSTEM_RESET function. So my question is how to handle the reboot arguments?

What reboot arguments do you want to handle ?

Quoted 7 lines
Quoted 4 lines

static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd)

{
       invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0);

How to pass cmd to secure firmware?

What cmd do you want to pass ? The function id is already handled. What else do you want to pass ?

If you see PSCI v0.2 spec, the SYSTEM_RESET and SYSTEM_SHUTDOWN takes no parameters.

Regards,
Sudeep

#2 lore raw

Hi Sudeep,

Quoted 11 lines · On Fri, 1 Aug 2014 03:21:12 -0700 Sudeep Holla <[email protected]> wrote:
Quoted 6 lines · Jisheng Zhang

Hi Catalin and Will,

I noticed that the following commit implement reboot via. PSCI SYSTEM_RESET function. So my question is how to handle the reboot arguments?

What reboot arguments do you want to handle ?

man 2 reboot

...

int reboot(int magic, int magic2, int cmd, void *arg);

...

I want to pass "void *arg" to secure firmware.

Quoted 11 lines
Quoted 8 lines
Quoted 5 lines

static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd)

{
       invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0);

How to pass cmd to secure firmware?

What cmd do you want to pass ? The function id is already handled. What else do you want to pass ?

the "const char *cmd", usually this is the "abc" if user type "reboot abc" under shell.

For example, android usually type "reboot recovery", the "recovery" will be passed to next boot kernel boot args.

Quoted 3 lines

If you see PSCI v0.2 spec, the SYSTEM_RESET and SYSTEM_SHUTDOWN takes no parameters.

Yes. I know it. That's why I need your help/suggestions about how to handle the situation above.

Thanks for your input,
Jisheng

#3 lore raw
Quoted 19 lines · Jisheng Zhang

Hi Sudeep,

Quoted 11 lines · On Fri, 1 Aug 2014 03:21:12 -0700 Sudeep Holla <[email protected]> wrote:
Quoted 6 lines · Jisheng Zhang

Hi Catalin and Will,

I noticed that the following commit implement reboot via. PSCI SYSTEM_RESET function. So my question is how to handle the reboot arguments?

What reboot arguments do you want to handle ?

man 2 reboot

Quoted 9 lines

...

int reboot(int magic, int magic2, int cmd, void *arg);

...

I want to pass "void *arg" to secure firmware.

Why ? What will secure firmware do with that ? I can't think of any use of those arguments in the secure firmware esp. the example you have given below. Why should secure firmware know that you are booting in recovery mode.

And you can't do that with PSCI, the specification has no provisions and if do that it's violation.

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines

static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd)

{
        invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0);

How to pass cmd to secure firmware?

Quoted 9 lines
Quoted 2 lines

What cmd do you want to pass ? The function id is already handled. What else do you want to pass ?

the "const char *cmd", usually this is the "abc" if user type "reboot abc" under shell.

For example, android usually type "reboot recovery", the "recovery" will be passed to next boot kernel boot args.

How did you had manage to pass these information in absence of PSCI(i..e. other methods) ?

IIUC it's typically write to non-volatile memory indicating the reboot reason(at-least in Android devices) through some reboot notifiers.

You can still do that now even with PSCI right ?

Yes