Skip to contentSkip to conversation

clk: Add missing of_clk_set_defaults export

PATCH New Sylwester Nawrocki 3 participants 3 messages Aug 4, 2014 Common clk

lore
Share & tools
lore

Sylwester Nawrocki

author
#0 lore raw

PATCH 1/1 clk: Add missing of_clk_set_defaults export

The of_clk_set_defaults() function is used in subsystems which can be built as module. Add the missing symbol export entry so there is no build errors like:
"ERROR: "of_clk_set_defaults" [drivers/i2c/i2c-core.ko] undefined!".

Fixes commit: 86be408bfbd846fab3c4ac21d6f9298bd2e4b790 "clk: Support for clock parents and rates assigned from device tree"

Reported-by kbuild test robot <[email protected]>
Signed-off-by Sylwester Nawrocki <[email protected]>
---
 drivers/clk/clk-conf.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/clk-conf.c +1 -0
index 4e1bda7..aad4796 100644
@@ -141,3 +141,4 @@ int of_clk_set_defaults(struct device_node *node, bool clk_supplier)
 
 	return __set_clk_rates(node, clk_supplier);
 }
+EXPORT_SYMBOL_GPL(of_clk_set_defaults);

--
1.7.9.5

#1 lore raw

PATCH 1/1 clk: Add missing of_clk_set_defaults export

Quoted 10 lines · Sylwester Nawrocki

The of_clk_set_defaults() function is used in subsystems which can be built as module. Add the missing symbol export entry so there is no build errors like:
"ERROR: "of_clk_set_defaults" [drivers/i2c/i2c-core.ko] undefined!".

Fixes commit: 86be408bfbd846fab3c4ac21d6f9298bd2e4b790 "clk: Support for clock parents and rates assigned from device tree"

Reported-by kbuild test robot <[email protected]>
Signed-off-by Sylwester Nawrocki <[email protected]>
Acked-by Wolfram Sang <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140804/e2250867/attachment-0001.sig>

#2 lore raw

PATCH 1/1 clk: Add missing of_clk_set_defaults export

In reply to Sylwester Nawrocki

Quoting Sylwester Nawrocki (2014-08-04 03:48:58)

Quoted 10 lines

The of_clk_set_defaults() function is used in subsystems which can be built as module. Add the missing symbol export entry so there is no build errors like:
"ERROR: "of_clk_set_defaults" [drivers/i2c/i2c-core.ko] undefined!".

Fixes commit: 86be408bfbd846fab3c4ac21d6f9298bd2e4b790 "clk: Support for clock parents and rates assigned from device tree"

Reported-by kbuild test robot <[email protected]>
Signed-off-by Sylwester Nawrocki <[email protected]>

Thanks for the quick fixup. Applied for 3.17.

Regards,
Mike

Quoted 16 lines
---
 drivers/clk/clk-conf.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/clk-conf.c +1 -1
index 4e1bda7..aad4796 100644
@@ -141,3 +141,4 @@ int of_clk_set_defaults(struct device_node *node, bool clk_supplier)
 
        return __set_clk_rates(node, clk_supplier);
 }
+EXPORT_SYMBOL_GPL(of_clk_set_defaults);
--

1.7.9.5