Skip to contentSkip to conversation

Fixing checkpatch errors and warnings for PCI hotplug

PATCH In review Quentin Lambert 2 participants 2 messages Aug 4, 2014 – Sep 4, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Fixing checkpatch errors and warnings for PCI hotplug

Patch 1 and 2 fix checkpatch coding style warnings.

Patch 3 fixes chechpatch errors due to assignement in if conditions.

Quentin Lambert (3):
PCI hotplug: fix a missing space coding style issue PCI hotplug: fix a simple if coding style issue PCI hotplug: remove assignement from if conditions

 drivers/pci/hotplug/acpi_pcihp.c    |  3 ++-
 drivers/pci/hotplug/cpcihp_zt5550.c | 42 ++++++++++++++++++-------------------
 2 files changed, 23 insertions(+), 22 deletions(-)
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 10 lines · Quentin Lambert

Patch 1 and 2 fix checkpatch coding style warnings.

Patch 3 fixes chechpatch errors due to assignement in if conditions.

Quentin Lambert (3):
PCI hotplug: fix a missing space coding style issue PCI hotplug: fix a simple if coding style issue PCI hotplug: remove assignement from if conditions

I don't mind doing changes like these, but when we do, I want to do the whole drivers/pci directory at once to minimize the churn. I don't know how you did these, but it looks like there are more instances than are fixed by these patches, e.g.,

    drivers/pci/hotplug/cpcihp_generic.c:	if(!bridge) {
    drivers/pci/pci.c:      if ((i = pci_save_pcie_state(dev)) != 0)