glm: Added package
PATCH 1/1 glm: Added package
OpenGL Mathematics (GLM) is a header only C++ mathematics library for graphics software based on the OpenGL Shading Language (GLSL) specification.
--- package/Config.in | 1 + package/glm/Config.in | 7 +++++++ package/glm/glm.mk | 13 +++++++++++++ 3 files changed, 21 insertions(+) create mode 100644 package/glm/Config.in create mode 100644 package/glm/glm.mk
package/Config.in +1 -0
@@ -828,6 +828,7 @@ menu "Other" source "package/fftw/Config.in" source "package/flann/Config.in" source "package/glibmm/Config.in" + source "package/glm/Config.in" source "package/gmp/Config.in" source "package/gsl/Config.in" source "package/gtest/Config.in"
package/glm/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_GLM + bool "glm" + depends on BR2_INSTALL_LIBSTDCPP + help + OpenGL Mathematics (GLM) + + http://glm.g-truc.net
package/glm/glm.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# glm +# +############################################################# +GLM_VERSION = 0.9.5.4 +GLM_SITE = git://github.com/g-truc/glm.git +GLM_LICENSE = MIT +GLM_LICENSE_FILES = copying.txt +GLM_INSTALL_STAGING = YES +GLM_INSTALL_TARGET = NO + +$(eval $(cmake-package))
Signature · 1 line
2.0.1
PATCH 1/1 glm: Added package
Hi Paul,
Quoted 46 lines · Paul Cercueil
OpenGL Mathematics (GLM) is a header only C++ mathematics library for graphics software based on the OpenGL Shading Language (GLSL) specification.
Signed-off-by Paul Cercueil <[email protected]>--- package/Config.in | 1 + package/glm/Config.in | 7 +++++++ package/glm/glm.mk | 13 +++++++++++++ 3 files changed, 21 insertions(+) create mode 100644 package/glm/Config.in create mode 100644 package/glm/glm.mkpackage/Config.in +1
-0@@ -828,6 +828,7 @@ menu "Other" source "package/fftw/Config.in" source "package/flann/Config.in" source "package/glibmm/Config.in" + source "package/glm/Config.in" source "package/gmp/Config.in" source "package/gsl/Config.in" source "package/gtest/Config.in"package/glm/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_GLM + bool "glm" + depends on BR2_INSTALL_LIBSTDCPP + help + OpenGL Mathematics (GLM) + + http://glm.g-truc.netpackage/glm/glm.mk new file +0
-0
package/glm/glm.mk line 7
Quoted 7 lines
package/glm/glm.mk new file +7
-0@@ -0,0 +1,13 @@ +############################################################# +# +# glm +# +############################################################# +GLM_VERSION = 0.9.5.4 +GLM_SITE = git://github.com/g-truc/glm.git
Have you tried using the github helper? If it doesn't work for you please add a comment explaining why.
baruch
Quoted 6 lines
package/glm/glm.mk new file +6
-0+GLM_LICENSE = MIT +GLM_LICENSE_FILES = copying.txt +GLM_INSTALL_STAGING = YES +GLM_INSTALL_TARGET = NO + +$(eval $(cmake-package))
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/1 glm: Added package
In reply to Paul CercueilDear Paul Cercueil,
package/glm/Config.in line 7
Quoted 13 lines · Paul Cercueil
package/glm/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_GLM + bool "glm" + depends on BR2_INSTALL_LIBSTDCPP + help + OpenGL Mathematics (GLM) + + http://glm.g-truc.net
This lacks a comment explaining that this package depends on C++ when C++ is not available (see the Buildroot manual and many other packages in Buildroot).
package/glm/glm.mk line 5
Quoted 11 lines
package/glm/glm.mk new file +5
-0@@ -0,0 +1,13 @@ +############################################################# +# +# glm +# +#############################################################
Header length is not correct (80 # signs are needed), and there should be an empty line between the header and the first variable definition.
package/glm/glm.mk line 7
Quoted 2 lines
package/glm/glm.mk new file +2
-0+GLM_VERSION = 0.9.5.4 +GLM_SITE = git://github.com/g-truc/glm.git
github helper, as pointed by Baruch.
package/glm/glm.mk line 11
Quoted 4 lines
package/glm/glm.mk new file +4
-0+GLM_LICENSE = MIT +GLM_LICENSE_FILES = copying.txt +GLM_INSTALL_STAGING = YES +GLM_INSTALL_TARGET = NO
Could you add a small comment above those two lines to explain why no target installation is needed?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 glm: Added package
Hi Thomas, Baruch,
Thank you for your comments. I will send a new version of this patch shortly.
Paul
Le 06/08/2014 22:12, Thomas Petazzoni a ?crit :
Quoted 54 lines
Dear Paul Cercueil,
package/glm/Config.in line 7
Quoted 13 lines · Paul Cercueil
package/glm/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_GLM + bool "glm" + depends on BR2_INSTALL_LIBSTDCPP + help + OpenGL Mathematics (GLM) + + http://glm.g-truc.netThis lacks a comment explaining that this package depends on C++ when C++ is not available (see the Buildroot manual and many other packages in Buildroot).
package/glm/glm.mk line 5
Quoted 11 lines
package/glm/glm.mk new file +5
-0@@ -0,0 +1,13 @@ +############################################################# +# +# glm +# +#############################################################Header length is not correct (80 # signs are needed), and there should be an empty line between the header and the first variable definition.
package/glm/glm.mk line 7
Quoted 2 lines
package/glm/glm.mk new file +2
-0+GLM_VERSION = 0.9.5.4 +GLM_SITE = git://github.com/g-truc/glm.gitgithub helper, as pointed by Baruch.
package/glm/glm.mk line 11
Quoted 4 lines
package/glm/glm.mk new file +4
-0+GLM_LICENSE = MIT +GLM_LICENSE_FILES = copying.txt +GLM_INSTALL_STAGING = YES +GLM_INSTALL_TARGET = NOCould you add a small comment above those two lines to explain why no target installation is needed?
Thanks!
Thomas