ARM: imx6: add pci config space as platform resource
Subsystems (4)
PATCH v2 1/1 ARM: imx6: add pci config space as platform resource
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" error exposed by new versions of the designware pcie driver.
---
v2: also fix documentation example
--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3 -1
@@ -17,7 +17,9 @@ Example: pcie at 0x01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; - reg = <0x01ffc000 0x4000>; + reg = <0x01ffc000 0x04000>, + <0x01f00000 0x80000>; + reg-names = "dbi", "config"; #address-cells = <3>; #size-cells = <2>; device_type = "pci";
arch/arm/boot/dts/imx6qdl.dtsi +3 -1
@@ -133,7 +133,9 @@ pcie: pcie at 0x01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; - reg = <0x01ffc000 0x4000>; /* DBI */ + reg = <0x01ffc000 0x04000>, + <0x01f00000 0x80000>; + reg-names = "dbi", "config"; #address-cells = <3>; #size-cells = <2>; device_type = "pci";
Signature · 1 line
2.0.1
Fabio Estevam
reviewerPATCH v2 1/1 ARM: imx6: add pci config space as platform resource
Quoted 16 lines · Lucas Stach
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" error exposed by new versions of the designware pcie driver.
Signed-off-by Lucas Stach <[email protected]>---
v2: also fix documentation example--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +0
-0
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt Example: · line 22
Quoted 7 lines
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3
-1@@ -17,7 +17,9 @@ Example: pcie at 0x01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; - reg = <0x01ffc000 0x4000>; + reg = <0x01ffc000 0x04000>, + <0x01f00000 0x80000>; + reg-names = "dbi", "config";
It would be nice to update the 'reg' description and add the 'reg-names' entry in the 'Required properties' section.
Currently we have the following description:
"reg: base addresse (---> typo here) and length of the pcie controller" ,which does not match the provided example after your patch.
PATCH v2 1/1 ARM: imx6: add pci config space as platform resource
Am Donnerstag, den 07.08.2014, 15:12 -0300 schrieb Fabio Estevam:
Quoted 28 lines · Lucas Stach
Quoted 16 lines
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" error exposed by new versions of the designware pcie driver.
Signed-off-by Lucas Stach <[email protected]>---
v2: also fix documentation example--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +0
-0Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt Example: · line 22
Quoted 7 lines
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3
-1@@ -17,7 +17,9 @@ Example: pcie at 0x01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; - reg = <0x01ffc000 0x4000>; + reg = <0x01ffc000 0x04000>, + <0x01f00000 0x80000>; + reg-names = "dbi", "config";It would be nice to update the 'reg' description and add the 'reg-names' entry in the 'Required properties' section.
Quoted 6 lines
Currently we have the following description:
"reg: base addresse (---> typo here) and length of the pcie controller" ,which does not match the provided example after your patch.
I'm a bit on the fence here. Yes, it's a bit inconsistent with the example, but it's actually the same approach chosen for other properties like clocks. Base properties are inherited from designware-pcie.txt and only additional things are documented in fsl,imx6q-pcie.txt.
I'm leaning toward not breaking the existing practice.
Regards,
Lucas
Signature · 2 lines
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: imx6: add pci config space as platform resource
Quoted 35 lines · Lucas Stach
Am Donnerstag, den 07.08.2014, 15:12 -0300 schrieb Fabio Estevam:
Quoted 28 lines · Lucas Stach
Quoted 16 lines
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" error exposed by new versions of the designware pcie driver.
Signed-off-by Lucas Stach <[email protected]>---
v2: also fix documentation example--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +0
-0Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt Example: · line 22
Quoted 7 lines
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3
-1@@ -17,7 +17,9 @@ Example: pcie at 0x01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; - reg = <0x01ffc000 0x4000>; + reg = <0x01ffc000 0x04000>, + <0x01f00000 0x80000>; + reg-names = "dbi", "config";It would be nice to update the 'reg' description and add the 'reg-names' entry in the 'Required properties' section.
Quoted 6 lines
Currently we have the following description:
"reg: base addresse (---> typo here) and length of the pcie controller" ,which does not match the provided example after your patch.
Quoted 6 lines
I'm a bit on the fence here. Yes, it's a bit inconsistent with the example, but it's actually the same approach chosen for other properties like clocks. Base properties are inherited from designware-pcie.txt and only additional things are documented in fsl,imx6q-pcie.txt.
I'm leaning toward not breaking the existing practice.
+1
Will apply it as a fix once v3.17-rc1 is out. Remind me if I forget.
Shawn
Shawn Guo
AppliedPATCH v2 1/1 ARM: imx6: add pci config space as platform resource
In reply to Lucas StachQuoted 4 lines · Lucas Stach
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" error exposed by new versions of the designware pcie driver.
Signed-off-by Lucas Stach <[email protected]>
Applied, thanks.