lcd: cleanup unused functions

PATCH New Hannes Petermaier 2 participants 2 messages Mar 7, 2014 – Aug 11, 2014

Share & tools

Hannes Petermaier

author

2014-03-07 17:45 UTC #0 lore raw

PATCH 1/1 lcd: cleanup unused functions

This patch removes following two functions:
- lcd_getbgcolor(...)
not used somewhere outside lcd.c, internally we use now the global variable lcd_color_bg (was return value of function before)
- lcd_getfgcolor(...)
not used in any place of u-boot

Signed-off-by Hannes Petermaier <[email protected]>

---
 common/lcd.c  |   17 +----------------
 include/lcd.h |    2 --
 2 files changed, 1 insertion(+), 18 deletions(-)

common/lcd.c +1 ~~-16~~

index aa81522..3f73541 100644
@@ -110,7 +110,6 @@ static int lcd_init(void *lcdbase);
 
 static void *lcd_logo(void);
 
-static int lcd_getbgcolor(void);
 static void lcd_setfgcolor(int color);
 static void lcd_setbgcolor(int color);

@@ -454,7 +453,7 @@ void lcd_clear(void)
 #else
 	/* set framebuffer to background color */
 	memset((char *)lcd_base,
-		COLOR_MASK(lcd_getbgcolor()),
+		COLOR_MASK(lcd_color_bg),
 		lcd_line_length * panel_info.vl_row);
 #endif
 	/* Paint the logo and retrieve LCD base address */

@@ -563,20 +562,6 @@ static void lcd_setbgcolor(int color)
 	lcd_color_bg = color;
 }
 
-/*----------------------------------------------------------------------*/
-
-int lcd_getfgcolor(void)
-{
-	return lcd_color_fg;
-}
-
-/*----------------------------------------------------------------------*/
-
-static int lcd_getbgcolor(void)
-{
-	return lcd_color_bg;
-}
-
 /************************************************************************/
 /* ** Chipset depending Bitmap / Logo stuff...                          */
 /************************************************************************/

include/lcd.h +0 -2

index d06d6f1..d1cb6b1 100644
@@ -26,8 +26,6 @@ void lcd_enable(void);
 void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue);
 void lcd_initcolregs(void);
 
-int lcd_getfgcolor(void);
-
 /* gunzip_bmp used if CONFIG_VIDEO_BMP_GZIP */
 struct bmp_image *gunzip_bmp(unsigned long addr, unsigned long *lenp,
 			     void **alloc_addr);

Signature · 1 line

1.7.10.4

Anatolij Gustschin

2014-08-11 14:18 UTC #1 lore raw

PATCH 1/1 lcd: cleanup unused functions

Quoted 7 lines · On Fri, 7 Mar 2014 18:45:20 +0100 Hannes Petermaier <[email protected]> wrote:

This patch removes following two functions:
- lcd_getbgcolor(...)
not used somewhere outside lcd.c, internally we use now the global variable lcd_color_bg (was return value of function before)
- lcd_getfgcolor(...)
not used in any place of u-boot

Quoted 5 lines

Signed-off-by Hannes Petermaier <[email protected]>
---
 common/lcd.c  |   17 +----------------
 include/lcd.h |    2 --
 2 files changed, 1 insertion(+), 18 deletions(-)

applied to u-boot-video/master. Thanks!

Anatolij