Skip to contentSkip to conversation

staging: Check against NULL in fw_download_code

PATCH Jerry Snitselaar 1 participant 1 message Aug 11, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 25 lines · Nicholas Krause

I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
This entry states that we are not checking the skb allocated in fw_download_code and after checking I fixed it to check for the NULL value before using the allocate skb.

---
 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2 -0
index 1a95d1f..817e50e 100644
@@ -61,6 +61,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 		}
 
 		skb  = dev_alloc_skb(frag_length + 4);
+		if (skb == NULL)
+			return !rt_status;
 		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
 		tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc->queue_index = TXCMD_QUEUE;
Signature · 1 line
1.9.1

Look at fw_download_code() in drivers/staging/rtl8192u/r819xU_firmware.c