sunvnet: Do not ask for an ACK for every dring transmit

PATCH In review Sowmini Varadhan 1 participant 1 message Aug 12, 2014

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Sowmini Varadhan

author

2014-08-12 14:27 UTC #0 lore raw

PATCH 1/3 sunvnet: Do not ask for an ACK for every dring transmit

No need to ask for an ack with every vnet_start_xmit()- the single ACK with DRING_STOPPED is sufficient for the protocol, and we free the sk_buff in vnet_start_xmit itself, so we dont need an ACK back.

Signed-off-by Sowmini Varadhan <[email protected]>

Acked-by Raghuram Kothakota <[email protected]>

---
 drivers/net/ethernet/sun/sunvnet.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

drivers/net/ethernet/sun/sunvnet.c +9 -1

index d813bfb..b489dd0 100644
@@ -691,7 +691,15 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		memset(tx_buf+VNET_PACKET_SKIP+skb->len, 0, len - skb->len);
 	}
 
-	d->hdr.ack = VIO_ACK_ENABLE;
+	/* We don't rely on the ACKs to free the skb in vnet_start_xmit(),
+	 * thus it is safe to not set VIO_ACK_ENABLE for each transmission:
+	 * the protocol itself does not require it as long as the peer
+	 * sends a VIO_SUBTYPE_ACK for VIO_DRING_STOPPED.
+	 *
+	 * An ACK for every packet in the ring is expensive as the
+	 * sending of LDC messages is slow and affects performance.
+	 */
+	d->hdr.ack = VIO_ACK_DISABLE;
 	d->size = len;
 	d->ncookies = port->tx_bufs[dr->prod].ncookies;
 	for (i = 0; i < d->ncookies; i++)

Signature · 1 line

1.8.4.2