Skip to contentSkip to conversation

Add VIN and ADV7180 device tree support for R8A7790/Lager board

PATCH New sergei.shtylyov at cogentembedded.com 2 participants 4 messages Aug 12, 2014 – Aug 14, 2014

Subsystems (2)
Device tree bindings SuperH
lore
Share & tools
lore

sergei.shtylyov at cogentembedded.com

author
#0 lore raw

v5 cover Add VIN and ADV7180 device tree support for R8A7790/Lager board

Hello.

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.16-20140811' tag. Here Ben Dooks adds the VIN and ADV7180 video decoder device tree support on the R8A7790/Lager board. The patchset requires Ben Dooks' 'rcar_vin' and 'soc_camera' DT support patches (already merged to the 'media_tree.git' repo) in order to work.

[1/2] ARM: shmobile: r8a7790: add VIN device nodes [2/2] ARM: shmobile: lager: add VIN1/ADV7180 device nodes

WBR, Sergei

author
#1 lore raw

PATCH v5 1/2 ARM: shmobile: r8a7790: add VIN device nodes

From: Ben Dooks <[email protected]>

Add device nodes for the four video input controllers on the R8A7790.

Signed-off-by Ben Dooks <[email protected]>
[Sergei: renamed VIN device nodes, edited changelog]
Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 5:
- renamed VIN device nodes;
- edited changelog and summary;
- refreshed patch.

 arch/arm/boot/dts/r8a7790.dtsi |   36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
arch/arm/boot/dts/r8a7790.dtsi +36 -0
Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
===================================================================
@@ -33,6 +33,10 @@
 		spi2 = &msiof1;
 		spi3 = &msiof2;
 		spi4 = &msiof3;
+		vin0 = &vin0;
+		vin1 = &vin1;
+		vin2 = &vin2;
+		vin3 = &vin3;
 	};
 
 	cpus {

@@ -564,6 +568,38 @@
 		status = "disabled";
 	};
 
+	vin0: video at e6ef0000 {
+		compatible = "renesas,vin-r8a7790";
+		clocks = <&mstp8_clks R8A7790_CLK_VIN0>;
+		reg = <0 0xe6ef0000 0 0x1000>;
+		interrupts = <0 188 IRQ_TYPE_LEVEL_HIGH>;
+		status = "disabled";
+	};
+
+	vin1: video at e6ef1000 {
+		compatible = "renesas,vin-r8a7790";
+		clocks = <&mstp8_clks R8A7790_CLK_VIN1>;
+		reg = <0 0xe6ef1000 0 0x1000>;
+		interrupts = <0 189 IRQ_TYPE_LEVEL_HIGH>;
+		status = "disabled";
+	};
+
+	vin2: video at e6ef2000 {
+		compatible = "renesas,vin-r8a7790";
+		clocks = <&mstp8_clks R8A7790_CLK_VIN2>;
+		reg = <0 0xe6ef2000 0 0x1000>;
+		interrupts = <0 190 IRQ_TYPE_LEVEL_HIGH>;
+		status = "disabled";
+	};
+
+	vin3: video at e6ef3000 {
+		compatible = "renesas,vin-r8a7790";
+		clocks = <&mstp8_clks R8A7790_CLK_VIN3>;
+		reg = <0 0xe6ef3000 0 0x1000>;
+		interrupts = <0 191 IRQ_TYPE_LEVEL_HIGH>;
+		status = "disabled";
+	};
+
 	clocks {
 		#address-cells = <2>;
 		#size-cells = <2>;
author
#2 lore raw

PATCH v5 2/2 ARM: shmobile: lager: add VIN1/ADV7180 device nodes

In reply to sergei.shtylyov at cogentembedded.com

From: Ben Dooks <[email protected]>

Add the Lager board specific device node part for VIN1 (composite video in); add the device node for Analog Devices ADV7180 video decoder to IIC2 bus. Add the necessary subnodes to interconnect VIN1 and ADV7180 devices.

Signed-off-by Ben Dooks <[email protected]>
[Sergei: rebased, edited changelog and summary]
Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 5:
- edited changelog and summary;
- resolved reject, refreshed patch.

 arch/arm/boot/dts/r8a7790-lager.dts |   36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
arch/arm/boot/dts/r8a7790-lager.dts +36 -0
Index: renesas/arch/arm/boot/dts/r8a7790-lager.dts
===================================================================
@@ -234,6 +234,11 @@
 		renesas,groups = "usb2";
 		renesas,function = "usb2";
 	};
+
+	vin1_pins: vin {
+		renesas,groups = "vin1_data8", "vin1_clk";
+		renesas,function = "vin1";
+	};
 };
 
 &ether {

@@ -370,6 +375,19 @@
 	status = "ok";
 	pinctrl-0 = <&iic2_pins>;
 	pinctrl-names = "default";
+
+	composite-in at 20 {
+		compatible = "adi,adv7180";
+		reg = <0x20>;
+		remote = <&vin1>;
+
+		port {
+			adv7180: endpoint {
+				bus-width = <8>;
+				remote-endpoint = <&vin1ep0>;
+			};
+		};
+	};
 };
 
 &iic3 {

@@ -405,3 +423,21 @@
 	pinctrl-0 = <&usb2_pins>;
 	pinctrl-names = "default";
 };
+
+/* composite video input */
+&vin1 {
+	pinctrl-0 = <&vin1_pins>;
+	pinctrl-names = "default";
+
+	status = "ok";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		vin1ep0: endpoint {
+			remote-endpoint = <&adv7180>;
+			bus-width = <8>;
+		};
+	};
+};
#3 lore raw

v5 cover Add VIN and ADV7180 device tree support for R8A7790/Lager board

In reply to sergei.shtylyov at cogentembedded.com
Quoted 10 lines · sergei.shtylyov at cogentembedded.com

Hello.

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.16-20140811' tag. Here Ben Dooks adds the VIN and ADV7180 video decoder device tree support on the R8A7790/Lager board. The patchset requires Ben Dooks' 'rcar_vin' and 'soc_camera' DT support patches (already merged to the 'media_tree.git' repo) in order to work.

[1/2] ARM: shmobile: r8a7790: add VIN device nodes [2/2] ARM: shmobile: lager: add VIN1/ADV7180 device nodes

Thanks, I have queued these up for v3.18.