package/erlang: build host erlang with ssl support to match target
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
If the target erlang has SSL support, so shoud the host-erlang.
---
Note: I am not sure whether this is the correct solution, to match the host SSL support to the target SSL support. I'll let the erlang experts enhance that patch if need be. ;-)
--- package/erlang/erlang.mk | 3 +++ 1 file changed, 3 insertions(+)
package/erlang/erlang.mk +3 -0
@@ -34,8 +34,11 @@ endif ifeq ($(BR2_PACKAGE_OPENSSL),y) ERLANG_CONF_OPT += --with-ssl ERLANG_DEPENDENCIES += openssl +HOST_ERLANG_DEPENDENCIES += host-openssl +HOST_ERLANG_CONF_OPT += --with-ssl=$(HOST_DIR)/usr else ERLANG_CONF_OPT += --without-ssl +HOST_ERLANG_CONF_OPT += --without-ssl endif ifeq ($(BR2_PACKAGE_ZLIB),y)
Signature · 1 line
1.9.1
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
Yann,
Quoted 1 line · Yann E. MORIN
If the target erlang has SSL support, so shoud the host-erlang.
This patch makes sense to me. I tried it in my setup to make sure that everything still works fine and that host-erlang is really using host-openssl. It looks good, so.
Thanks,
Frank
Quoted 33 lines
Suggested-by Frank Hunleth <[email protected]>Signed-off-by "Yann E. MORIN" <[email protected]>Cc Frank Hunleth <[email protected]>Cc Johan Oudinet <[email protected]>---
Note: I am not sure whether this is the correct solution, to match the host SSL support to the target SSL support. I'll let the erlang experts enhance that patch if need be. ;-)--- package/erlang/erlang.mk | 3 +++ 1 file changed, 3 insertions(+)package/erlang/erlang.mk +3
-1@@ -34,8 +34,11 @@ endif ifeq ($(BR2_PACKAGE_OPENSSL),y) ERLANG_CONF_OPT += --with-ssl ERLANG_DEPENDENCIES += openssl +HOST_ERLANG_DEPENDENCIES += host-openssl +HOST_ERLANG_CONF_OPT += --with-ssl=$(HOST_DIR)/usr else ERLANG_CONF_OPT += --without-ssl +HOST_ERLANG_CONF_OPT += --without-ssl endif ifeq ($(BR2_PACKAGE_ZLIB),y) --1.9.1
Signature · 4 lines
Frank Hunleth Troodon Software LLC Embedded Software Development http://troodon-software.com/
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
In reply to Yann E. MORINDear Yann E. MORIN,
Quoted 1 line · Yann E. MORIN
If the target erlang has SSL support, so shoud the host-erlang.
Why?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
Hi Thomas,
Quoted 7 lines · Thomas Petazzoni
Dear Yann E. MORIN,
Quoted 1 line · Yann E. MORIN
If the target erlang has SSL support, so shoud the host-erlang.
Why?
After more thought, I think that the reasoning should be that the common Erlang build tools reference openssl. (openssl is used for Erlang's crypto support, so the moment you run code that computes a SHA1, you need it.) I'd be fine with host-erlang always having ssl enabled since the error message you get when you don't have it enabled is not obvious to anyone who doesn't use Erlang.
Frank
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
Frank, All,
On 2014-08-15 08:33 -0400, Frank Hunleth spake thusly:
Quoted 8 lines
Quoted 6 lines · Thomas Petazzoni
Dear Yann E. MORIN,
Quoted 1 line · Yann E. MORIN
If the target erlang has SSL support, so shoud the host-erlang.
Quoted 8 lines
Quoted 1 line
Why?
After more thought, I think that the reasoning should be that the common Erlang build tools reference openssl. (openssl is used for Erlang's crypto support, so the moment you run code that computes a SHA1, you need it.) I'd be fine with host-erlang always having ssl enabled since the error message you get when you don't have it enabled is not obvious to anyone who doesn't use Erlang.
Yes, after giving it more thought, and your input above, I believe we should always build host-erlang with SSL support.
I'll update my patch accordingly.
Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
Dear Yann E. MORIN,
Quoted 11 lines · Yann E. MORIN
Quoted 6 lines
After more thought, I think that the reasoning should be that the common Erlang build tools reference openssl. (openssl is used for Erlang's crypto support, so the moment you run code that computes a SHA1, you need it.) I'd be fine with host-erlang always having ssl enabled since the error message you get when you don't have it enabled is not obvious to anyone who doesn't use Erlang.
Yes, after giving it more thought, and your input above, I believe we should always build host-erlang with SSL support.
I'll update my patch accordingly.
Can you include in the commit log the rationale for this change?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package/erlang: build host erlang with ssl support to match target
Thomas, All,
On 2014-08-15 18:29 +0200, Thomas Petazzoni spake thusly:
Quoted 9 lines · Yann E. MORIN
Quoted 8 lines
Quoted 7 lines
After more thought, I think that the reasoning should be that the common Erlang build tools reference openssl. (openssl is used for Erlang's crypto support, so the moment you run code that computes a SHA1, you need it.) I'd be fine with host-erlang always having ssl enabled since the error message you get when you don't have it enabled is not obvious to anyone who doesn't use Erlang.
Quoted 6 lines
Quoted 4 lines
Yes, after giving it more thought, and your input above, I believe we should always build host-erlang with SSL support.
I'll update my patch accordingly.
Can you include in the commit log the rationale for this change?
Err.. I think I did, didn't I?
http://patchwork.ozlabs.org/patch/380305/
;-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'