Skip to contentSkip to conversation

package/erlang: build host-erlang with support for openssl

PATCH New Yann E. MORIN 4 participants 5 messages Aug 15, 2014 – Oct 6, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/erlang: build host-erlang with support for openssl

Erlang uses openssl for all things crypto.

Since there are host Erlang tools that use crypto (such as rebar), we need to build host-erlang with support for crypto, and thus it shall depends on openssl.

---
Note: I am not sure whether this is the correct solution, to match the host SSL support to the target SSL support. I'll let the erlang experts enhance that patch if need be. ;-)

---
 package/erlang/erlang.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/erlang/erlang.mk +5 -2
index 1278682..b616e99 100644
@@ -8,7 +8,6 @@ ERLANG_VERSION = 17.0
 ERLANG_SITE = http://www.erlang.org/download
 ERLANG_SOURCE = otp_src_$(ERLANG_VERSION).tar.gz
 ERLANG_DEPENDENCIES = host-erlang
-HOST_ERLANG_DEPENDENCIES =
 
 ERLANG_LICENSE = EPL
 ERLANG_LICENSE_FILES = EPLICENCE
@@ -22,7 +21,11 @@ ERLANG_CONF_ENV = ac_cv_func_isnan=yes ac_cv_func_isinf=yes
 ERLANG_CONF_ENV += erl_xcomp_sysroot=$(STAGING_DIR)
 
 ERLANG_CONF_OPT = --without-javac
-HOST_ERLANG_CONF_OPT = --without-javac
+
+# erlang uses openssl for all things crypto. Since the host tools (such as
+# rebar) uses crypto, we need to build host-erlang with support for openssl.
+HOST_ERLANG_DEPENDENCIES = host-openssl
+HOST_ERLANG_CONF_OPT = --without-javac --with-ssl=$(HOST_DIR)/usr
 
 ifeq ($(BR2_PACKAGE_NCURSES),y)
 ERLANG_CONF_OPT += --with-termcap
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/erlang: build host-erlang with support for openssl

Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Erlang uses openssl for all things crypto.
Since there are host Erlang tools that use crypto (such as rebar), we need to build host-erlang with support for crypto, and thus it shall depends on openssl.

Quoted 4 lines

---
Note: I am not sure whether this is the correct solution, to match the host SSL support to the target SSL support. I'll let the erlang experts enhance that patch if need be. ;-)

Sorry, I must have missed the discussion about this. What exactly does it fix? Do we need it for 2014.08?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/erlang: build host-erlang with support for openssl

Peter, All,

On 2014-08-17 09:09 +0200, Peter Korsgaard spake thusly:

Quoted 12 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Erlang uses openssl for all things crypto.
Since there are host Erlang tools that use crypto (such as rebar), we need to build host-erlang with support for crypto, and thus it shall depends on openssl.

Quoted 4 lines
Quoted 4 lines

---
Note: I am not sure whether this is the correct solution, to match the host SSL support to the target SSL support. I'll let the erlang experts enhance that patch if need be. ;-)

(Sorry, I should have removed this post-comit note in this v2)

Quoted 2 lines

Sorry, I must have missed the discussion about this. What exactly does it fix?

Some Erlang packages (like ejabberd) use an Erlang script to do part of the configure and build steps, thus we need a host Erlang.

This script may need to do some crypto stuff (e.g. to compute hashes, or do https). In the Erlang world, all crypto stuff is implemented by using oppenssl as the crypto backend.

So, we need a host Erlang with crypto support, and thus linked with openssl.

Quoted 1 line

Do we need it for 2014.08?

Well, it can well wait for after the release, if you're not at ease with it. Currently, we have no package that require Erlang, not even the host Erlang.

However, since our host-erlang not being ssl-aware, it means no one is really using it, and thus bumping should not cause a regressiopn for anyone.

No one, but me, has complained so far. ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/erlang: build host-erlang with support for openssl

Yann, Peter, All,

Quoted 37 lines · Yann E. MORIN

Peter, All,

On 2014-08-17 09:09 +0200, Peter Korsgaard spake thusly:

Quoted 12 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Erlang uses openssl for all things crypto.
Since there are host Erlang tools that use crypto (such as rebar), we need to build host-erlang with support for crypto, and thus it shall depends on openssl.

Quoted 4 lines
Quoted 4 lines

---
Note: I am not sure whether this is the correct solution, to match the host SSL support to the target SSL support. I'll let the erlang experts enhance that patch if need be. ;-)

(Sorry, I should have removed this post-comit note in this v2)

Quoted 2 lines

Sorry, I must have missed the discussion about this. What exactly does it fix?

Some Erlang packages (like ejabberd) use an Erlang script to do part of the configure and build steps, thus we need a host Erlang.

This script may need to do some crypto stuff (e.g. to compute hashes, or do https). In the Erlang world, all crypto stuff is implemented by using oppenssl as the crypto backend.

So, we need a host Erlang with crypto support, and thus linked with openssl.

Quoted 1 line

Do we need it for 2014.08?

Quoted 7 lines

Well, it can well wait for after the release, if you're not at ease with it. Currently, we have no package that require Erlang, not even the host Erlang.

However, since our host-erlang not being ssl-aware, it means no one is really using it, and thus bumping should not cause a regressiopn for anyone.

FWIW, I use it and a few other people I know use host-erlang.

Quoted 1 line

No one, but me, has complained so far. ;-)

I find it amazing too that I haven't run into the issue or heard from anyone else. I have a couple build environments that I thought were minimal, but they clearly must have had the openssl dev packages installed or I would have seen it.

Anyway, I agree with Yann, that there's no rush on getting the fix in for this release. Now that we know how the issue manifests itself, it's pretty easy to identify.

Thanks,
Frank

#4 lore raw

PATCH 1/1 package/erlang: build host-erlang with support for openssl

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 10 lines · Yann E. MORIN

Erlang uses openssl for all things crypto.

Since there are host Erlang tools that use crypto (such as rebar), we need to build host-erlang with support for crypto, and thus it shall depends on openssl.

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com