iommu: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
PATCH 1/1 iommu: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
--- drivers/iommu/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/dmar.c +1 -1
@@ -246,7 +246,7 @@ int dmar_remove_dev_scope(struct dmar_pci_notify_info *info, u16 segment,for_each_active_dev_scope (devices, count, index, tmp)if (tmp == &info->dev->dev) { -rcu_assign_pointer (devices[index].dev,NULL ); +RCU_INIT_POINTER (devices[index].dev,NULL );synchronize_rcu ();put_device (tmp);return 1 ;
Signature · 1 line
1.9.1
Quoted 10 lines · Andreea-Cristina Bernat
The use of "
rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use ofRCU_INIT_POINTER()is NULLing out the pointer"
it is better to use it instead ofrcu_assign_pointer()because it has a smaller overhead.The following Coccinelle semantic patch was used:
@@
@@
Quoted 5 lines
-
rcu_assign_pointer
+RCU_INIT_POINTER
(..., NULL)Signed-off-by Andreea-Cristina Bernat <[email protected]>
Applied, thanks.