DRA7xx: Add DWC3 USB driver and enable DFU

In order to support multiple USB device controllers in uboot, udc-core is needed. udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/Makefile   |   1 +
 drivers/usb/gadget/udc-core.c | 229 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 230 insertions(+)
 create mode 100644 drivers/usb/gadget/udc-core.c

drivers/usb/gadget/Makefile +1 -0

index 66becdc..74875a2 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_USBDOWNLOAD_GADGET) += g_dnl.o
 obj-$(CONFIG_DFU_FUNCTION) += f_dfu.o
 obj-$(CONFIG_USB_GADGET_MASS_STORAGE) += f_mass_storage.o
 obj-$(CONFIG_CMD_FASTBOOT) += f_fastboot.o
+obj-y += udc-core.o
 endif
 ifdef CONFIG_USB_ETHER
 obj-y += ether.o

drivers/usb/gadget/udc-core.c new file +1 -0

new file mode 100644
index 0000000..bbe919c
@@ -0,0 +1,229 @@
+/**

Quoted 35 lines · Kishon Vijay Abraham I

In order to support multiple USB device controllers in uboot, udc-core is needed. udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/Makefile   |   1 +
 drivers/usb/gadget/udc-core.c | 229 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 230 insertions(+)
 create mode 100644 drivers/usb/gadget/udc-core.c

drivers/usb/gadget/Makefile +1 -0

index 66becdc..74875a2 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_USBDOWNLOAD_GADGET) += g_dnl.o
 obj-$(CONFIG_DFU_FUNCTION) += f_dfu.o
 obj-$(CONFIG_USB_GADGET_MASS_STORAGE) += f_mass_storage.o
 obj-$(CONFIG_CMD_FASTBOOT) += f_fastboot.o
+obj-y += udc-core.o
 endif
 ifdef CONFIG_USB_ETHER
 obj-y += ether.o

drivers/usb/gadget/udc-core.c new file +5 -0

new file mode 100644
index 0000000..bbe919c
@@ -0,0 +1,229 @@
+/**
+ * udc-core.c - Core UDC Framework
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com
+ *

drivers/usb/gadget/udc-core.c line 11

Quoted 6 lines

drivers/usb/gadget/udc-core.c new file +6 -0

+ * Author: Felipe Balbi <[email protected]>
+ *
+ * Taken from Linux Kernel v3.16 (drivers/usb/gadget/udc-core.c) and ported
+ * to uboot.
+ *
+ * SPDX-License-Identifier:     GPL-2.0+

why are you relicensing this file ? In kernel this is gpl v2 only.

In order to support multiple USB device controllers in uboot, udc-core is needed.

udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/Makefile   |   1 +
 drivers/usb/gadget/udc-core.c | 229

++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 230 insertions(+) create mode 100644 drivers/usb/gadget/udc-core.c

drivers/usb/gadget/Makefile +1 -0

index 66becdc..74875a2 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_USBDOWNLOAD_GADGET) += g_dnl.o
 obj-$(CONFIG_DFU_FUNCTION) += f_dfu.o
 obj-$(CONFIG_USB_GADGET_MASS_STORAGE) += f_mass_storage.o
 obj-$(CONFIG_CMD_FASTBOOT) += f_fastboot.o
+obj-y += udc-core.o
 endif
 ifdef CONFIG_USB_ETHER
 obj-y += ether.o

(quoted diff) +0 -0

b/drivers/usb/gadget/udc-core.c new file mode 100644 index 0000000..bbe919c

drivers/usb/gadget/udc-core.c new file +4 -0

@@ -0,0 +1,229 @@
+/**
+ * udc-core.c - Core UDC Framework
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated -

http://www.ti.com

+ *
+ * Author: Felipe Balbi <[email protected]>
+ *
+ * Taken from Linux Kernel v3.16 (drivers/usb/gadget/udc-core.c) and ported
+ * to uboot.
+ *
+ * SPDX-License-Identifier: GPL-2.0+

+ */

drivers/usb/gadget/udc-core.c new file +17 -0

+
+#include <linux/compat.h>
+#include <malloc.h>
+#include <asm/cache.h>
+#include <common.h>
+
+#include <linux/usb/ch9.h>
+#include <linux/usb/gadget.h>
+
+/**
+ * struct usb_udc - describes one usb device controller
+ * @driver - the gadget driver pointer. For use by the class code
+ * @dev - the child device to the actual controller
+ * @gadget - the gadget. For use by the class code
+ * @list - for use by the udc class driver
+ *
+ * This represents the internal data structure which is used by the

UDC-class
+ * to hold information about udc driver and gadget together.
+ */

drivers/usb/gadget/udc-core.c new file +36 -0

+struct usb_udc {
+	struct usb_gadget_driver	*driver;
+	struct usb_gadget		*gadget;
+	struct list_head		list;
+};
+
+static LIST_HEAD(udc_list);
+
+void usb_gadget_set_state(struct usb_gadget *gadget,
+		enum usb_device_state state)
+{
+	gadget->state = state;
+}
+
+/**
+ * usb_gadget_udc_start - tells usb device controller to start up
+ * @gadget: The gadget we want to get started
+ * @driver: The driver we want to bind to @gadget
+ *
+ * This call is issued by the UDC Class driver when it's about
+ * to register a gadget driver to the device controller, before
+ * calling gadget driver's bind() method.
+ *
+ * It allows the controller to be powered off until strictly
+ * necessary to have it powered on.
+ *
+ * Returns zero on success, else negative errno.
+ */
+static inline int usb_gadget_udc_start(struct usb_gadget *gadget,
+		struct usb_gadget_driver *driver)
+{
+	return gadget->ops->udc_start(gadget, driver);
+}
+
+/**
+ * usb_gadget_udc_stop - tells usb device controller we don't need

it anymore
+ * @gadget: The device we want to stop activity
+ * @driver: The driver to unbind from @gadget
+ *
+ * This call is issued by the UDC Class driver after calling
+ * gadget driver's unbind() method.
+ *
+ * The details are implementation specific, but it can go as
+ * far as powering off UDC completely and disable its data
+ * line pullups.
+ */

drivers/usb/gadget/udc-core.c new file +8 -0

+static inline void usb_gadget_udc_stop(struct usb_gadget *gadget,
+		struct usb_gadget_driver *driver)
+{
+	gadget->ops->udc_stop(gadget, driver);
+}
+
+/**
+ * usb_add_gadget_udc_release - adds a new gadget to the udc class

driver list
+ * @parent: the parent device to this udc. Usually the controller driver's
+ * device.
+ * @gadget: the gadget to be added to the list.
+ * @release: a gadget release function.
+ *
+ * Returns zero on success, negative errno otherwise.
+ */

drivers/usb/gadget/udc-core.c new file +17 -0

+int usb_add_gadget_udc_release(struct usb_gadget *gadget)
+{
+	struct usb_udc		*udc;
+	int			ret = -ENOMEM;
+
+	udc = kzalloc(sizeof(*udc), GFP_KERNEL);
+	if (!udc)
+		return ret;
+
+	udc->gadget = gadget;
+	list_add_tail(&udc->list, &udc_list);
+	usb_gadget_set_state(gadget, USB_STATE_NOTATTACHED);
+	return 0;
+}
+
+/**
+ * usb_add_gadget_udc - adds a new gadget to the udc class driver

list
+ * @parent: the parent device to this udc. Usually the controller
+ * driver's device.
+ * @gadget: the gadget to be added to the list
+ *
+ * Returns zero on success, negative errno otherwise.
+ */

drivers/usb/gadget/udc-core.c new file +46 -0

+int usb_add_gadget_udc(struct usb_gadget *gadget)
+{
+	return usb_add_gadget_udc_release(gadget);
+}
+
+static void usb_gadget_remove_driver(struct usb_udc *udc)
+{
+	dev_dbg(&udc->dev, "unregistering UDC driver [%s]\n",
+			udc->gadget->name);
+	usb_gadget_disconnect(udc->gadget);
+	udc->driver->disconnect(udc->gadget);
+	udc->driver->unbind(udc->gadget);
+	usb_gadget_udc_stop(udc->gadget, NULL);
+
+	udc->driver = NULL;
+}
+
+/**
+ * usb_del_gadget_udc - deletes @udc from udc_list
+ * @gadget: the gadget to be removed.
+ *
+ * This, will call usb_gadget_unregister_driver() if
+ * the @udc is still busy.
+ */
+void usb_del_gadget_udc(struct usb_gadget *gadget)
+{
+	struct usb_udc		*udc = NULL;
+	list_for_each_entry(udc, &udc_list, list)
+		if (udc->gadget == gadget)
+			goto found;
+
+	dev_err(gadget->dev.parent, "gadget not registered.\n");
+	return;
+
+found:
+	dev_vdbg(gadget->dev.parent, "unregistering gadget\n");
+
+	list_del(&udc->list);
+
+	if (udc->driver)
+		usb_gadget_remove_driver(udc);
+
+	kfree(udc);
+}
+
+static int udc_bind_to_driver(struct usb_udc *udc, struct

usb_gadget_driver *driver) +{

drivers/usb/gadget/udc-core.c new file +67 -0

+	int ret;
+
+	dev_dbg(&udc->dev, "registering UDC driver [%s]\n",
+			driver->function);
+
+	udc->driver = driver;
+
+	ret = driver->bind(udc->gadget);
+	if (ret)
+		goto err1;
+
+	ret = usb_gadget_udc_start(udc->gadget, driver);
+	if (ret) {
+		driver->unbind(udc->gadget);
+		goto err1;
+	}
+	usb_gadget_connect(udc->gadget);
+
+	return 0;
+err1:
+	if (ret != -EISNAM)
+		dev_err(&udc->dev, "failed to start %s: %d\n",
+			udc->driver->function, ret);
+	udc->driver = NULL;
+	return ret;
+}
+
+int usb_gadget_register_driver(struct usb_gadget_driver *driver)
+{
+	struct usb_udc		*udc = NULL;
+	int			ret;
+
+	if (!driver || !driver->bind || !driver->setup)
+		return -EINVAL;
+
+	list_for_each_entry(udc, &udc_list, list) {
+		/* For now we take the first one */
+		if (!udc->driver)
+			goto found;
+	}
+
+	debug("couldn't find an available UDC\n");
+	return -ENODEV;
+found:
+	ret = udc_bind_to_driver(udc, driver);
+	return ret;
+}
+
+int usb_gadget_unregister_driver(struct usb_gadget_driver *driver)
+{
+	struct usb_udc		*udc = NULL;
+	int			ret = -ENODEV;
+
+	if (!driver || !driver->unbind)
+		return -EINVAL;
+
+	list_for_each_entry(udc, &udc_list, list)
+		if (udc->driver == driver) {
+			usb_gadget_remove_driver(udc);
+			usb_gadget_set_state(udc->gadget,
+					USB_STATE_NOTATTACHED);
+			ret = 0;
+			break;
+		}
+
+	return ret;
+}

Quoted 11 lines

(quoted diff) +0 -0

b/drivers/usb/gadget/udc-core.c new file mode 100644 index 0000000..bbe919c

drivers/usb/gadget/udc-core.c new file +4 -0

@@ -0,0 +1,229 @@
+/**
+ * udc-core.c - Core UDC Framework
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated -

http://www.ti.com

Quoted 8 lines

+ *
+ * Author: Felipe Balbi <[email protected]>
+ *
+ * Taken from Linux Kernel v3.16 (drivers/usb/gadget/udc-core.c) and ported
+ * to uboot.
+ *
+ * SPDX-License-Identifier: GPL-2.0+

It seems like the author is the same, but the GPL license is different:

Original file ./drivers/usb/gadget/udc/udc-core.c

/**
* udc.c - Core UDCFramework
*
* Copyright (C) 2010 TexasInstruments
* Author: Felipe Balbi<[email protected]>
*
* This program is free software: you can redistribute it and/or
modify
* it under the terms of the GNU General Public License version 2 of
* the License as published by the Free Software Foundation.

If Felipe don't mind then he should give you the permission to add + to the GPL2.

Hi Kishon,

Quoted 2 lines

In order to support multiple USB device controllers in uboot, udc-core is needed.

Is it? In u-boot at best only one UDC is operational at a time.

Quoted 4 lines

udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

I'd appreciate the exact SHA for this udc-core.c code. And the SHA should be from some already released mainline code (like final 3.16), not any private branch nor linux-next.

Quoted 32 lines

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/Makefile   |   1 +
 drivers/usb/gadget/udc-core.c | 229

++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 230 insertions(+) create mode 100644 drivers/usb/gadget/udc-core.c

drivers/usb/gadget/Makefile +1 -0

index 66becdc..74875a2 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_USBDOWNLOAD_GADGET) += g_dnl.o
 obj-$(CONFIG_DFU_FUNCTION) += f_dfu.o
 obj-$(CONFIG_USB_GADGET_MASS_STORAGE) += f_mass_storage.o
 obj-$(CONFIG_CMD_FASTBOOT) += f_fastboot.o
+obj-y += udc-core.o
 endif
 ifdef CONFIG_USB_ETHER
 obj-y += ether.o

(quoted diff) +0 -0

b/drivers/usb/gadget/udc-core.c new file mode 100644 index 0000000..bbe919c

drivers/usb/gadget/udc-core.c new file +4 -0

@@ -0,0 +1,229 @@
+/**
+ * udc-core.c - Core UDC Framework
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated -

http://www.ti.com

Quoted 8 lines

+ *
+ * Author: Felipe Balbi <[email protected]>
+ *
+ * Taken from Linux Kernel v3.16 (drivers/usb/gadget/udc-core.c) and ported
+ * to uboot.
+ *
+ * SPDX-License-Identifier: GPL-2.0+

It seems like the author is the same, but the GPL license is different:

Original file ./drivers/usb/gadget/udc/udc-core.c

/**
* udc.c - Core UDCFramework
*
* Copyright (C) 2010 TexasInstruments
* Author: Felipe Balbi<[email protected]>
*
* This program is free software: you can redistribute it and/or
modify
* it under the terms of the GNU General Public License version 2 of
* the License as published by the Free Software Foundation.

If Felipe don't mind then he should give you the permission to add + to the GPL2.

Quoted 223 lines

+ */

drivers/usb/gadget/udc-core.c new file +17 -0

+
+#include <linux/compat.h>
+#include <malloc.h>
+#include <asm/cache.h>
+#include <common.h>
+
+#include <linux/usb/ch9.h>
+#include <linux/usb/gadget.h>
+
+/**
+ * struct usb_udc - describes one usb device controller
+ * @driver - the gadget driver pointer. For use by the class code
+ * @dev - the child device to the actual controller
+ * @gadget - the gadget. For use by the class code
+ * @list - for use by the udc class driver
+ *
+ * This represents the internal data structure which is used by the

UDC-class
+ * to hold information about udc driver and gadget together.
+ */

drivers/usb/gadget/udc-core.c new file +36 -0

+struct usb_udc {
+	struct usb_gadget_driver	*driver;
+	struct usb_gadget		*gadget;
+	struct list_head		list;
+};
+
+static LIST_HEAD(udc_list);
+
+void usb_gadget_set_state(struct usb_gadget *gadget,
+		enum usb_device_state state)
+{
+	gadget->state = state;
+}
+
+/**
+ * usb_gadget_udc_start - tells usb device controller to start up
+ * @gadget: The gadget we want to get started
+ * @driver: The driver we want to bind to @gadget
+ *
+ * This call is issued by the UDC Class driver when it's about
+ * to register a gadget driver to the device controller, before
+ * calling gadget driver's bind() method.
+ *
+ * It allows the controller to be powered off until strictly
+ * necessary to have it powered on.
+ *
+ * Returns zero on success, else negative errno.
+ */
+static inline int usb_gadget_udc_start(struct usb_gadget *gadget,
+		struct usb_gadget_driver *driver)
+{
+	return gadget->ops->udc_start(gadget, driver);
+}
+
+/**
+ * usb_gadget_udc_stop - tells usb device controller we don't need

it anymore
+ * @gadget: The device we want to stop activity
+ * @driver: The driver to unbind from @gadget
+ *
+ * This call is issued by the UDC Class driver after calling
+ * gadget driver's unbind() method.
+ *
+ * The details are implementation specific, but it can go as
+ * far as powering off UDC completely and disable its data
+ * line pullups.
+ */

drivers/usb/gadget/udc-core.c new file +8 -0

+static inline void usb_gadget_udc_stop(struct usb_gadget *gadget,
+		struct usb_gadget_driver *driver)
+{
+	gadget->ops->udc_stop(gadget, driver);
+}
+
+/**
+ * usb_add_gadget_udc_release - adds a new gadget to the udc class

driver list
+ * @parent: the parent device to this udc. Usually the controller driver's
+ * device.
+ * @gadget: the gadget to be added to the list.
+ * @release: a gadget release function.
+ *
+ * Returns zero on success, negative errno otherwise.
+ */

drivers/usb/gadget/udc-core.c new file +17 -0

+int usb_add_gadget_udc_release(struct usb_gadget *gadget)
+{
+	struct usb_udc		*udc;
+	int			ret = -ENOMEM;
+
+	udc = kzalloc(sizeof(*udc), GFP_KERNEL);
+	if (!udc)
+		return ret;
+
+	udc->gadget = gadget;
+	list_add_tail(&udc->list, &udc_list);
+	usb_gadget_set_state(gadget, USB_STATE_NOTATTACHED);
+	return 0;
+}
+
+/**
+ * usb_add_gadget_udc - adds a new gadget to the udc class driver

list
+ * @parent: the parent device to this udc. Usually the controller
+ * driver's device.
+ * @gadget: the gadget to be added to the list
+ *
+ * Returns zero on success, negative errno otherwise.
+ */

drivers/usb/gadget/udc-core.c new file +46 -0

+int usb_add_gadget_udc(struct usb_gadget *gadget)
+{
+	return usb_add_gadget_udc_release(gadget);
+}
+
+static void usb_gadget_remove_driver(struct usb_udc *udc)
+{
+	dev_dbg(&udc->dev, "unregistering UDC driver [%s]\n",
+			udc->gadget->name);
+	usb_gadget_disconnect(udc->gadget);
+	udc->driver->disconnect(udc->gadget);
+	udc->driver->unbind(udc->gadget);
+	usb_gadget_udc_stop(udc->gadget, NULL);
+
+	udc->driver = NULL;
+}
+
+/**
+ * usb_del_gadget_udc - deletes @udc from udc_list
+ * @gadget: the gadget to be removed.
+ *
+ * This, will call usb_gadget_unregister_driver() if
+ * the @udc is still busy.
+ */
+void usb_del_gadget_udc(struct usb_gadget *gadget)
+{
+	struct usb_udc		*udc = NULL;
+	list_for_each_entry(udc, &udc_list, list)
+		if (udc->gadget == gadget)
+			goto found;
+
+	dev_err(gadget->dev.parent, "gadget not registered.\n");
+	return;
+
+found:
+	dev_vdbg(gadget->dev.parent, "unregistering gadget\n");
+
+	list_del(&udc->list);
+
+	if (udc->driver)
+		usb_gadget_remove_driver(udc);
+
+	kfree(udc);
+}
+
+static int udc_bind_to_driver(struct usb_udc *udc, struct

usb_gadget_driver *driver) +{

drivers/usb/gadget/udc-core.c new file +67 -0

+	int ret;
+
+	dev_dbg(&udc->dev, "registering UDC driver [%s]\n",
+			driver->function);
+
+	udc->driver = driver;
+
+	ret = driver->bind(udc->gadget);
+	if (ret)
+		goto err1;
+
+	ret = usb_gadget_udc_start(udc->gadget, driver);
+	if (ret) {
+		driver->unbind(udc->gadget);
+		goto err1;
+	}
+	usb_gadget_connect(udc->gadget);
+
+	return 0;
+err1:
+	if (ret != -EISNAM)
+		dev_err(&udc->dev, "failed to start %s: %d\n",
+			udc->driver->function, ret);
+	udc->driver = NULL;
+	return ret;
+}
+
+int usb_gadget_register_driver(struct usb_gadget_driver *driver)
+{
+	struct usb_udc		*udc = NULL;
+	int			ret;
+
+	if (!driver || !driver->bind || !driver->setup)
+		return -EINVAL;
+
+	list_for_each_entry(udc, &udc_list, list) {
+		/* For now we take the first one */
+		if (!udc->driver)
+			goto found;
+	}
+
+	debug("couldn't find an available UDC\n");
+	return -ENODEV;
+found:
+	ret = udc_bind_to_driver(udc, driver);
+	return ret;
+}
+
+int usb_gadget_unregister_driver(struct usb_gadget_driver *driver)
+{
+	struct usb_udc		*udc = NULL;
+	int			ret = -ENODEV;
+
+	if (!driver || !driver->unbind)
+		return -EINVAL;
+
+	list_for_each_entry(udc, &udc_list, list)
+		if (udc->driver == driver) {
+			usb_gadget_remove_driver(udc);
+			usb_gadget_set_state(udc->gadget,
+					USB_STATE_NOTATTACHED);
+			ret = 0;
+			break;
+		}
+
+	return ret;
+}

Hi Lukasz,

Quoted 2 lines · Lukasz Majewski

Hi Kishon,

Quoted 4 lines

Quoted 2 lines

In order to support multiple USB device controllers in uboot, udc-core is needed.

Is it? In u-boot at best only one UDC is operational at a time.

I didn't mean operational at the same time. dra7xx has 4 USB controllers and we should allow the user to use any USB port for DFU.

Quoted 7 lines

Quoted 3 lines

udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

I'd appreciate the exact SHA for this udc-core.c code. And the SHA should be from some already released mainline code (like final 3.16), not any private branch nor linux-next.

We can't have the exact udc-core.c from linux kernel as it deals with kernel driver model stuff and vfs which is not needed for kernel. Trying to have the exact same code from kernel complicates it.

Quoted 10 lines · Kishon Vijay Abraham I

Hi Lukasz,

Quoted 6 lines · Lukasz Majewski

Hi Kishon,

Quoted 2 lines

In order to support multiple USB device controllers in uboot, udc-core is needed.

Is it? In u-boot at best only one UDC is operational at a time.

Quoted 3 lines

I didn't mean operational at the same time. dra7xx has 4 USB controllers and we should allow the user to use any USB port for DFU.

but from u-boot's perspective, that can (should?) be a build-time choice. That user, certainly, won't need more than one port active for booting, right ?

Quoted 9 lines

Quoted 8 lines

Quoted 4 lines

udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

I'd appreciate the exact SHA for this udc-core.c code. And the SHA should be from some already released mainline code (like final 3.16), not any private branch nor linux-next.

Quoted 4 lines

We can't have the exact udc-core.c from linux kernel as it deals with kernel driver model stuff and vfs which is not needed for kernel. Trying to have the exact same code from kernel complicates it.

what he means is to point to the SHA1 when you originally forked the code from kernel. Sure udc-core can't be the same, but you based off of a known commit ID frmo the kernel.

Quoted 8 lines · Kishon Vijay Abraham I

Hi Lukasz,

Quoted 5 lines · Lukasz Majewski

Hi Kishon,

Quoted 2 lines

In order to support multiple USB device controllers in uboot, udc-core is needed.

Quoted 4 lines

Quoted 1 line

Is it? In u-boot at best only one UDC is operational at a time.

I didn't mean operational at the same time. dra7xx has 4 USB controllers and we should allow the user to use any USB port for DFU.

but from u-boot's perspective, that can (should?) be a build-time choice. That user, certainly, won't need more than one port active for booting, right ?

Quoted 9 lines

Quoted 8 lines

Quoted 4 lines

udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

I'd appreciate the exact SHA for this udc-core.c code. And the SHA should be from some already released mainline code (like final 3.16), not any private branch nor linux-next.

Quoted 3 lines

We can't have the exact udc-core.c from linux kernel as it deals with kernel driver model stuff and vfs which is not needed for kernel. Trying to have the exact same code from kernel complicates it.

what he means is to point to the SHA1 when you originally forked the code from kernel. Sure udc-core can't be the same, but you based off of a known commit ID frmo the kernel.

Quoted 16 lines

Quoted 13 lines · Kishon Vijay Abraham I

Hi Lukasz,

Quoted 6 lines · Lukasz Majewski

Hi Kishon,

Quoted 2 lines

In order to support multiple USB device controllers in uboot, udc-core is needed.

Is it? In u-boot at best only one UDC is operational at a time.

I didn't mean operational at the same time. dra7xx has 4 USB controllers and we should allow the user to use any USB port for DFU.

Quoted 3 lines

but from u-boot's perspective, that can (should?) be a build-time choice. That user, certainly, won't need more than one port active for booting, right ?

hmm.. right now I don't think any one needs more than one port.

But then without udc core, we have to maintain global variable in gadget.c. Maybe slightly cleaner way is to use udc..

Quoted 14 lines

Quoted 13 lines

Quoted 8 lines

Quoted 4 lines

udc-core also helps to cleanly link the USB peripheral driver with the gadget driver. Hence Ported minimal udc-core from linux kernel.

I'd appreciate the exact SHA for this udc-core.c code. And the SHA should be from some already released mainline code (like final 3.16), not any private branch nor linux-next.

We can't have the exact udc-core.c from linux kernel as it deals with kernel driver model stuff and vfs which is not needed for kernel. Trying to have the exact same code from kernel complicates it.

Quoted 3 lines

what he means is to point to the SHA1 when you originally forked the code from kernel. Sure udc-core can't be the same, but you based off of a known commit ID frmo the kernel.

Ah ok. The header of the file gives the gives the kernel tag it is forked from. Maybe add that in commit log to?

-Kishon

Quoted 1 line

Ported dwc3 driver from linux kernel to uboot.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 Makefile                        |    1 +
 drivers/usb/dwc3/Makefile       |    7 +
 drivers/usb/dwc3/core.c         |  640 +++++++++
 drivers/usb/dwc3/core.h         |  961 +++++++++++++
 drivers/usb/dwc3/ep0.c          | 1045 ++++++++++++++
 drivers/usb/dwc3/gadget.c       | 2841 +++++++++++++++++++++++++++++++++++++++
 drivers/usb/dwc3/gadget.h       |  163 +++
 drivers/usb/dwc3/io.h           |   52 +
 drivers/usb/dwc3/linux-compat.h |  132 ++
 include/dwc3-uboot.h            |   26 +
 10 files changed, 5868 insertions(+)
 create mode 100644 drivers/usb/dwc3/Makefile
 create mode 100644 drivers/usb/dwc3/core.c
 create mode 100644 drivers/usb/dwc3/core.h
 create mode 100644 drivers/usb/dwc3/ep0.c
 create mode 100644 drivers/usb/dwc3/gadget.c
 create mode 100644 drivers/usb/dwc3/gadget.h
 create mode 100644 drivers/usb/dwc3/io.h
 create mode 100644 drivers/usb/dwc3/linux-compat.h
 create mode 100644 include/dwc3-uboot.h

Makefile +1 -0

index cf810a9..c9a18d3 100644
@@ -645,6 +645,7 @@ libs-y += drivers/spi/
 libs-$(CONFIG_FMAN_ENET) += drivers/net/fm/
 libs-$(CONFIG_SYS_FSL_DDR) += drivers/ddr/fsl/
 libs-y += drivers/serial/
+libs-y += drivers/usb/dwc3/
 libs-y += drivers/usb/eth/
 libs-y += drivers/usb/gadget/
 libs-y += drivers/usb/host/

drivers/usb/dwc3/Makefile new file +7 -0

new file mode 100644
index 0000000..fbfa0df
@@ -0,0 +1,7 @@
+ccflags-$(CONFIG_USB_DWC3_DEBUG)	:= -DDEBUG
+ccflags-$(CONFIG_USB_DWC3_VERBOSE)	+= -DVERBOSE_DEBUG
+
+obj-$(CONFIG_USB_DWC3)			+= dwc3.o
+
+dwc3-y					:= core.o
+dwc3-$(CONFIG_USB_DWC3_GADGET)		+= gadget.o ep0.o

drivers/usb/dwc3/core.c new file +2 -0

new file mode 100644
index 0000000..66bbe92
@@ -0,0 +1,640 @@
+/**
+ * core.c - DesignWare USB3 DRD Controller Core file

Quoted 62 lines · Kishon Vijay Abraham I

Ported dwc3 driver from linux kernel to uboot.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 Makefile                        |    1 +
 drivers/usb/dwc3/Makefile       |    7 +
 drivers/usb/dwc3/core.c         |  640 +++++++++
 drivers/usb/dwc3/core.h         |  961 +++++++++++++
 drivers/usb/dwc3/ep0.c          | 1045 ++++++++++++++
 drivers/usb/dwc3/gadget.c       | 2841 +++++++++++++++++++++++++++++++++++++++
 drivers/usb/dwc3/gadget.h       |  163 +++
 drivers/usb/dwc3/io.h           |   52 +
 drivers/usb/dwc3/linux-compat.h |  132 ++
 include/dwc3-uboot.h            |   26 +
 10 files changed, 5868 insertions(+)
 create mode 100644 drivers/usb/dwc3/Makefile
 create mode 100644 drivers/usb/dwc3/core.c
 create mode 100644 drivers/usb/dwc3/core.h
 create mode 100644 drivers/usb/dwc3/ep0.c
 create mode 100644 drivers/usb/dwc3/gadget.c
 create mode 100644 drivers/usb/dwc3/gadget.h
 create mode 100644 drivers/usb/dwc3/io.h
 create mode 100644 drivers/usb/dwc3/linux-compat.h
 create mode 100644 include/dwc3-uboot.h

Makefile +1 -0

index cf810a9..c9a18d3 100644
@@ -645,6 +645,7 @@ libs-y += drivers/spi/
 libs-$(CONFIG_FMAN_ENET) += drivers/net/fm/
 libs-$(CONFIG_SYS_FSL_DDR) += drivers/ddr/fsl/
 libs-y += drivers/serial/
+libs-y += drivers/usb/dwc3/
 libs-y += drivers/usb/eth/
 libs-y += drivers/usb/gadget/
 libs-y += drivers/usb/host/

drivers/usb/dwc3/Makefile new file +7 -0

new file mode 100644
index 0000000..fbfa0df
@@ -0,0 +1,7 @@
+ccflags-$(CONFIG_USB_DWC3_DEBUG)	:= -DDEBUG
+ccflags-$(CONFIG_USB_DWC3_VERBOSE)	+= -DVERBOSE_DEBUG
+
+obj-$(CONFIG_USB_DWC3)			+= dwc3.o
+
+dwc3-y					:= core.o
+dwc3-$(CONFIG_USB_DWC3_GADGET)		+= gadget.o ep0.o

drivers/usb/dwc3/core.c new file +6 -0

new file mode 100644
index 0000000..66bbe92
@@ -0,0 +1,640 @@
+/**
+ * core.c - DesignWare USB3 DRD Controller Core file
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com
+ *
+ * Authors: Felipe Balbi <[email protected]>,

drivers/usb/dwc3/core.c line 12

Quoted 6 lines

drivers/usb/dwc3/core.c new file +6 -0

+ *	    Sebastian Andrzej Siewior <[email protected]>
+ *
+ * Taken from Linux Kernel v3.16 (drivers/usb/dwc3/core.c) and ported
+ * to uboot.
+ *
+ * SPDX-License-Identifier:     GPL-2.0+

same here. Please review all patches to make sure license is correct.

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/composite.c | 3 +--
 drivers/usb/gadget/g_dnl.c     | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/usb/gadget/composite.c +0 -0

index 7bd2562..60ca9a5 100644

Quoted 4 lines · Kishon Vijay Abraham I

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Quoted 12 lines

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/composite.c | 3 +--
 drivers/usb/gadget/g_dnl.c     | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

(quoted diff) +0 -0

b/drivers/usb/gadget/composite.c index 7bd2562..60ca9a5 100644

drivers/usb/gadget/composite.c static int set_config(struct usb_composite_dev · line 334

Quoted 5 lines

drivers/usb/gadget/composite.c +1 -1

@@ -331,7 +331,7 @@ static int set_config(struct usb_composite_dev
 *cdev, } else
 		result = 0;
 
-	debug("%s: %s speed config #%d: %s\n", __func__,
+	printf("%s: %s speed config #%d: %s\n", __func__,

this looks like it's only needed for debugging. No strong feelings though

drivers/usb/gadget/composite.c static int composite_bind(struct usb_gadget · line 990

Quoted 5 lines

drivers/usb/gadget/composite.c +0 -1

@@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget
 *gadget) 
 	memcpy(&cdev->desc, composite->dev,
 	       sizeof(struct usb_device_descriptor));
-	cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;

why are you dropping this line ?

Quoted 4 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Hi Kishon,

Quoted 4 lines

Quoted 4 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

It seems like this patch slipped without my attention ...

Hence, I'd like to ask why you must hardcode the packet size here?

Quoted 7 lines · Lukasz Majewski

Hi Kishon,

Quoted 4 lines

Quoted 4 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Quoted 3 lines

It seems like this patch slipped without my attention ...

Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU Mode Device Descriptor), specifies the bMaxPacketSize0 can be 8,16,32,64. And the value we get from gadget is 512. So hard coded it.

Quoted 12 lines · Kishon Vijay Abraham I

Quoted 9 lines · Lukasz Majewski

Hi Kishon,

Quoted 4 lines

Quoted 4 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

It seems like this patch slipped without my attention ...

Quoted 6 lines

Quoted 1 line

Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU Mode Device Descriptor), specifies the bMaxPacketSize0 can be 8,16,32,64. And the value we get from gadget is 512. So hard coded it.

as I mentioned, this should be changed on connection done interrupt.

DFU has one of the poorest documentations for a USB Class and has some moronic definitions.

What happens if you want ot run DFU with a
superspeed controller (such as dwc3) when connected to a superspeed port. We cannot use ep0 packet size as 64, right ?

That's why
hardcoding is bad ;-)

Hi Felipe,

Quoted 16 lines

Quoted 14 lines · Kishon Vijay Abraham I

Quoted 10 lines · Lukasz Majewski

Hi Kishon,

Quoted 4 lines

Quoted 4 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

It seems like this patch slipped without my attention ...

Hence, I'd like to ask why you must hardcode the packet size here?

Quoted 6 lines

Quoted 4 lines

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU Mode Device Descriptor), specifies the bMaxPacketSize0 can be 8,16,32,64. And the value we get from gadget is 512. So hard coded it.

as I mentioned, this should be changed on connection done interrupt.

In the u-boot it is set up during binding the composite.

Quoted 2 lines

DFU has one of the poorest documentations for a USB Class and has some moronic definitions.

Frankly speaking I prefer to have the worst standard than some "brilliant" in house developed protocols.

Quoted 3 lines

What happens if you want ot run DFU with a
superspeed controller (such as dwc3) when connected to a superspeed port. We cannot use ep0 packet size as 64, right ?

Correct me if I'm wrong, but MaxPacket for SS ep0 is 2^9 = 512B. I'm curious if dfu-util will manage to handle ep0 MaxPacket size up to 512B.
It not, then we shall be able to fallback to 64B.

Quoted 25 lines

Hi Felipe,

Quoted 23 lines

Quoted 20 lines · Kishon Vijay Abraham I

Quoted 8 lines · Lukasz Majewski

Hi Kishon,

Quoted 5 lines

Quoted 5 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Quoted 4 lines

It seems like this patch slipped without my attention ...

Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU Mode Device Descriptor), specifies the bMaxPacketSize0 can be 8,16,32,64. And the value we get from gadget is 512. So hard coded it.

Quoted 4 lines

Quoted 2 lines

as I mentioned, this should be changed on connection done interrupt.

In the u-boot it is set up during binding the composite.

look at dwc3. dwc3 has a connection done IRQ which also tells me the negotiated link speed.

Quoted 6 lines

Quoted 3 lines

DFU has one of the poorest documentations for a USB Class and has some moronic definitions.

Frankly speaking I prefer to have the worst standard than some "brilliant" in house developed protocols.

nobody is talking about changing the protocol. DFU was written back when Full speed was the fastest USB on earth.

Quoted 5 lines

Quoted 4 lines

What happens if you want ot run DFU with a superspeed controller (such as dwc3) when connected to a superspeed port. We cannot use ep0 packet size as 64, right ?

Quoted 4 lines

Correct me if I'm wrong, but MaxPacket for SS ep0 is 2^9 = 512B. I'm curious if dfu-util will manage to handle ep0 MaxPacket size up to 512B.
It not, then we shall be able to fallback to 64B.

should be a test away.

Hi Felipe,

Quoted 29 lines · Lukasz Majewski

Quoted 28 lines

Hi Felipe,

Quoted 25 lines

Quoted 13 lines · Kishon Vijay Abraham I

Quoted 10 lines · Lukasz Majewski

Hi Kishon,

Quoted 5 lines

Quoted 5 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

It seems like this patch slipped without my attention ...

Quoted 7 lines

Quoted 2 lines

Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU Mode Device Descriptor), specifies the bMaxPacketSize0 can be 8,16,32,64. And the value we get from gadget is 512. So hard coded it.

as I mentioned, this should be changed on connection done interrupt.

Quoted 4 lines

Quoted 1 line

In the u-boot it is set up during binding the composite.

look at dwc3. dwc3 has a connection done IRQ which also tells me the negotiated link speed.

My point is that you will need to pool in u-boot to emulate this IRQ.

Quoted 8 lines

Quoted 5 lines

Quoted 2 lines

DFU has one of the poorest documentations for a USB Class and has some moronic definitions.

Frankly speaking I prefer to have the worst standard than some "brilliant" in house developed protocols.

nobody is talking about changing the protocol. DFU was written back when Full speed was the fastest USB on earth.

As you can see the standard is a bit old now... and should be revised.

Quoted 7 lines

Hi Kishon,

Quoted 4 lines

Quoted 4 lines

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Quoted 3 lines

It seems like this patch slipped without my attention ...

Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU Mode Device Descriptor), specifies the bMaxPacketSize0 can be 8,16,32,64. And the value we get from gadget is 512. So hard coded it.

Thanks
Kishon

Quoted 19 lines · Kishon Vijay Abraham I

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/composite.c | 3 +--
 drivers/usb/gadget/g_dnl.c     | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/usb/gadget/composite.c +0 -0

index 7bd2562..60ca9a5 100644
@@ -331,7 +331,7 @@ static int set_config(struct usb_composite_dev *cdev,
 	} else
 		result = 0;
 

drivers/usb/gadget/composite.c static int set_config(struct usb_composite_dev *cdev, · line 334

Quoted 2 lines

drivers/usb/gadget/composite.c +1 -1

-	debug("%s: %s speed config #%d: %s\n", __func__,
+	printf("%s: %s speed config #%d: %s\n", __func__,

this looks like it's only needed for debugging. No strong feelings though

drivers/usb/gadget/composite.c static int composite_bind(struct usb_gadget *gadget) · line 990

Quoted 6 lines

drivers/usb/gadget/composite.c +0 -1

@@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget *gadget)
 
 	memcpy(&cdev->desc, composite->dev,
 	       sizeof(struct usb_device_descriptor));
-	cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;

why are you dropping this line ?

Quoted 20 lines · Felipe Balbi

Quoted 19 lines · Kishon Vijay Abraham I

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/composite.c | 3 +--
 drivers/usb/gadget/g_dnl.c     | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/usb/gadget/composite.c +0 -0

index 7bd2562..60ca9a5 100644
@@ -331,7 +331,7 @@ static int set_config(struct usb_composite_dev *cdev,
 	} else
 		result = 0;
 

Quoted 5 lines

drivers/usb/gadget/composite.c static int set_config(struct usb_composite_dev *cdev, · line 334

Quoted 2 lines

drivers/usb/gadget/composite.c +1 -1

-	debug("%s: %s speed config #%d: %s\n", __func__,
+	printf("%s: %s speed config #%d: %s\n", __func__,

this looks like it's only needed for debugging. No strong feelings though

yeah.. it helps to know if the device has been enumerated.

Quoted 8 lines

drivers/usb/gadget/composite.c static int composite_bind(struct usb_gadget *gadget) · line 990

Quoted 6 lines

drivers/usb/gadget/composite.c +0 -1

@@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget *gadget)
 
 	memcpy(&cdev->desc, composite->dev,
 	       sizeof(struct usb_device_descriptor));
-	cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;

why are you dropping this line ?

Actually faced an issue with this. DWC3 gadget sets ep0 maxpacket size to 512 and if the device is operating at hight speed, the bMaxPacketSize0 field should be 64?

If the maxpacket size is set to 512, the host reports Invalid EP0 Maxpacket.

Hi,

Quoted 37 lines · Kishon Vijay Abraham I

Quoted 20 lines · Felipe Balbi

Quoted 19 lines · Kishon Vijay Abraham I

Explicity set the max packet size in the device descriptor to 0x40 as specified in the device class specification for device firmware upgrade. Also changed debug to printf to explicitly notify the user if the device has been enumerated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 drivers/usb/gadget/composite.c | 3 +--
 drivers/usb/gadget/g_dnl.c     | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/usb/gadget/composite.c +0 -0

index 7bd2562..60ca9a5 100644
@@ -331,7 +331,7 @@ static int set_config(struct usb_composite_dev *cdev,
 	} else
 		result = 0;
 

Quoted 5 lines

drivers/usb/gadget/composite.c static int set_config(struct usb_composite_dev *cdev, · line 334

Quoted 2 lines

drivers/usb/gadget/composite.c +1 -1

-	debug("%s: %s speed config #%d: %s\n", __func__,
+	printf("%s: %s speed config #%d: %s\n", __func__,

this looks like it's only needed for debugging. No strong feelings though

yeah.. it helps to know if the device has been enumerated.

Quoted 8 lines

drivers/usb/gadget/composite.c static int composite_bind(struct usb_gadget *gadget) · line 990

Quoted 6 lines

drivers/usb/gadget/composite.c +0 -1

@@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget *gadget)
 
 	memcpy(&cdev->desc, composite->dev,
 	       sizeof(struct usb_device_descriptor));
-	cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;

why are you dropping this line ?

Quoted 3 lines

Actually faced an issue with this. DWC3 gadget sets ep0 maxpacket size to 512 and if the device is operating at hight speed, the bMaxPacketSize0 field should be 64?

right, but that's changed on connection done IRQ.

Quoted 2 lines

If the maxpacket size is set to 512, the host reports Invalid EP0 Maxpacket.

huh ? who broke dwc3 ? connection done happens before we receive the first setup packet, how can host complain about anything ?

Quoted 14 lines

Quoted 11 lines

Quoted 7 lines

drivers/usb/gadget/composite.c static int composite_bind(struct usb_gadget *gadget) · line 990

Quoted 5 lines

drivers/usb/gadget/composite.c +0 -1

@@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget *gadget)
 
 	memcpy(&cdev->desc, composite->dev,
 	       sizeof(struct usb_device_descriptor));
-	cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;

why are you dropping this line ?

Actually faced an issue with this. DWC3 gadget sets ep0 maxpacket size to 512 and if the device is operating at hight speed, the bMaxPacketSize0 field should be 64?

right, but that's changed on connection done IRQ.

Quoted 6 lines

Quoted 2 lines

If the maxpacket size is set to 512, the host reports Invalid EP0 Maxpacket.

huh ? who broke dwc3 ? connection done happens before we receive the first setup packet, how can host complain about anything ?

composite_bind() (where maxpacket is being set) happens much before connection done interrupt. So it's not dwc3's fault.

Hi,

Quoted 17 lines · Kishon Vijay Abraham I

Quoted 17 lines

Quoted 11 lines

Quoted 7 lines

drivers/usb/gadget/composite.c static int composite_bind(struct usb_gadget *gadget) · line 990

Quoted 5 lines

drivers/usb/gadget/composite.c +0 -1

@@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget *gadget)
 
 	memcpy(&cdev->desc, composite->dev,
 	       sizeof(struct usb_device_descriptor));
-	cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;

why are you dropping this line ?

Actually faced an issue with this. DWC3 gadget sets ep0 maxpacket size to 512 and if the device is operating at hight speed, the bMaxPacketSize0 field should be 64?

right, but that's changed on connection done IRQ.

Quoted 2 lines

If the maxpacket size is set to 512, the host reports Invalid EP0 Maxpacket.

Quoted 5 lines

Quoted 3 lines

huh ? who broke dwc3 ? connection done happens before we receive the first setup packet, how can host complain about anything ?

composite_bind() (where maxpacket is being set) happens much before connection done interrupt. So it's not dwc3's fault.

seems like you're just missing a few fixes to composite.c, such as commit 765f5b830e547229bb752e7b232ee83e2b3d49d5

Since there can be multiple USB controllers in the system, usb_gadget_handle_interrupts should take controller index as arguments.

However such an API can only be added in board file so added board_usb_gadget_handle_interrupts(). usb_gadget_handle_interrupts() should be deprecated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 common/cmd_dfu.c | 1 +
 include/usb.h    | 7 +++++++
 2 files changed, 8 insertions(+)

common/cmd_dfu.c +0 -0

index 1e7d50c..f27ba52 100644

common/cmd_dfu.c +0 -0

 	}
 exit:
 	g_dnl_unregister();

include/usb.h +0 -0

index d9fedee..26c6462 100644
@@ -197,6 +197,13 @@ int board_usb_init(int index, enum usb_init_type

init); */
int board_usb_cleanup(int index, enum usb_init_type init);

include/usb.h +7 -0

+/*
+ * Can be use to handle interrupts from a specific controller.
+ *
+ * @index index of the USB controller
+ */
+int board_usb_gadget_handle_interrupts(int index);
+
 #ifdef CONFIG_USB_STORAGE
 
 #define USB_MAX_STOR_DEV 5

Hi Kishon,

Quoted 3 lines

Since there can be multiple USB controllers in the system, usb_gadget_handle_interrupts should take controller index as arguments.

The controller index is passed in the ums/dfu/thor command. Then PHY subsystem is properly configured.
Since we only handle one USB controller transmission at a time (u-boot doesn't use interrupts - we only pool) the usb_gadget_handle_interrupts() was enough for our purpose.

To start transmission from other usb controller you need to end current transmission and then invoke modified command with different controller number.

It would be enough to extend usb_gadget_handle_interrupts() to accept controller index argument (only six boards use it - it shall be easy to modify them all).

Quoted 15 lines

However such an API can only be added in board file so added board_usb_gadget_handle_interrupts(). usb_gadget_handle_interrupts() should be deprecated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 common/cmd_dfu.c | 1 +
 include/usb.h    | 7 +++++++
 2 files changed, 8 insertions(+)

common/cmd_dfu.c +0 -0

index 1e7d50c..f27ba52 100644

common/cmd_dfu.c static int do_dfu(cmd_tbl_t *cmdtp, int flag, int · line 55

Quoted 4 lines

common/cmd_dfu.c +1 -0

@@ -52,6 +52,7 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int
 argc, char * const argv[]) goto exit;
 
 		usb_gadget_handle_interrupts();
+		board_usb_gadget_handle_interrupts(controller_index);

NAK, for the reason stated above.

Quoted 21 lines

common/cmd_dfu.c +0 -0

 	}
 exit:
 	g_dnl_unregister();

include/usb.h +0 -0

index d9fedee..26c6462 100644
@@ -197,6 +197,13 @@ int board_usb_init(int index, enum usb_init_type

init); */
int board_usb_cleanup(int index, enum usb_init_type init);

include/usb.h +7 -0

+/*
+ * Can be use to handle interrupts from a specific controller.
+ *
+ * @index index of the USB controller
+ */
+int board_usb_gadget_handle_interrupts(int index);
+
 #ifdef CONFIG_USB_STORAGE
 
 #define USB_MAX_STOR_DEV 5

Hi,

Quoted 6 lines · Lukasz Majewski

Hi Kishon,

Quoted 3 lines

Since there can be multiple USB controllers in the system, usb_gadget_handle_interrupts should take controller index as arguments.

Quoted 5 lines

The controller index is passed in the ums/dfu/thor command. Then PHY subsystem is properly configured.
Since we only handle one USB controller transmission at a time (u-boot doesn't use interrupts - we only pool) the usb_gadget_handle_interrupts() was enough for our purpose.

yeah, if we have only one USB controller in the system, controller index is not needed.

-Kishon

Quoted 56 lines

To start transmission from other usb controller you need to end current transmission and then invoke modified command with different controller number.

It would be enough to extend usb_gadget_handle_interrupts() to accept controller index argument (only six boards use it - it shall be easy to modify them all).

Quoted 15 lines

However such an API can only be added in board file so added board_usb_gadget_handle_interrupts(). usb_gadget_handle_interrupts() should be deprecated.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 common/cmd_dfu.c | 1 +
 include/usb.h    | 7 +++++++
 2 files changed, 8 insertions(+)

common/cmd_dfu.c +0 -0

index 1e7d50c..f27ba52 100644

common/cmd_dfu.c static int do_dfu(cmd_tbl_t *cmdtp, int flag, int · line 56

Quoted 5 lines

common/cmd_dfu.c +1 -0

@@ -52,6 +52,7 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int
 argc, char * const argv[]) goto exit;
 
 		usb_gadget_handle_interrupts();
+
 board_usb_gadget_handle_interrupts(controller_index);

NAK, for the reason stated above.

Quoted 21 lines

common/cmd_dfu.c +0 -0

 	}
 exit:

common/cmd_dfu.c +0 -0

 	g_dnl_unregister();

include/usb.h +0 -0

index d9fedee..26c6462 100644
@@ -197,6 +197,13 @@ int board_usb_init(int index, enum

usb_init_type init); */
int board_usb_cleanup(int index, enum usb_init_type init);

include/usb.h +7 -0

+/*
+ * Can be use to handle interrupts from a specific controller.
+ *
+ * @index index of the USB controller
+ */
+int board_usb_gadget_handle_interrupts(int index);
+
 #ifdef CONFIG_USB_STORAGE
 
 #define USB_MAX_STOR_DEV 5

Implemented board_usb_init(), board_usb_cleanup() and board_usb_gadget_handle_interrupts() in dra7xx board file that can be invoked by various gadget drivers.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 arch/arm/include/asm/arch-omap5/omap.h |  12 ++++
 board/ti/dra7xx/evm.c                  | 106 +++++++++++++++++++++++++++++++++
 2 files changed, 118 insertions(+)

arch/arm/include/asm/arch-omap5/omap.h +12 -0

index b9600cf..a2348a2 100644
@@ -33,6 +33,18 @@
 #define CONTROL_ID_CODE		CONTROL_CORE_ID_CODE
 #endif
 
+#ifdef CONFIG_DRA7XX
+#define DRA7_USB_OTG_SS1_BASE		0x48890000
+#define DRA7_USB_OTG_SS1_GLUE_BASE	0x48880000
+#define DRA7_USB3_PHY1_PLL_CTRL		0x4A084C00
+#define DRA7_USB3_PHY1_POWER		0x4A002370
+#define DRA7_USB2_PHY1_POWER		0x4A002300
+
+#define DRA7_USB_OTG_SS2_BASE		0x488D0000
+#define DRA7_USB_OTG_SS2_GLUE_BASE	0x488C0000
+#define DRA7_USB2_PHY2_POWER		0x4A002E74
+#endif
+
 /* To be verified */
 #define OMAP5430_CONTROL_ID_CODE_ES1_0		0x0B94202F
 #define OMAP5430_CONTROL_ID_CODE_ES2_0          0x1B94202F

board/ti/dra7xx/evm.c +4 -0

index 073d151..0d1b93f 100644
@@ -13,10 +13,14 @@
 #include <common.h>
 #include <palmas.h>
 #include <sata.h>
+#include <usb.h>
 #include <asm/arch/sys_proto.h>
 #include <asm/arch/mmc_host_def.h>
 #include <asm/arch/sata.h>
 #include <environment.h>
+#include <dwc3-uboot.h>
+#include <dwc3-omap-uboot.h>
+#include <ti-usb-phy-uboot.h>
 
 #include "mux_data.h"
 

Quoted 56 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and board_usb_gadget_handle_interrupts() in dra7xx board file that can be invoked by various gadget drivers.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 arch/arm/include/asm/arch-omap5/omap.h |  12 ++++
 board/ti/dra7xx/evm.c                  | 106 +++++++++++++++++++++++++++++++++
 2 files changed, 118 insertions(+)

arch/arm/include/asm/arch-omap5/omap.h +12 -0

index b9600cf..a2348a2 100644
@@ -33,6 +33,18 @@
 #define CONTROL_ID_CODE		CONTROL_CORE_ID_CODE
 #endif
 
+#ifdef CONFIG_DRA7XX
+#define DRA7_USB_OTG_SS1_BASE		0x48890000
+#define DRA7_USB_OTG_SS1_GLUE_BASE	0x48880000
+#define DRA7_USB3_PHY1_PLL_CTRL		0x4A084C00
+#define DRA7_USB3_PHY1_POWER		0x4A002370
+#define DRA7_USB2_PHY1_POWER		0x4A002300
+
+#define DRA7_USB_OTG_SS2_BASE		0x488D0000
+#define DRA7_USB_OTG_SS2_GLUE_BASE	0x488C0000
+#define DRA7_USB2_PHY2_POWER		0x4A002E74
+#endif
+
 /* To be verified */
 #define OMAP5430_CONTROL_ID_CODE_ES1_0		0x0B94202F
 #define OMAP5430_CONTROL_ID_CODE_ES2_0          0x1B94202F

board/ti/dra7xx/evm.c +4 -0

index 073d151..0d1b93f 100644
@@ -13,10 +13,14 @@
 #include <common.h>
 #include <palmas.h>
 #include <sata.h>
+#include <usb.h>
 #include <asm/arch/sys_proto.h>
 #include <asm/arch/mmc_host_def.h>
 #include <asm/arch/sata.h>
 #include <environment.h>
+#include <dwc3-uboot.h>
+#include <dwc3-omap-uboot.h>
+#include <ti-usb-phy-uboot.h>
 
 #include "mux_data.h"
 

@@ -125,6 +129,108 @@ int board_mmc_init(bd_t *bis)
 }
 #endif
 

board/ti/dra7xx/evm.c int board_mmc_init(bd_t *bis) · line 135

Quoted 4 lines

board/ti/dra7xx/evm.c +4 -0

+static struct dwc3_device usb_otg_ss1 = {
+	.maximum_speed = USB_SPEED_SUPER,
+	.base = DRA7_USB_OTG_SS1_BASE,
+	.needs_fifo_resize = true,

make sure this is *really* needed. The only SoC which has needed this was OMAP5 ES1 due to a nice little "feature" IP folks left in there :-)

Hi Felipe,

Quoted 57 lines · Felipe Balbi

Quoted 56 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and board_usb_gadget_handle_interrupts() in dra7xx board file that can be invoked by various gadget drivers.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 arch/arm/include/asm/arch-omap5/omap.h |  12 ++++
 board/ti/dra7xx/evm.c                  | 106 +++++++++++++++++++++++++++++++++
 2 files changed, 118 insertions(+)

arch/arm/include/asm/arch-omap5/omap.h +12 -0

index b9600cf..a2348a2 100644
@@ -33,6 +33,18 @@
 #define CONTROL_ID_CODE		CONTROL_CORE_ID_CODE
 #endif
 
+#ifdef CONFIG_DRA7XX
+#define DRA7_USB_OTG_SS1_BASE		0x48890000
+#define DRA7_USB_OTG_SS1_GLUE_BASE	0x48880000
+#define DRA7_USB3_PHY1_PLL_CTRL		0x4A084C00
+#define DRA7_USB3_PHY1_POWER		0x4A002370
+#define DRA7_USB2_PHY1_POWER		0x4A002300
+
+#define DRA7_USB_OTG_SS2_BASE		0x488D0000
+#define DRA7_USB_OTG_SS2_GLUE_BASE	0x488C0000
+#define DRA7_USB2_PHY2_POWER		0x4A002E74
+#endif
+
 /* To be verified */
 #define OMAP5430_CONTROL_ID_CODE_ES1_0		0x0B94202F
 #define OMAP5430_CONTROL_ID_CODE_ES2_0          0x1B94202F

board/ti/dra7xx/evm.c +4 -0

index 073d151..0d1b93f 100644
@@ -13,10 +13,14 @@
 #include <common.h>
 #include <palmas.h>
 #include <sata.h>
+#include <usb.h>
 #include <asm/arch/sys_proto.h>
 #include <asm/arch/mmc_host_def.h>
 #include <asm/arch/sata.h>
 #include <environment.h>
+#include <dwc3-uboot.h>
+#include <dwc3-omap-uboot.h>
+#include <ti-usb-phy-uboot.h>
 
 #include "mux_data.h"
 

@@ -125,6 +129,108 @@ int board_mmc_init(bd_t *bis)
 }
 #endif
 

Quoted 7 lines

board/ti/dra7xx/evm.c int board_mmc_init(bd_t *bis) · line 135

Quoted 4 lines

board/ti/dra7xx/evm.c +4 -0

+static struct dwc3_device usb_otg_ss1 = {
+	.maximum_speed = USB_SPEED_SUPER,
+	.base = DRA7_USB_OTG_SS1_BASE,
+	.needs_fifo_resize = true,

make sure this is *really* needed. The only SoC which has needed this was OMAP5 ES1 due to a nice little "feature" IP folks left in there :-)

ah.. "tx-fifo-resize" is set in dra7.dtsi.

Quoted 68 lines · Kishon Vijay Abraham I

Hi Felipe,

Quoted 64 lines · Felipe Balbi

Quoted 53 lines · Kishon Vijay Abraham I

Implemented board_usb_init(), board_usb_cleanup() and board_usb_gadget_handle_interrupts() in dra7xx board file that can be invoked by various gadget drivers.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 arch/arm/include/asm/arch-omap5/omap.h |  12 ++++
 board/ti/dra7xx/evm.c                  | 106 +++++++++++++++++++++++++++++++++
 2 files changed, 118 insertions(+)

arch/arm/include/asm/arch-omap5/omap.h +12 -0

index b9600cf..a2348a2 100644
@@ -33,6 +33,18 @@
 #define CONTROL_ID_CODE		CONTROL_CORE_ID_CODE
 #endif
 
+#ifdef CONFIG_DRA7XX
+#define DRA7_USB_OTG_SS1_BASE		0x48890000
+#define DRA7_USB_OTG_SS1_GLUE_BASE	0x48880000
+#define DRA7_USB3_PHY1_PLL_CTRL		0x4A084C00
+#define DRA7_USB3_PHY1_POWER		0x4A002370
+#define DRA7_USB2_PHY1_POWER		0x4A002300
+
+#define DRA7_USB_OTG_SS2_BASE		0x488D0000
+#define DRA7_USB_OTG_SS2_GLUE_BASE	0x488C0000
+#define DRA7_USB2_PHY2_POWER		0x4A002E74
+#endif
+
 /* To be verified */
 #define OMAP5430_CONTROL_ID_CODE_ES1_0		0x0B94202F
 #define OMAP5430_CONTROL_ID_CODE_ES2_0          0x1B94202F

board/ti/dra7xx/evm.c +4 -0

index 073d151..0d1b93f 100644
@@ -13,10 +13,14 @@
 #include <common.h>
 #include <palmas.h>
 #include <sata.h>
+#include <usb.h>
 #include <asm/arch/sys_proto.h>
 #include <asm/arch/mmc_host_def.h>
 #include <asm/arch/sata.h>
 #include <environment.h>
+#include <dwc3-uboot.h>
+#include <dwc3-omap-uboot.h>
+#include <ti-usb-phy-uboot.h>
 
 #include "mux_data.h"
 

board/ti/dra7xx/evm.c int board_mmc_init(bd_t *bis) · line 135

Quoted 7 lines

board/ti/dra7xx/evm.c +4 -0

@@ -125,6 +129,108 @@ int board_mmc_init(bd_t *bis)
 }
 #endif
 
+static struct dwc3_device usb_otg_ss1 = {
+	.maximum_speed = USB_SPEED_SUPER,
+	.base = DRA7_USB_OTG_SS1_BASE,
+	.needs_fifo_resize = true,

make sure this is *really* needed. The only SoC which has needed this was OMAP5 ES1 due to a nice little "feature" IP folks left in there :-)

Quoted 1 line

ah.. "tx-fifo-resize" is set in dra7.dtsi.

hmm, I don't think it needs to be :-) not sure if you remember but early OMAP5 samples had a default TX fifo configuration of less than one superspeed bulk packet (less than 1024 bytes) :-)

Implemented __weak functions for board_usb_cleanup, board_usb_gadget_handle_interrupts and usb_gadget_handle_interrupts to get of compiler errors in platforms that haven't implemented these functions.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 common/usb.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

common/usb.c +0 -0

index 60daa10..892bf7c 100644

common/usb.c +12 -0

+
+__weak
+int board_usb_gadget_handle_interrupts(int index)
+{
+	return 0;
+}
+
+__weak
+int usb_gadget_handle_interrupts(void)
+{
+	return 0;
+}
 /* EOF */

Hi Kishon,

Quoted 19 lines

Implemented __weak functions for board_usb_cleanup, board_usb_gadget_handle_interrupts and usb_gadget_handle_interrupts to get of compiler errors in platforms that haven't implemented these functions.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 common/usb.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

common/usb.c +1 -0

index 60daa10..892bf7c 100644
@@ -1072,4 +1072,22 @@ int board_usb_init(int index, enum
 usb_init_type init) {
 	return 0;
 }
+

common/usb.c int board_usb_init(int index, enum usb_init_type init) · line 1080

Quoted 5 lines

common/usb.c +5 -0

+__weak
+int board_usb_cleanup(int index, enum usb_init_type init)
+{
+	return 0;
+}

This needed before [PATCH 7/13]. Without it your code will cause u-boot repository to not be bisectable.

Quoted 14 lines

common/usb.c +12 -0

+
+__weak
+int board_usb_gadget_handle_interrupts(int index)
+{
+	return 0;
+}
+
+__weak
+int usb_gadget_handle_interrupts(void)
+{
+	return 0;
+}
 /* EOF */

Quoted 21 lines · Lukasz Majewski

Hi Kishon,

Quoted 19 lines

Implemented __weak functions for board_usb_cleanup, board_usb_gadget_handle_interrupts and usb_gadget_handle_interrupts to get of compiler errors in platforms that haven't implemented these functions.

Signed-off-by Kishon Vijay Abraham I <[email protected]>

---
 common/usb.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

common/usb.c +1 -0

index 60daa10..892bf7c 100644
@@ -1072,4 +1072,22 @@ int board_usb_init(int index, enum
 usb_init_type init) {
 	return 0;
 }
+

Quoted 8 lines

common/usb.c int board_usb_init(int index, enum usb_init_type init) · line 1080

Quoted 5 lines

common/usb.c +5 -0

+__weak
+int board_usb_cleanup(int index, enum usb_init_type init)
+{
+	return 0;
+}

This needed before [PATCH 7/13]. Without it your code will cause u-boot repository to not be bisectable.

hmm. ok

Bounce buffer is used for transferring requests which is not maxpacket aligned. In the case of DFU the requests can be upto 4096 bytes.

While the actual fix for this should be using two chained TRBs to handle the transfer, this can be used as a temporary fix.

Quoted 5 lines · Kishon Vijay Abraham I

Bounce buffer is used for transferring requests which is not maxpacket aligned. In the case of DFU the requests can be upto 4096 bytes.

While the actual fix for this should be using two chained TRBs to handle the transfer, this can be used as a temporary fix.

Did you manage to trigger this fault ? Was the size larger than 512 ?

I'm inclined into getting a real fix instead of just patching around.

That way, the kernel benefits too as we can port the same patch there.

Hi,

Quoted 4 lines · Felipe Balbi

Quoted 3 lines · Kishon Vijay Abraham I

Bounce buffer is used for transferring requests which is not maxpacket aligned. In the case of DFU the requests can be upto 4096 bytes.

Quoted 4 lines

Quoted 2 lines

While the actual fix for this should be using two chained TRBs to handle the transfer, this can be used as a temporary fix.

Did you manage to trigger this fault ? Was the size larger than 512 ?

yeah.. transferring any kernel image resulted in a size larger than 512.

Quoted 7 lines · Kishon Vijay Abraham I

Hi,

Quoted 4 lines · Felipe Balbi

Quoted 3 lines · Kishon Vijay Abraham I

Bounce buffer is used for transferring requests which is not maxpacket aligned. In the case of DFU the requests can be upto 4096 bytes.

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

While the actual fix for this should be using two chained TRBs to handle the transfer, this can be used as a temporary fix.

Did you manage to trigger this fault ? Was the size larger than 512 ?

yeah.. transferring any kernel image resulted in a size larger than 512.

but it's also larger than 4KiB :-)

Hi,

Quoted 13 lines · Felipe Balbi

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 8 lines · Felipe Balbi

Quoted 5 lines · Kishon Vijay Abraham I

Bounce buffer is used for transferring requests which is not maxpacket aligned. In the case of DFU the requests can be upto 4096 bytes.

While the actual fix for this should be using two chained TRBs to handle the transfer, this can be used as a temporary fix.

Did you manage to trigger this fault ? Was the size larger than 512 ?

Quoted 3 lines

Quoted 1 line

yeah.. transferring any kernel image resulted in a size larger than 512.

but it's also larger than 4KiB :-)

Yeah. But the DFU specifies the maximum transfer size in wTransferSize (DFU function descriptor) to the host which is 4096 bytes (DFU_USB_BUFSIZ).

So the max size will be only 4KB.

Ported DWC3 driver from linux kernel v3.16 to uboot and enabled DFU in DRA7xx. Tested only with DFU ram.

While I kept the dwc3 driver pretty much the same from linux kernel, I have created a single driver for both USB2 and USB3 PHY programming. I have also adapted udc-core from linux kernel so that we can cleanly link the gadet driver with the controller driver.

Ported DWC3 driver from linux kernel v3.16 to uboot and enabled DFU in DRA7xx. Tested only with DFU ram.

While I kept the dwc3 driver pretty much the same from linux kernel, I have created a single driver for both USB2 and USB3 PHY programming.

I have also adapted udc-core from linux kernel so that we can cleanly link the gadet driver with the controller driver.

This series was created on top of
commit 61e76f53708cf082ef9061a140b57df3513b8ba1
Merge: 76b2102 3d83e67
Author: Tom Rini <[email protected]>
Date: Tue Jun 10 20:37:00 2014 -0400

Merge branch 'master' of git://git.denx.de/u-boot-usb

Let me know of any feedback and suggestions.

Known Issues:
DWC3 is not enumerating consistently.

Kishon Vijay Abraham I (13):
include: linux: preparation for porting dwc3 from linux kernel
usb: gadget: udc-core: Add minimal udc-core from linux kernel
ARM: DRA7: Enable clocks for USB OTGSS and USB PHY
usb: dwc3: Add dwc3 driver
usb: dwc3-omap: Add dwc3 glue driver for OMAP
usb: dwc3: TI PHY: PHY driver for dwc3 in TI platforms
usb: gadget: g_dnl: Explicitly set the max packet size in descriptor
common: cmd_dfu: invoke board_usb_cleanup() for cleaning up
common: cmd_dfu: add an API that takes controller index for handling
interrupts
board: ti: DRA7: added USB initializtion code
commom: usb: implement "__weak" functions to make compiler happy
include: configs: Enable DWC3 and DFU in DRA7xx
dwc3: core: Change the bounce buffer size to 4096

 Makefile                               |    1 +
 arch/arm/cpu/armv7/omap5/hw_data.c     |   14 +
 arch/arm/cpu/armv7/omap5/prcm-regs.c   |    6 +-
 arch/arm/include/asm/arch-omap5/omap.h |   12 +
 arch/arm/include/asm/omap_common.h     |    4 +-
 board/ti/dra7xx/evm.c                  |  106 ++
 common/cmd_dfu.c                       |    2 +
 common/usb.c                           |   18 +
 drivers/usb/dwc3/Makefile              |   10 +
 drivers/usb/dwc3/core.c                |  640 +++++++
 drivers/usb/dwc3/core.h                |  961 +++++++++++
 drivers/usb/dwc3/dwc3-omap.c           |  447 +++++
 drivers/usb/dwc3/ep0.c                 | 1045 ++++++++++++
 drivers/usb/dwc3/gadget.c              | 2841
++++++++++++++++++++++++++++++++
drivers/usb/dwc3/gadget.h              |  163 ++
drivers/usb/dwc3/io.h                  |   52 +
drivers/usb/dwc3/linux-compat.h        |  132 ++
drivers/usb/dwc3/ti_usb_phy.c          |  269 +++
drivers/usb/gadget/Makefile            |    1 +
drivers/usb/gadget/composite.c         |    3 +-
drivers/usb/gadget/g_dnl.c             |    1 +
drivers/usb/gadget/udc-core.c          |  229 +++
include/configs/dra7xx_evm.h           |   59 +
include/configs/ti_omap5_common.h      |    1 +
include/dwc3-omap-uboot.h              |   32 +
include/dwc3-uboot.h                   |   26 +
include/linux/compat.h                 |   12 +-
include/linux/usb/composite.h          |   12 +
include/linux/usb/dwc3-omap.h          |   19 +
include/linux/usb/gadget.h             |   75 +-
include/linux/usb/otg.h                |   20 +
include/ti-usb-phy-uboot.h             |   22 +
include/usb.h                          |    7 +
include/usb/lin_gadget_compat.h        |    8 +- 34 files changed,
7236 insertions(+), 14 deletions(-) create mode 100644
drivers/usb/dwc3/Makefile create mode 100644 drivers/usb/dwc3/core.c
 create mode 100644 drivers/usb/dwc3/core.h
 create mode 100644 drivers/usb/dwc3/dwc3-omap.c
 create mode 100644 drivers/usb/dwc3/ep0.c
 create mode 100644 drivers/usb/dwc3/gadget.c
 create mode 100644 drivers/usb/dwc3/gadget.h
 create mode 100644 drivers/usb/dwc3/io.h
 create mode 100644 drivers/usb/dwc3/linux-compat.h
 create mode 100644 drivers/usb/dwc3/ti_usb_phy.c
 create mode 100644 drivers/usb/gadget/udc-core.c
 create mode 100644 include/dwc3-omap-uboot.h
 create mode 100644 include/dwc3-uboot.h
 create mode 100644 include/linux/usb/dwc3-omap.h
 create mode 100644 include/linux/usb/otg.h
 create mode 100644 include/ti-usb-phy-uboot.h