Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
PATCH 1/1 Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
As the functions have external linkage by default, the extern keyword is irrelevant here.
--- arch/arm64/include/asm/proc-fns.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/include/asm/proc-fns.h +6 -6
@@ -28,14 +28,14 @@struct mm_struct ;struct cpu_suspend_ctx ; -extern void cpu_cache_off (void ); -extern void cpu_do_idle (void ); -extern void cpu_do_switch_mm (unsigned long pgd_phys,struct mm_struct *mm); -extern void cpu_reset (unsigned long addr) __attribute__((noreturn)); +void cpu_cache_off (void ); +void cpu_do_idle (void ); +void cpu_do_switch_mm (unsigned long pgd_phys,struct mm_struct *mm); +void cpu_reset (unsigned long addr) __attribute__((noreturn));void cpu_soft_restart (phys_addr_t cpu_reset,unsigned long addr) __attribute__((noreturn)); -extern void cpu_do_suspend (struct cpu_suspend_ctx *ptr); -extern u64 cpu_do_resume (phys_addr_t ptr,u64 idmap_ttbr); +void cpu_do_suspend (struct cpu_suspend_ctx *ptr); +u64 cpu_do_resume (phys_addr_t ptr,u64 idmap_ttbr);#include <asm/memory.h>
Signature · 1 line
1.7.9.5
PATCH 1/1 Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
Hi Arun,
Quoted 2 lines · Arun Chandran
As the functions have external linkage by default, the extern keyword is irrelevant here.
extern is used to say that the storage of a variable is done somewhere else. It marks a statement as a declaration when there is ambiguity about if the statement is a definition or declaration. Since function prototypes are not definitions, extern doesn't have any effect on them. It is not really related to linkage or scope.
-Geoff
PATCH 1/1 Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
Quoted 10 lines · Geoff Levand
Quoted 2 lines · Arun Chandran
As the functions have external linkage by default, the extern keyword is irrelevant here.
extern is used to say that the storage of a variable is done somewhere else. It marks a statement as a declaration when there is ambiguity about if the statement is a definition or declaration. Since function prototypes are not definitions, extern doesn't have any effect on them. It is not really related to linkage or scope.
Regardless, this patch doesn't apply.
Will