Skip to contentSkip to conversation

ARM: shmobile: sh7372: Update DTS to include CPU frequency

PATCH In review Magnus Damm 2 participants 3 messages Aug 20, 2014

Subsystems (2)
Device tree bindings SuperH
lore
Share & tools
lore

Magnus Damm

author
#0 lore raw

PATCH 1/10 ARM: shmobile: sh7372: Update DTS to include CPU frequency

From: Magnus Damm <[email protected]>

Add CPU Frequency information to the sh7372 DTS file. This will allow us to use the shared C code on sh7372 and Mackerel which reads out the clock frequency from DT and calculates the delay settings from there.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/boot/dts/sh7372.dtsi |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/sh7372.dtsi +1 -0
@@ -21,6 +21,7 @@
 			compatible = "arm,cortex-a8";
 			device_type = "cpu";
 			reg = <0x0>;
+			clock-frequency = <800000000>;
 		};
 	};
#1 lore raw

Hi Magnus,

Quoted 14 lines · Magnus Damm

Add CPU Frequency information to the sh7372 DTS file. This will allow us to use the shared C code on sh7372 and Mackerel which reads out the clock frequency from DT and calculates the delay settings from there.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/boot/dts/sh7372.dtsi |    1 +
 1 file changed, 1 insertion(+)

arch/arm/boot/dts/sh7372.dtsi 2014-08-20 21:00:26.000000000 +0900 line 24

Quoted 4 lines
arch/arm/boot/dts/sh7372.dtsi 2014-08-20 21:00:26.000000000 +0900 renamed from arch/arm/boot/dts/sh7372.dtsi +1 -0
@@ -21,6 +21,7 @@
                        compatible = "arm,cortex-a8";
                        device_type = "cpu";
                        reg = <0x0>;
+                       clock-frequency = <800000000>;

Should this be overridden in sh7372-mackerel.dtsi?

While the sh7372 manual states 800 MHz, the Mackerel manual states 806 MHz.

arch/arm/boot/dts/sh7372.dtsi 2014-08-20 21:00:26.000000000 +0900 line 26

Quoted 2 lines
arch/arm/boot/dts/sh7372.dtsi 2014-08-20 21:00:26.000000000 +0900 renamed from arch/arm/boot/dts/sh7372.dtsi +0 -0
                };
        };

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#2 lore raw
In reply to Magnus Damm

Hi Geert,

Quoted 24 lines · Geert Uytterhoeven

Hi Magnus,

Quoted 14 lines · Magnus Damm

Add CPU Frequency information to the sh7372 DTS file. This will allow us to use the shared C code on sh7372 and Mackerel which reads out the clock frequency from DT and calculates the delay settings from there.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/boot/dts/sh7372.dtsi |    1 +
 1 file changed, 1 insertion(+)

arch/arm/boot/dts/sh7372.dtsi 2014-08-20 21:00:26.000000000 +0900 line 24

Quoted 4 lines
arch/arm/boot/dts/sh7372.dtsi 2014-08-20 21:00:26.000000000 +0900 renamed from arch/arm/boot/dts/sh7372.dtsi +1 -0
@@ -21,6 +21,7 @@
                        compatible = "arm,cortex-a8";
                        device_type = "cpu";
                        reg = <0x0>;
+                       clock-frequency = <800000000>;

Should this be overridden in sh7372-mackerel.dtsi?

Quoted 2 lines

While the sh7372 manual states 800 MHz, the Mackerel manual states 806 MHz.

I guess overriding makes sense for boards that operate out of spec... =/

For sh7372 this isn't really used by anything except the generic (broken) DT case, so Mackerel legacy case doesn't care at this point.

Looking forward to throw sh7372 support out of the window. =)

/ magnus