Skip to contentSkip to conversation

USB reset xhci_hcd for ELAN touchscreen

PATCH In review Johan Hovold 3 participants 8 messages Jul 14, 2014 – Sep 8, 2014 8 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20140707092442.GF29098@localhost

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20140709130733.GA10078@localhost

#6 lore raw

[ +CC: Jiri and linux-input ]

Quoted 18 lines · Johan Hovold
Quoted 10 lines · Greg Kroah-Hartman
Quoted 7 lines · Johan Hovold

I ended up getting the same laptop so now I'm facing the same problem with repeated disconnects (especially during resume, which is really annoying as it adds about a minute to resume time), even with a hard-coded check-high speed "quirk" and the multitouch driver loaded.

Did you manage to fix the disconnect issue? Are you seeing something similar at resume?

Quoted 6 lines

No, it all seems to work for me. Here's my horrible "hack" I'm running with on 3.16-rc.

I have seen some issues at times when the touchscreen stops working on resume, but it just seems "dead". An unload/load of the xhci-hcd module always fixes that :)

Quoted 8 lines

Ok. I'm effectively using the same hack as you, but I'm seeing these repeated disconnects during resume for about a minute still. Everything compiled in, so no modules (or fancy hibernate scripts) though.

Quoted 2 lines

I'll work on making this a "real" patch this week, when I dig out from my pending patch queue...

Ok, I'll wait for that, and will try to find time to debug this later.

The timeout I experienced during resume was due to the wifi firmware not being compiled in, but during that minute the touchscreen device kept disconnecting every other second.

I get one such disconnect before X is started during normal boot as well. It appears that something has to open the input device at least once or the device will keep disconnecting itself (e.g. not booting into X also triggers the repeated disconnects).

A simple

	cat /dev/input/by-path/pci-0000:00:14.0-usb-0:7:1.0-event

is enough to stop the device from disconnecting. But unless the device is kept open (and the interrupt-in urb submitted) any input event (i.e. touching the screen) causes the device to start disconnecting repeatedly again.

Adding something like the below (on top of the check-highspeed quirk) fixes the repeated disconnect when the device is not open. (It cannot prevent the disconnects during a lengthy resume though as reset_resume will not have run yet.)

Is there any better way to fix this?

Thanks,
Johan

Quoted 1 line

From 8101c0dfd42a232f1d2872de4f412d8d61d5646f Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 14 Jul 2014 18:43:31 +0200
Subject: [PATCH] HID: usbhid: add HID_QUIRK_IN

Add quirk to submit the interrupt-in urb already at start() rather than at open().

This is needed for devices that disconnects from the bus unless the interrupt endpoint has been polled at least once or when not responding to input events.

---
 drivers/hid/usbhid/hid-core.c | 26 +++++++++++++++++++++++---
 include/linux/hid.h           |  1 +
 2 files changed, 24 insertions(+), 3 deletions(-)
drivers/hid/usbhid/hid-core.c +23 -3
index 7b88f4c..4b5d986 100644
@@ -82,7 +82,7 @@ static int hid_start_in(struct hid_device *hid)
 	struct usbhid_device *usbhid = hid->driver_data;
 
 	spin_lock_irqsave(&usbhid->lock, flags);
-	if (hid->open > 0 &&
+	if ((hid->open > 0 || hid->quirks & HID_QUIRK_IN) &&
 			!test_bit(HID_DISCONNECTED, &usbhid->iofl) &&
 			!test_bit(HID_SUSPENDED, &usbhid->iofl) &&
 			!test_and_set_bit(HID_IN_RUNNING, &usbhid->iofl)) {
@@ -292,6 +292,8 @@ static void hid_irq_in(struct urb *urb)
 	case 0:			/* success */
 		usbhid_mark_busy(usbhid);
 		usbhid->retry_delay = 0;
+		if ((hid->quirks & HID_QUIRK_IN) && !hid->open)
+			break;
 		hid_input_report(urb->context, HID_INPUT_REPORT,
 				 urb->transfer_buffer,
 				 urb->actual_length, 1);
@@ -734,8 +736,10 @@ void usbhid_close(struct hid_device *hid)
 	if (!--hid->open) {
 		spin_unlock_irq(&usbhid->lock);
 		hid_cancel_delayed_stuff(usbhid);
-		usb_kill_urb(usbhid->urbin);
-		usbhid->intf->needs_remote_wakeup = 0;
+		if (!(hid->quirks & HID_QUIRK_IN)) {
+			usb_kill_urb(usbhid->urbin);
+			usbhid->intf->needs_remote_wakeup = 0;
+		}
 	} else {
 		spin_unlock_irq(&usbhid->lock);
 	}
@@ -1133,6 +1137,20 @@ static int usbhid_start(struct hid_device *hid)
 
 	set_bit(HID_STARTED, &usbhid->iofl);
 
+	hid->quirks |= HID_QUIRK_IN;	/* FIXME */
+	if (hid->quirks & HID_QUIRK_IN) {
+		ret = usb_autopm_get_interface(usbhid->intf);
+		if (ret)
+			goto fail;
+		usbhid->intf->needs_remote_wakeup = 1;
+		ret = hid_start_in(hid);
+		if (ret) {
+			dev_err(&hid->dev,
+				"failed to start in urb: %d\n", ret);
+		}
+		usb_autopm_put_interface(usbhid->intf);
+	}
+
 	/* Some keyboards don't work until their LEDs have been set.
 	 * Since BIOSes do set the LEDs, it must be safe for any device
 	 * that supports the keyboard boot protocol.
@@ -1165,6 +1183,8 @@ static void usbhid_stop(struct hid_device *hid)
 	if (WARN_ON(!usbhid))
 		return;
 
+	usbhid->intf->needs_remote_wakeup = 0;
+
 	clear_bit(HID_STARTED, &usbhid->iofl);
 	spin_lock_irq(&usbhid->lock);	/* Sync with error and led handlers */
 	set_bit(HID_DISCONNECTED, &usbhid->iofl);
include/linux/hid.h +1 -0
index 77632cf..13f81ae 100644
@@ -286,6 +286,7 @@ struct hid_item {
 #define HID_QUIRK_HIDINPUT_FORCE		0x00000080
 #define HID_QUIRK_NO_EMPTY_INPUT		0x00000100
 #define HID_QUIRK_NO_INIT_INPUT_REPORTS		0x00000200
+#define HID_QUIRK_IN				0x00000400
 #define HID_QUIRK_SKIP_OUTPUT_REPORTS		0x00010000
 #define HID_QUIRK_SKIP_OUTPUT_REPORT_ID		0x00020000
 #define HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP	0x00040000
Signature · 1 line
1.8.5.5
#7 lore raw
Quoted 11 lines · Johan Hovold

From 8101c0dfd42a232f1d2872de4f412d8d61d5646f Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Mon, 14 Jul 2014 18:43:31 +0200
Subject: [PATCH] HID: usbhid: add HID_QUIRK_IN

Add quirk to submit the interrupt-in urb already at start() rather than at open().

This is needed for devices that disconnects from the bus unless the interrupt endpoint has been polled at least once or when not responding to input events.

It's not really super-nice, but if no other way around it has been found to be possible in USB core, I am willing to take this.

Quoted 41 lines
---
 drivers/hid/usbhid/hid-core.c | 26 +++++++++++++++++++++++---
 include/linux/hid.h           |  1 +
 2 files changed, 24 insertions(+), 3 deletions(-)
drivers/hid/usbhid/hid-core.c +7 -3
index 7b88f4c..4b5d986 100644
@@ -82,7 +82,7 @@ static int hid_start_in(struct hid_device *hid)
 	struct usbhid_device *usbhid = hid->driver_data;
 
 	spin_lock_irqsave(&usbhid->lock, flags);
-	if (hid->open > 0 &&
+	if ((hid->open > 0 || hid->quirks & HID_QUIRK_IN) &&
 			!test_bit(HID_DISCONNECTED, &usbhid->iofl) &&
 			!test_bit(HID_SUSPENDED, &usbhid->iofl) &&
 			!test_and_set_bit(HID_IN_RUNNING, &usbhid->iofl)) {
@@ -292,6 +292,8 @@ static void hid_irq_in(struct urb *urb)
 	case 0:			/* success */
 		usbhid_mark_busy(usbhid);
 		usbhid->retry_delay = 0;
+		if ((hid->quirks & HID_QUIRK_IN) && !hid->open)
+			break;
 		hid_input_report(urb->context, HID_INPUT_REPORT,
 				 urb->transfer_buffer,
 				 urb->actual_length, 1);
@@ -734,8 +736,10 @@ void usbhid_close(struct hid_device *hid)
 	if (!--hid->open) {
 		spin_unlock_irq(&usbhid->lock);
 		hid_cancel_delayed_stuff(usbhid);
-		usb_kill_urb(usbhid->urbin);
-		usbhid->intf->needs_remote_wakeup = 0;
+		if (!(hid->quirks & HID_QUIRK_IN)) {
+			usb_kill_urb(usbhid->urbin);
+			usbhid->intf->needs_remote_wakeup = 0;
+		}
 	} else {
 		spin_unlock_irq(&usbhid->lock);
 	}

drivers/hid/usbhid/hid-core.c static int usbhid_start(struct hid_device *hid) · line 1140

Quoted 4 lines
drivers/hid/usbhid/hid-core.c +1 -0
@@ -1133,6 +1137,20 @@ static int usbhid_start(struct hid_device *hid)
 
 	set_bit(HID_STARTED, &usbhid->iofl);
 
+	hid->quirks |= HID_QUIRK_IN;	/* FIXME */

This of course needs to be set on per-device basis :)

Quoted 30 lines
drivers/hid/usbhid/hid-core.c +15 -0
+	if (hid->quirks & HID_QUIRK_IN) {
+		ret = usb_autopm_get_interface(usbhid->intf);
+		if (ret)
+			goto fail;
+		usbhid->intf->needs_remote_wakeup = 1;
+		ret = hid_start_in(hid);
+		if (ret) {
+			dev_err(&hid->dev,
+				"failed to start in urb: %d\n", ret);
+		}
+		usb_autopm_put_interface(usbhid->intf);
+	}
+
 	/* Some keyboards don't work until their LEDs have been set.
 	 * Since BIOSes do set the LEDs, it must be safe for any device
 	 * that supports the keyboard boot protocol.
@@ -1165,6 +1183,8 @@ static void usbhid_stop(struct hid_device *hid)
 	if (WARN_ON(!usbhid))
 		return;
 
+	usbhid->intf->needs_remote_wakeup = 0;
+
 	clear_bit(HID_STARTED, &usbhid->iofl);
 	spin_lock_irq(&usbhid->lock);	/* Sync with error and led handlers */
 	set_bit(HID_DISCONNECTED, &usbhid->iofl);
include/linux/hid.h +0 -0
index 77632cf..13f81ae 100644

include/linux/hid.h struct hid_item { · line 289

Quoted 4 lines
include/linux/hid.h +1 -0
@@ -286,6 +286,7 @@ struct hid_item {
 #define HID_QUIRK_HIDINPUT_FORCE		0x00000080
 #define HID_QUIRK_NO_EMPTY_INPUT		0x00000100
 #define HID_QUIRK_NO_INIT_INPUT_REPORTS		0x00000200
+#define HID_QUIRK_IN				0x00000400

0x00000400 has been removed before dynamic quirks started to be possible, so there is no potential clash, that's fine.

I'd just propose some more descriptive name for the quirk ... how about something like HID_QUIRK_EARLY_INTERRUPT?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#8 lore raw
Quoted 10 lines · Jiri Kosina
Quoted 8 lines · Johan Hovold

From 8101c0dfd42a232f1d2872de4f412d8d61d5646f Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Mon, 14 Jul 2014 18:43:31 +0200
Subject: [PATCH] HID: usbhid: add HID_QUIRK_IN

Add quirk to submit the interrupt-in urb already at start() rather than at open().

Quoted 6 lines
Quoted 3 lines

This is needed for devices that disconnects from the bus unless the interrupt endpoint has been polled at least once or when not responding to input events.

It's not really super-nice, but if no other way around it has been found to be possible in USB core, I am willing to take this.

Agreed, it's not that nice, but I'm not aware of any other way to prevent the device firmware from disconnecting.

Autosuspend still seems to work, so it would not cause much overhead for people not actually using the touchscreen (as long as autosuspend is enabled) either.

Quoted 42 lines
Quoted 42 lines
---
 drivers/hid/usbhid/hid-core.c | 26 +++++++++++++++++++++++---
 include/linux/hid.h           |  1 +
 2 files changed, 24 insertions(+), 3 deletions(-)
drivers/hid/usbhid/hid-core.c +7 -3
index 7b88f4c..4b5d986 100644
@@ -82,7 +82,7 @@ static int hid_start_in(struct hid_device *hid)
 	struct usbhid_device *usbhid = hid->driver_data;
 
 	spin_lock_irqsave(&usbhid->lock, flags);
-	if (hid->open > 0 &&
+	if ((hid->open > 0 || hid->quirks & HID_QUIRK_IN) &&
 			!test_bit(HID_DISCONNECTED, &usbhid->iofl) &&
 			!test_bit(HID_SUSPENDED, &usbhid->iofl) &&
 			!test_and_set_bit(HID_IN_RUNNING, &usbhid->iofl)) {
@@ -292,6 +292,8 @@ static void hid_irq_in(struct urb *urb)
 	case 0:			/* success */
 		usbhid_mark_busy(usbhid);
 		usbhid->retry_delay = 0;
+		if ((hid->quirks & HID_QUIRK_IN) && !hid->open)
+			break;
 		hid_input_report(urb->context, HID_INPUT_REPORT,
 				 urb->transfer_buffer,
 				 urb->actual_length, 1);
@@ -734,8 +736,10 @@ void usbhid_close(struct hid_device *hid)
 	if (!--hid->open) {
 		spin_unlock_irq(&usbhid->lock);
 		hid_cancel_delayed_stuff(usbhid);
-		usb_kill_urb(usbhid->urbin);
-		usbhid->intf->needs_remote_wakeup = 0;
+		if (!(hid->quirks & HID_QUIRK_IN)) {
+			usb_kill_urb(usbhid->urbin);
+			usbhid->intf->needs_remote_wakeup = 0;
+		}
 	} else {
 		spin_unlock_irq(&usbhid->lock);
 	}
@@ -1133,6 +1137,20 @@ static int usbhid_start(struct hid_device *hid)
 
Quoted 5 lines

drivers/hid/usbhid/hid-core.c static int usbhid_start(struct hid_device *hid) · line 1140

Quoted 3 lines
drivers/hid/usbhid/hid-core.c +1 -0
 	set_bit(HID_STARTED, &usbhid->iofl);
 
+	hid->quirks |= HID_QUIRK_IN;	/* FIXME */

This of course needs to be set on per-device basis :)

Of course.

Quoted 38 lines
Quoted 30 lines
drivers/hid/usbhid/hid-core.c +15 -0
+	if (hid->quirks & HID_QUIRK_IN) {
+		ret = usb_autopm_get_interface(usbhid->intf);
+		if (ret)
+			goto fail;
+		usbhid->intf->needs_remote_wakeup = 1;
+		ret = hid_start_in(hid);
+		if (ret) {
+			dev_err(&hid->dev,
+				"failed to start in urb: %d\n", ret);
+		}
+		usb_autopm_put_interface(usbhid->intf);
+	}
+
 	/* Some keyboards don't work until their LEDs have been set.
 	 * Since BIOSes do set the LEDs, it must be safe for any device
 	 * that supports the keyboard boot protocol.
@@ -1165,6 +1183,8 @@ static void usbhid_stop(struct hid_device *hid)
 	if (WARN_ON(!usbhid))
 		return;
 
+	usbhid->intf->needs_remote_wakeup = 0;
+
 	clear_bit(HID_STARTED, &usbhid->iofl);
 	spin_lock_irq(&usbhid->lock);	/* Sync with error and led handlers */
 	set_bit(HID_DISCONNECTED, &usbhid->iofl);
include/linux/hid.h +0 -0
index 77632cf..13f81ae 100644

include/linux/hid.h struct hid_item { · line 289

Quoted 4 lines
include/linux/hid.h +1 -0
@@ -286,6 +286,7 @@ struct hid_item {
 #define HID_QUIRK_HIDINPUT_FORCE		0x00000080
 #define HID_QUIRK_NO_EMPTY_INPUT		0x00000100
 #define HID_QUIRK_NO_INIT_INPUT_REPORTS		0x00000200
+#define HID_QUIRK_IN				0x00000400

0x00000400 has been removed before dynamic quirks started to be possible, so there is no potential clash, that's fine.

Quoted 2 lines

I'd just propose some more descriptive name for the quirk ... how about something like HID_QUIRK_EARLY_INTERRUPT?

Yeah, IN was just a working name. How about HID_QUIRK_ALWAYS_POLL or similar as it is not just about disconnect before the device is opened, but also if there's an event after the device has been closed (e.g. stopping X)?

Thanks,
Johan

#9 lore raw
Quoted 9 lines · Johan Hovold
Quoted 2 lines

It's not really super-nice, but if no other way around it has been found to be possible in USB core, I am willing to take this.

Agreed, it's not that nice, but I'm not aware of any other way to prevent the device firmware from disconnecting.

Autosuspend still seems to work, so it would not cause much overhead for people not actually using the touchscreen (as long as autosuspend is enabled) either.

Okay, good. Will be waiting for your polished patch for this.

[ ... snip ... ]

Quoted 13 lines
Quoted 13 lines

include/linux/hid.h struct hid_item { · line 289

Quoted 9 lines
include/linux/hid.h +1 -0
index 77632cf..13f81ae 100644
@@ -286,6 +286,7 @@ struct hid_item {
 #define HID_QUIRK_HIDINPUT_FORCE		0x00000080
 #define HID_QUIRK_NO_EMPTY_INPUT		0x00000100
 #define HID_QUIRK_NO_INIT_INPUT_REPORTS		0x00000200
+#define HID_QUIRK_IN				0x00000400

0x00000400 has been removed before dynamic quirks started to be possible, so there is no potential clash, that's fine.

Quoted 7 lines
Quoted 2 lines

I'd just propose some more descriptive name for the quirk ... how about something like HID_QUIRK_EARLY_INTERRUPT?

Yeah, IN was just a working name. How about HID_QUIRK_ALWAYS_POLL or similar as it is not just about disconnect before the device is opened, but also if there's an event after the device has been closed (e.g. stopping X)?

HID_QUIRK_ALWAYS_POLL sounds good.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs

A message that is not in the archive (sent off-list or not yet received): alpine.LNX.2.00.1408211337050.23162-ztGlSCb7Y1iN3ZZ/[email protected]

#11 lore raw

cover HID: usbhid: fix Elan touchscreen disconnects

Here's the always-poll quirk that is needed to prevent the Elan touchscreen from disconnecting itself from the bus.

These patches are against v3.16.1, but applies fine to hid-next.

Note that this series is not dependent on the device-qualifier quirk [1], which is needed to get the same device to enumerate reliably, so these two quirks could in through the USB and HID tree, respectively.

Johan

[1] http://marc.info/?l=linux-usb&m=140898201107571&w=2

Johan Hovold (2):
HID: usbhid: add always-poll quirk
HID: usbhid: enable always-poll quirk for Elan Touchscreen

 drivers/hid/hid-ids.h           |  3 +++
 drivers/hid/usbhid/hid-core.c   | 26 +++++++++++++++++++++++---
 drivers/hid/usbhid/hid-quirks.c |  1 +
 include/linux/hid.h             |  1 +
 4 files changed, 28 insertions(+), 3 deletions(-)
Signature · 6 lines
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1409933328-7190-1-git-send-email-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#13 lore raw

PATCH 1/2 HID: usbhid: add always-poll quirk

Add quirk to make sure that a device is always polled for input events even if it hasn't been opened.

This is needed for devices that disconnects from the bus unless the interrupt endpoint has been polled at least once or when not responding to an input event (e.g. after having shut down X).

---
 drivers/hid/usbhid/hid-core.c | 26 +++++++++++++++++++++++---
 include/linux/hid.h           |  1 +
 2 files changed, 24 insertions(+), 3 deletions(-)
drivers/hid/usbhid/hid-core.c +23 -3
index 7b88f4c..d8b6976 100644
@@ -82,7 +82,7 @@ static int hid_start_in(struct hid_device *hid)
 	struct usbhid_device *usbhid = hid->driver_data;
 
 	spin_lock_irqsave(&usbhid->lock, flags);
-	if (hid->open > 0 &&
+	if ((hid->open > 0 || hid->quirks & HID_QUIRK_ALWAYS_POLL) &&
 			!test_bit(HID_DISCONNECTED, &usbhid->iofl) &&
 			!test_bit(HID_SUSPENDED, &usbhid->iofl) &&
 			!test_and_set_bit(HID_IN_RUNNING, &usbhid->iofl)) {
@@ -292,6 +292,8 @@ static void hid_irq_in(struct urb *urb)
 	case 0:			/* success */
 		usbhid_mark_busy(usbhid);
 		usbhid->retry_delay = 0;
+		if ((hid->quirks & HID_QUIRK_ALWAYS_POLL) && !hid->open)
+			break;
 		hid_input_report(urb->context, HID_INPUT_REPORT,
 				 urb->transfer_buffer,
 				 urb->actual_length, 1);
@@ -734,8 +736,10 @@ void usbhid_close(struct hid_device *hid)
 	if (!--hid->open) {
 		spin_unlock_irq(&usbhid->lock);
 		hid_cancel_delayed_stuff(usbhid);
-		usb_kill_urb(usbhid->urbin);
-		usbhid->intf->needs_remote_wakeup = 0;
+		if (!(hid->quirks & HID_QUIRK_ALWAYS_POLL)) {
+			usb_kill_urb(usbhid->urbin);
+			usbhid->intf->needs_remote_wakeup = 0;
+		}
 	} else {
 		spin_unlock_irq(&usbhid->lock);
 	}
@@ -1133,6 +1137,19 @@ static int usbhid_start(struct hid_device *hid)
 
 	set_bit(HID_STARTED, &usbhid->iofl);
 
+	if (hid->quirks & HID_QUIRK_ALWAYS_POLL) {
+		ret = usb_autopm_get_interface(usbhid->intf);
+		if (ret)
+			goto fail;
+		usbhid->intf->needs_remote_wakeup = 1;
+		ret = hid_start_in(hid);
+		if (ret) {
+			dev_err(&hid->dev,
+				"failed to start in urb: %d\n", ret);
+		}
+		usb_autopm_put_interface(usbhid->intf);
+	}
+
 	/* Some keyboards don't work until their LEDs have been set.
 	 * Since BIOSes do set the LEDs, it must be safe for any device
 	 * that supports the keyboard boot protocol.
@@ -1165,6 +1182,9 @@ static void usbhid_stop(struct hid_device *hid)
 	if (WARN_ON(!usbhid))
 		return;
 
+	if (hid->quirks & HID_QUIRK_ALWAYS_POLL)
+		usbhid->intf->needs_remote_wakeup = 0;
+
 	clear_bit(HID_STARTED, &usbhid->iofl);
 	spin_lock_irq(&usbhid->lock);	/* Sync with error and led handlers */
 	set_bit(HID_DISCONNECTED, &usbhid->iofl);
include/linux/hid.h +1 -0
index 77632cf..05eb710 100644
@@ -286,6 +286,7 @@ struct hid_item {
 #define HID_QUIRK_HIDINPUT_FORCE		0x00000080
 #define HID_QUIRK_NO_EMPTY_INPUT		0x00000100
 #define HID_QUIRK_NO_INIT_INPUT_REPORTS		0x00000200
+#define HID_QUIRK_ALWAYS_POLL			0x00000400
 #define HID_QUIRK_SKIP_OUTPUT_REPORTS		0x00010000
 #define HID_QUIRK_SKIP_OUTPUT_REPORT_ID		0x00020000
 #define HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP	0x00040000
Signature · 6 lines
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#14 lore raw

PATCH 2/2 HID: usbhid: enable always-poll quirk for Elan Touchscreen

In reply to a message not in the archive

Enable the always-poll quirk for Elan Touchscreens found on some recent Samsung laptops.

Without this quirk the device keeps disconnecting from the bus (and is re-enumerated) unless opened (and kept open, should an input event occur).

Note that while the device can be run-time suspended, the autosuspend timeout must be high enough to allow the device to be polled at least once before being suspended. Specifically, using autosuspend_delay_ms=0 will still cause the device to disconnect on input events.

---
 drivers/hid/hid-ids.h           | 3 +++
 drivers/hid/usbhid/hid-quirks.c | 1 +
 2 files changed, 4 insertions(+)
drivers/hid/hid-ids.h +3 -0
index 48b66bb..79b966d 100644
@@ -296,6 +296,9 @@
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_73F7	0x73f7
 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001	0xa001
 
+#define USB_VENDOR_ID_ELAN		0x04f3
+#define USB_DEVICE_ID_ELAN_TOUCHSCREEN	0x0089
+
 #define USB_VENDOR_ID_ELECOM		0x056e
 #define USB_DEVICE_ID_ELECOM_BM084	0x0061
 
drivers/hid/usbhid/hid-quirks.c +1 -0
index 31e6727..72da083 100644
@@ -70,6 +70,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_3AXIS_5BUTTON_STICK, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_CH, USB_DEVICE_ID_CH_AXIS_295, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN, HID_QUIRK_ALWAYS_POLL },
 	{ USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET },
Signature · 6 lines
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#15 lore raw

Re: [PATCH 0/2] HID: usbhid: fix Elan touchscreen disconnects

In reply to Johan Hovold
Quoted 8 lines · Johan Hovold

Here's the always-poll quirk that is needed to prevent the Elan touchscreen from disconnecting itself from the bus.

These patches are against v3.16.1, but applies fine to hid-next.

Note that this series is not dependent on the device-qualifier quirk [1], which is needed to get the same device to enumerate reliably, so these two quirks could in through the USB and HID tree, respectively.

Thanks for respinning this patchset. I have queued it for 3.18.

Oliver, could you please send me your patch for 0x093a / 0x2510 so that I could apply it on top of this?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs