bandwidthd: Version bump to fix autobuilder errors

Thanks to Romain Naour, we've found that certain tests in configure fail if their dependencies aren't tested for beforehand.

zlib has been added as a dependency just to make sure it gets built.

In upstream the changes to fix this issue are:
- Test for libusb-1.0 purely to ensure that variables are set (it's only needed if libpcap was built with it).
- Test for libz and continue/fail because it's actually needed by libpng and it's probably more meaningful to fail on libz rather than libpng if libz is the issue.

Also, the X.Org tests have been removed from the configure script and therefore we don't need --without-x to be defined anymore.

Additional upstream changes:
- Handle the postgres/sqlite flags better (should not effect BR).
- Other general configure.ac cleanups.

Fixes:
autobuild.buildroot.net/results/37a/37a94e0f2d3faa0aec9c488e987cfff706fc9f3b/build-end.log

Signed-off-by Nathaniel Roach <[email protected]>

Acked-by Romain Naour <[email protected]>

---
Changes v1 to v2
- Fixed spelling of Romain's name
- Added link to the build failure

Changes v2 to v3
- Added back the SOff and Ack lines

Changes v3 to v4
- Removed the commend on Config.in regarding zlib
- Corrected a libpng instance in commit message to zlib

---
 package/bandwidthd/Config.in     | 1 +
 package/bandwidthd/bandwidthd.mk | 6 ++----
 2 files changed, 3 insertions(+), 4 deletions(-)

package/bandwidthd/Config.in +0 -0

index c1f0ee1..4da685c 100644

package/bandwidthd/Config.in +0 -0

 	select BR2_PACKAGE_LIBPNG
 	select BR2_PACKAGE_LIBPCAP
 	select BR2_PACKAGE_GD

package/bandwidthd/bandwidthd.mk +0 -0

index 3e11d6a..59b6143 100644
@@ -4,19 +4,17 @@
 #
 ################################################################################
 

package/bandwidthd/bandwidthd.mk +0 -2

 BANDWIDTHD_AUTORECONF = YES
 
-BANDWIDTHD_CONF_OPT += --without-x
-
 ifeq ($(BR2_PACKAGE_BANDWIDTHD_POSTGRESQL),y)
 BANDWIDTHD_DEPENDENCIES += postgresql
 BANDWIDTHD_CONF_OPT += --with-postgresql-logging=true

Hi Nathaniel,

package/bandwidthd/Config.in line 4

Quoted 5 lines · Nathaniel Roach

Thanks to Romain Naour, we've found that certain tests in configure fail if their dependencies aren't tested for beforehand.

package/bandwidthd/Config.in +1 -0

 	depends on BR2_USE_MMU # fork()
+	select BR2_PACKAGE_ZLIB

Is bandwidthd using libz directly? If not, libpng already selects BR2_PACKAGE_ZLIB so this may not actually be needed?

package/bandwidthd/bandwidthd.mk line 14

Quoted 3 lines

package/bandwidthd/bandwidthd.mk +1 -1

-BANDWIDTHD_DEPENDENCIES = gd libpng libpcap
+BANDWIDTHD_DEPENDENCIES = gd libpng libpcap zlib

Same here.

baruch

Quoted 1 line

package/bandwidthd/bandwidthd.mk line 20

Quoted 7 lines

BANDWIDTHD_AUTORECONF = YES

package/bandwidthd/bandwidthd.mk +0 -2

-BANDWIDTHD_CONF_OPT += --without-x
-
 ifeq ($(BR2_PACKAGE_BANDWIDTHD_POSTGRESQL),y)
 BANDWIDTHD_DEPENDENCIES += postgresql
 BANDWIDTHD_CONF_OPT += --with-postgresql-logging=true

Quoted 9 lines · Baruch Siach

package/bandwidthd/Config.in line 4

Quoted 5 lines · Nathaniel Roach

Thanks to Romain Naour, we've found that certain tests in configure fail if their dependencies aren't tested for beforehand.

package/bandwidthd/Config.in +1 -0

 	depends on BR2_USE_MMU # fork()
+	select BR2_PACKAGE_ZLIB

Is bandwidthd using libz directly? If not, libpng already selects BR2_PACKAGE_ZLIB so this may not actually be needed?

You are correct, it's only through libpng that zlib is used. I put it in there as a safeguard because bandwidthd's configure script does test for it's existence, as the libpng tests can fail without first testing for zlib.

The above issue should be covered by libpng anyway. I don't see any harm in it being there, but if you think it should be removed I'll undo the changes.