br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Subsystems (3)
PATCH 1/1 br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
--- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_multicast.c +1 -1
@@ -1822,7 +1822,7 @@ static void br_multicast_query_expired(struct net_bridge *br,if (query->startup_sent < br->multicast_startup_query_count) query->startup_sent++; -rcu_assign_pointer (querier,NULL ); +RCU_INIT_POINTER (querier,NULL );br_multicast_send_query (br,NULL , query);spin_unlock (&br->multicast_lock); }
Signature · 1 line
1.9.1
From: Andreea-Cristina Bernat <[email protected]>
Date: Fri, 22 Aug 2014 16:06:09 +0300
Quoted 5 lines
The use of "
rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use ofRCU_INIT_POINTER()is NULLing out the pointer"
it is better to use it instead ofrcu_assign_pointer()because it has a smaller overhead.
...
Quoted 1 line
Signed-off-by Andreea-Cristina Bernat <[email protected]>
Applied.