Skip to contentSkip to conversation

ARM: OMAP2+: omap_device: remove warning that clk alias already exists

PATCH New Markus Pargmann 2 participants 2 messages Aug 4, 2014 – Aug 22, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Markus Pargmann

author
#0 lore raw

PATCH 1/1 ARM: OMAP2+: omap_device: remove warning that clk alias already exists

When an alias for a clock already exists the warning is printed. For every module with a main_clk defined, a clk alias for fck is added. There are some components that have the same main_clk defined, so this is a really normal situation.

For example the am33xx edma device has 4 components using the same main clock. So there are three warnings in the boot log for this already existing clock alias:
platform 49000000.edma: alias fck already exists platform 49000000.edma: alias fck already exists platform 49000000.edma: alias fck already exists

As this is only interesting for developers, this patch changes the message to a debug message.

Signed-off-by Markus Pargmann <[email protected]>
---
 arch/arm/mach-omap2/omap_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/omap_device.c +1 -1
index 01ef59def44b..d22c30d3ccfa 100644
@@ -56,7 +56,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
 
 	r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
 	if (!IS_ERR(r)) {
-		dev_warn(&od->pdev->dev,
+		dev_dbg(&od->pdev->dev,
 			 "alias %s already exists\n", clk_alias);
 		clk_put(r);
 		return;
Signature · 1 line
2.0.1
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP2+: omap_device: remove warning that clk alias already exists

Quoted 25 lines · Markus Pargmann

When an alias for a clock already exists the warning is printed. For every module with a main_clk defined, a clk alias for fck is added. There are some components that have the same main_clk defined, so this is a really normal situation.

For example the am33xx edma device has 4 components using the same main clock. So there are three warnings in the boot log for this already existing clock alias:
platform 49000000.edma: alias fck already exists platform 49000000.edma: alias fck already exists platform 49000000.edma: alias fck already exists

As this is only interesting for developers, this patch changes the message to a debug message.

Signed-off-by Markus Pargmann <[email protected]>
---
 arch/arm/mach-omap2/omap_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/omap_device.c +0 -0
index 01ef59def44b..d22c30d3ccfa 100644

arch/arm/mach-omap2/omap_device.c static void _add_clkdev(struct omap_device *od, const char *clk_alias, · line 62

Quoted 8 lines
arch/arm/mach-omap2/omap_device.c +1 -1
@@ -56,7 +56,7 @@ static void _add_clkdev(struct omap_device *od, const char *clk_alias,
 
 	r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
 	if (!IS_ERR(r)) {
-		dev_warn(&od->pdev->dev,
+		dev_dbg(&od->pdev->dev,
 			 "alias %s already exists\n", clk_alias);
 		clk_put(r);
 		return;

Thanks applying into omap-for-v3.17/fixes.

Tony