Skip to contentSkip to conversation

ARM: dts: imx28-evk: Fix display duplicate name warning

PATCH New Fabio Estevam 2 participants 4 messages Aug 22, 2014 – Aug 25, 2014

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx28-evk: Fix display duplicate name warning

From: Fabio Estevam <[email protected]>

Provide the display unit address in order to fix the following warning:

[    0.114765] regulator-dummy: no parameters
[    0.152091] device-tree: Duplicate name in lcdif at 80030000, renamed to "display#1"
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx28-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx28-evk.dts +1 -1
index e4cc44c..c258b2c 100644
@@ -127,7 +127,7 @@
 				display = <&display>;
 				status = "okay";
 
-				display: display {
+				display: display at 0 {
 					bits-per-pixel = <32>;
 					bus-width = <24>;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: imx28-evk: Fix display duplicate name warning

Quoted 17 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Provide the display unit address in order to fix the following warning:

[    0.114765] regulator-dummy: no parameters
[    0.152091] device-tree: Duplicate name in lcdif at 80030000, renamed to "display#1"
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx28-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx28-evk.dts +0 -0
index e4cc44c..c258b2c 100644

arch/arm/boot/dts/imx28-evk.dts line 130

Quoted 5 lines
arch/arm/boot/dts/imx28-evk.dts +1 -1
@@ -127,7 +127,7 @@
 				display = <&display>;
 				status = "okay";
 
-				display: display {
+				display: display at 0 {

Unit address only makes sense where parent has #address-cells and #size-cells and the node itself has 'reg' property.

I guess it's more appropriate to name the node in particular display device model that the node is defining?

Shawn

Quoted 6 lines
arch/arm/boot/dts/imx28-evk.dts +0 -0
 					bits-per-pixel = <32>;
 					bus-width = <24>;
Signature · 1 line
1.9.1
author reviewer
#2 lore raw

PATCH 1/1 ARM: dts: imx28-evk: Fix display duplicate name warning

Quoted 2 lines · Shawn Guo

Unit address only makes sense where parent has #address-cells and #size-cells and the node itself has 'reg' property.

Ok, I followed the way arch/arm/boot/dts/imx28-tx28.dts implemented the display node.

Quoted 2 lines

I guess it's more appropriate to name the node in particular display device model that the node is defining?

Sorry, I did not understand. Could you please provide an example for clarification?

Thanks,

Fabio Estevam

#3 lore raw

PATCH 1/1 ARM: dts: imx28-evk: Fix display duplicate name warning

Quoted 5 lines · Fabio Estevam
Quoted 2 lines · Shawn Guo

Unit address only makes sense where parent has #address-cells and #size-cells and the node itself has 'reg' property.

Quoted 8 lines

Ok, I followed the way arch/arm/boot/dts/imx28-tx28.dts implemented the display node.

Quoted 2 lines

I guess it's more appropriate to name the node in particular display device model that the node is defining?

Sorry, I did not understand. Could you please provide an example for clarification?

See LVDS panel example in arch/arm/boot/dts/imx6qdl-sabresd.dtsi

Shawn