Skip to contentSkip to conversation

mpc5xxx: Add stub implementation of cache functions

PATCH New Vasili Galka 5 participants 6 messages Aug 26, 2014 – Sep 2, 2014 PowerPC

lore
Share & tools
lore

Vasili Galka

author
#0 lore raw

PATCH 1/1 mpc5xxx: Add stub implementation of cache functions

Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board.

I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future.

Signed-off-by Vasili Galka <[email protected]>
Cc Wolfgang Denk <[email protected]>, Marek Vasut <[email protected]>
---
 arch/powerpc/cpu/mpc5xxx/Makefile |    1 +
 arch/powerpc/cpu/mpc5xxx/cache.c  |   15 +++++++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
arch/powerpc/cpu/mpc5xxx/Makefile +1 -0
index 5c67e1d..d122b29 100644
@@ -7,6 +7,7 @@
 
 extra-y	= start.o
 extra-y += traps.o
+obj-y  += cache.o
 obj-y  += io.o
 obj-y  += firmware_sc_task_bestcomm.impl.o
 obj-y += i2c.o
arch/powerpc/cpu/mpc5xxx/cache.c new file +15 -0
new file mode 100644
index 0000000..5d674bc
@@ -0,0 +1,15 @@
+/*
+ * This file contains stub implementation of
+ *   invalidate_dcache_range()
+ *   flush_dcache_range()
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+void invalidate_dcache_range(unsigned long start, unsigned long stop)
+{
+}
+
+void flush_dcache_range(unsigned long start, unsigned long stop)
+{
+}
Signature · 1 line
1.7.9
#1 lore raw

PATCH 1/1 mpc5xxx: Add stub implementation of cache functions

Quoted 6 lines · Vasili Galka

Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board.

I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future.

Is MPC5xxx cache coherent PPC or is it not ?

Quoted 2 lines
Signed-off-by Vasili Galka <[email protected]>
Cc Wolfgang Denk <[email protected]>, Marek Vasut <[email protected]>

+CC Scott , he can likely clarify .

Quoted 29 lines
---
 arch/powerpc/cpu/mpc5xxx/Makefile |    1 +
 arch/powerpc/cpu/mpc5xxx/cache.c  |   15 +++++++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
(quoted diff) +0 -0

b/arch/powerpc/cpu/mpc5xxx/Makefile index 5c67e1d..d122b29 100644

arch/powerpc/cpu/mpc5xxx/Makefile +1 -0
@@ -7,6 +7,7 @@
 
 extra-y	= start.o
 extra-y += traps.o
+obj-y  += cache.o
 obj-y  += io.o
 obj-y  += firmware_sc_task_bestcomm.impl.o
 obj-y += i2c.o
(quoted diff) +0 -0

b/arch/powerpc/cpu/mpc5xxx/cache.c new file mode 100644 index 0000000..5d674bc

arch/powerpc/cpu/mpc5xxx/cache.c new file +5 -0
@@ -0,0 +1,15 @@
+/*
+ * This file contains stub implementation of
+ *   invalidate_dcache_range()
+ *   flush_dcache_range()
+ *

arch/powerpc/cpu/mpc5xxx/cache.c line 15

Quoted 10 lines
arch/powerpc/cpu/mpc5xxx/cache.c new file +10 -0
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+void invalidate_dcache_range(unsigned long start, unsigned long stop)
+{
+}
+
+void flush_dcache_range(unsigned long start, unsigned long stop)
+{
+}

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 mpc5xxx: Add stub implementation of cache functions

Quoted 8 lines · Marek Vasut
Quoted 6 lines · Vasili Galka

Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board.

I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future.

Quoted 6 lines

Is MPC5xxx cache coherent PPC or is it not ?

Quoted 2 lines
Signed-off-by Vasili Galka <[email protected]>
Cc Wolfgang Denk <[email protected]>, Marek Vasut <[email protected]>

+CC Scott , he can likely clarify .

MPC5xxx is from a different part of Freescale, so I'm not sure, except to note that the first link I found by googling "mpc5xxx cache coherent" is a patch from Wolfgang suggesting that it is:

https://git.linaro.org/?p=boot/u-boot-linaro-stable.git;a=patch;h=8419c013048b1f15f3fa2fc7c0463d860a04ee3e

:-)

-Scott

#3 lore raw

PATCH 1/1 mpc5xxx: Add stub implementation of cache functions

Quoted 14 lines · Scott Wood
Quoted 13 lines · Marek Vasut
Quoted 6 lines · Vasili Galka

Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board.

I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future.

Is MPC5xxx cache coherent PPC or is it not ?

Quoted 2 lines
Signed-off-by Vasili Galka <[email protected]>
Cc Wolfgang Denk <[email protected]>, Marek Vasut <[email protected]>
Quoted 8 lines
Quoted 1 line

+CC Scott , he can likely clarify .

MPC5xxx is from a different part of Freescale, so I'm not sure, except to note that the first link I found by googling "mpc5xxx cache coherent" is a patch from Wolfgang suggesting that it is:

https://git.linaro.org/?p=boot/u-boot-linaro-stable.git;a=patch;h=8419c0130
48b1f15f3fa2fc7c0463d860a04ee3e

Well OK. Who shall pick this patch up or decide what to do about it ?

Best regards,
Marek Vasut

#4 lore raw

PATCH 1/1 mpc5xxx: Add stub implementation of cache functions

In reply to Vasili Galka

Dear Vasili Galka,

Quoted 7 lines · In message <[email protected]> you wrote:

Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board.

I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future.

Quoted 7 lines
Signed-off-by Vasili Galka <[email protected]>
Cc Wolfgang Denk <[email protected]>, Marek Vasut <[email protected]>
---
 arch/powerpc/cpu/mpc5xxx/Makefile |    1 +
 arch/powerpc/cpu/mpc5xxx/cache.c  |   15 +++++++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
Acked-by Wolfgang Denk <[email protected]>

Tom, can you please pick this up directly? Thanks!

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number  of  Unix  installations  has  grown  to  10,  with  more
expected."    - The Unix Programmer's Manual, 2nd Edition, June, 1972
#5 lore raw

PATCH 1/1 mpc5xxx: Add stub implementation of cache functions

Quoted 18 lines · Wolfgang Denk

Dear Vasili Galka,

Quoted 7 lines · In message <[email protected]> you wrote:

Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board.

I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future.

Quoted 7 lines
Signed-off-by Vasili Galka <[email protected]>
Cc Wolfgang Denk <[email protected]>, Marek Vasut <[email protected]>
---
 arch/powerpc/cpu/mpc5xxx/Makefile |    1 +
 arch/powerpc/cpu/mpc5xxx/cache.c  |   15 +++++++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
Quoted 4 lines
Acked-by Wolfgang Denk <[email protected]>

Tom, can you please pick this up directly? Thanks!

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140902/6d79edb3/attachment.pgp>