Skip to contentSkip to conversation

ARM: shmobile: correct memory maps

PATCH New Simon Horman 4 participants 11 messages Aug 27, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: shmobile: correct memory maps

This short series builds on a previous posting
of a patch to correct the value of the second memory region of the lager. It does that and also corrects the syntax used for the lager and other shmobile boards.

Simon Horman (5):
ARM: shmobile: lager: correct memory map value and syntax
ARM: shmobile: henninger: correct memory map syntax
ARM: shmobile: koelsch: correct memory map syntax
ARM: shmobile: ape6evm-reference: correct memory map syntax
ARM: shmobile: ape6evm: correct memory map syntax

 arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts | 2 +-
 arch/arm/boot/dts/r8a73a4-ape6evm.dts           | 2 +-
 arch/arm/boot/dts/r8a7790-lager.dts             | 2 +-
 arch/arm/boot/dts/r8a7791-henninger.dts         | 2 +-
 arch/arm/boot/dts/r8a7791-koelsch.dts           | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.0.1
#1 lore raw

PATCH v2 1/5 ARM: shmobile: lager: correct memory map value and syntax

The base address of the second memory region on the lager board is 0x140000000. Update the tag used in the dts file accordingly.

Also correct a syntax error by using two comma-delimited 32 bit values rather than a single 64 bit value.

This is a documentation fix and should have no run-time affect.

This problem was introduced when the second memory region was added to the lager dts file by 62bc32a2573c4219 ("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14.

Cc Olof Johansson <[email protected]>
Cc Geert Uytterhoeven <[email protected]>

---
v2
* Correct syntax as well as value

---
 arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790-lager.dts +1 -1
index 0118cbf..9586c35 100644
@@ -32,7 +32,7 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
-	memory at 180000000 {
+	memory at 1,40000000 {
 		device_type = "memory";
 		reg = <1 0x40000000 0 0xc0000000>;
 	};
Signature · 1 line
2.0.1
#2 lore raw

PATCH v2 2/5 ARM: shmobile: henninger: correct memory map syntax

In reply to Simon Horman

Correct a syntax error by using two comma-delimited 32 bit values rather than a single 64 bit value.

This is a documentation fix and should have no run-time affect.

This problem was introduced when the device tree was added for henninger by 4b37ab033e6f8c975
("ARM: shmobile: henninger: initial device tree") in v3.15.

Cc Olof Johansson <[email protected]>
Cc Geert Uytterhoeven <[email protected]>

---
v2
* First post

---
 arch/arm/boot/dts/r8a7791-henninger.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7791-henninger.dts +1 -1
index f1b56de..b064724 100644
@@ -30,7 +30,7 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
-	memory at 200000000 {
+	memory at 2,00000000 {
 		device_type = "memory";
 		reg = <2 0x00000000 0 0x40000000>;
 	};
Signature · 1 line
2.0.1
#3 lore raw

PATCH v2 3/5 ARM: shmobile: koelsch: correct memory map syntax

In reply to Simon Horman

Correct a syntax error by using two comma-delimited 32 bit values rather than a single 64 bit value.

This is a documentation fix and should have no run-time affect.

This problem was introduced when the second memory region was added to the koelsch dts file by 4cd1bad45182c7f1 ("ARM: shmobile: koelsch: (1+1)GiB memory in DT") in v3.14.

Cc Olof Johansson <[email protected]>
Cc Geert Uytterhoeven <[email protected]>

---
v2
* First post

---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7791-koelsch.dts +1 -1
index 51807a3..caf66dc 100644
@@ -33,7 +33,7 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
-	memory at 200000000 {
+	memory at 2,00000000 {
 		device_type = "memory";
 		reg = <2 0x00000000 0 0x40000000>;
 	};
Signature · 1 line
2.0.1
#4 lore raw

PATCH v2 4/5 ARM: shmobile: ape6evm-reference: correct memory map syntax

In reply to Simon Horman

Correct a syntax error by using two comma-delimited 32 bit values rather than a single 64 bit value.

This is a documentation fix and should have no run-time affect.

This problem was introduced when the second memory region
was added to the ape6evm-reference dts file by 9701f442139bd21c ("ARM: shmobile: Include all 2 GiB of memory on APE6EVM DT Ref") in v3.13.

Cc Olof Johansson <[email protected]>
Cc Geert Uytterhoeven <[email protected]>

---
v2
* First post

---
 arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts +1 -1
index a860f32..9f1795f 100644
@@ -29,7 +29,7 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
-	memory at 200000000 {
+	memory at 2,00000000 {
 		device_type = "memory";
 		reg = <2 0x00000000 0 0x40000000>;
 	};
Signature · 1 line
2.0.1
#5 lore raw

PATCH v2 5/5 ARM: shmobile: ape6evm: correct memory map syntax

In reply to Simon Horman

Correct a syntax error by using two comma-delimited 32 bit values rather than a single 64 bit value.

This is a documentation fix and should have no run-time affect.

This problem was introduced when the second memory region was added to the ape6evm dts file by by 8353f09f579631d09 ("ARM: shmobile: Include all 2 GiB of memory on APE6EVM") in v3.13.

Cc Olof Johansson <[email protected]>
Cc Geert Uytterhoeven <[email protected]>

---
v2
* First post

---
 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +1 -1
index ce085fa..6d3e8fd 100644
@@ -25,7 +25,7 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
-	memory at 200000000 {
+	memory at 2,00000000 {
 		device_type = "memory";
 		reg = <2 0x00000000 0 0x40000000>;
 	};
Signature · 1 line
2.0.1
#6 lore raw

v2 cover ARM: shmobile: correct memory maps

In reply to Simon Horman

Hi Simon,

Quoted 11 lines · Simon Horman

This short series builds on a previous posting
of a patch to correct the value of the second memory region of the lager. It does that and also corrects the syntax used for the lager and other shmobile boards.

Simon Horman (5):
ARM: shmobile: lager: correct memory map value and syntax
ARM: shmobile: henninger: correct memory map syntax
ARM: shmobile: koelsch: correct memory map syntax
ARM: shmobile: ape6evm-reference: correct memory map syntax
ARM: shmobile: ape6evm: correct memory map syntax

Thanks for improving the current state. The patches look fine to me.

Cheers,

/ magnus

#7 lore raw

v2 cover ARM: shmobile: correct memory maps

Quoted 16 lines · Magnus Damm

Hi Simon,

Quoted 11 lines · Simon Horman

This short series builds on a previous posting
of a patch to correct the value of the second memory region of the lager. It does that and also corrects the syntax used for the lager and other shmobile boards.

Simon Horman (5):
ARM: shmobile: lager: correct memory map value and syntax
ARM: shmobile: henninger: correct memory map syntax
ARM: shmobile: koelsch: correct memory map syntax
ARM: shmobile: ape6evm-reference: correct memory map syntax
ARM: shmobile: ape6evm: correct memory map syntax

Quoted 3 lines

Thanks for improving the current state. The patches look fine to me.

Yep, agreed.

-Olof

#8 lore raw

v2 cover ARM: shmobile: correct memory maps

Quoted 17 lines · Olof Johansson
Quoted 16 lines · Magnus Damm

Hi Simon,

Quoted 11 lines · Simon Horman

This short series builds on a previous posting
of a patch to correct the value of the second memory region of the lager. It does that and also corrects the syntax used for the lager and other shmobile boards.

Simon Horman (5):
ARM: shmobile: lager: correct memory map value and syntax
ARM: shmobile: henninger: correct memory map syntax
ARM: shmobile: koelsch: correct memory map syntax
ARM: shmobile: ape6evm-reference: correct memory map syntax
ARM: shmobile: ape6evm: correct memory map syntax

Quoted 7 lines
Quoted 3 lines

Thanks for improving the current state. The patches look fine to me.

Yep, agreed.

Thanks, I have queued these up as fixes for v3.17. I'll send you a pull-request in the not to distant future.

#9 lore raw

v2 cover ARM: shmobile: correct memory maps

Quoted 20 lines · Simon Horman
Quoted 19 lines · Olof Johansson
Quoted 18 lines · Magnus Damm

Hi Simon,

Quoted 11 lines · Simon Horman

This short series builds on a previous posting
of a patch to correct the value of the second memory region of the lager. It does that and also corrects the syntax used for the lager and other shmobile boards.

Simon Horman (5):
ARM: shmobile: lager: correct memory map value and syntax
ARM: shmobile: henninger: correct memory map syntax
ARM: shmobile: koelsch: correct memory map syntax
ARM: shmobile: ape6evm-reference: correct memory map syntax
ARM: shmobile: ape6evm: correct memory map syntax

Thanks for improving the current state. The patches look fine to me.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Yep, agreed.

Thanks, I have queued these up as fixes for v3.17. I'll send you a pull-request in the not to distant future.

This is 3.18 cleanup material as far as I am concerned, so please send it as such. :)

-Olof

#10 lore raw

v2 cover ARM: shmobile: correct memory maps

Quoted 25 lines · Olof Johansson
Quoted 24 lines · Simon Horman
Quoted 23 lines · Olof Johansson
Quoted 16 lines · Magnus Damm

Hi Simon,

Quoted 11 lines · Simon Horman

This short series builds on a previous posting
of a patch to correct the value of the second memory region of the lager. It does that and also corrects the syntax used for the lager and other shmobile boards.

Simon Horman (5):
ARM: shmobile: lager: correct memory map value and syntax
ARM: shmobile: henninger: correct memory map syntax
ARM: shmobile: koelsch: correct memory map syntax
ARM: shmobile: ape6evm-reference: correct memory map syntax
ARM: shmobile: ape6evm: correct memory map syntax

Quoted 3 lines

Thanks for improving the current state. The patches look fine to me.

Yep, agreed.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thanks, I have queued these up as fixes for v3.17. I'll send you a pull-request in the not to distant future.

This is 3.18 cleanup material as far as I am concerned, so please send it as such. :)

Sure, will do.