Skip to contentSkip to conversation

ARM: shmobile: armadillo800eva reference: Remove C board code

PATCH In review Magnus Damm 2 participants 4 messages Aug 28, 2014 – Sep 4, 2014

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 4/5 ARM: shmobile: armadillo800eva reference: Remove C board code

From: Magnus Damm <[email protected]>

Now when the r8a7740 generic multiplatform case has the same features as the DT reference board code then get rid of the Armadillo800EVA DT reference C board code. DT Reference code in the future shall make use of the r8a7740 Multiplatform support code with the generic SoC machine vector.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Kconfig                           |   15 -
 arch/arm/mach-shmobile/Makefile                          |    1 
 arch/arm/mach-shmobile/Makefile.boot                     |    1 
 arch/arm/mach-shmobile/board-armadillo800eva-reference.c |  199 --------------
 4 files changed, 216 deletions(-)
arch/arm/mach-shmobile/Kconfig +0 -15
@@ -187,21 +187,6 @@ config MACH_ARMADILLO800EVA
 	select SND_SOC_WM8978 if SND_SIMPLE_CARD
 	select USE_OF
 
-config MACH_ARMADILLO800EVA_REFERENCE
-	bool "Armadillo-800 EVA board - Reference Device Tree Implementation"
-	depends on ARCH_R8A7740
-	select ARCH_REQUIRE_GPIOLIB
-	select REGULATOR_FIXED_VOLTAGE if REGULATOR
-	select SMSC_PHY if SH_ETH
-	select SND_SOC_WM8978 if SND_SIMPLE_CARD
-	select USE_OF
-	---help---
-	   Use reference implementation of Armadillo800 EVA board support
-	   which makes greater use of device tree at the expense
-	   of not supporting a number of devices.
-
-	   This is intended to aid developers
-
 config MACH_BOCKW
 	bool "BOCK-W platform"
 	depends on ARCH_R8A7778
arch/arm/mach-shmobile/Makefile +0 -1
@@ -68,7 +68,6 @@ obj-$(CONFIG_MACH_BOCKW_REFERENCE)	+= bo
 obj-$(CONFIG_MACH_MARZEN)	+= board-marzen.o
 obj-$(CONFIG_MACH_LAGER)	+= board-lager.o
 obj-$(CONFIG_MACH_ARMADILLO800EVA)	+= board-armadillo800eva.o
-obj-$(CONFIG_MACH_ARMADILLO800EVA_REFERENCE)	+= board-armadillo800eva-reference.o
 obj-$(CONFIG_MACH_KOELSCH)	+= board-koelsch.o
 obj-$(CONFIG_MACH_KZM9G)	+= board-kzm9g.o
 obj-$(CONFIG_MACH_KZM9G_REFERENCE)	+= board-kzm9g-reference.o
arch/arm/mach-shmobile/Makefile.boot +1 -201

207 lines not on this page · raw message

author maintainer
#1 lore raw
Quoted 8 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Now when the r8a7740 generic multiplatform case has the same features as the DT reference board code then get rid of the Armadillo800EVA DT reference C board code. DT Reference code in the future shall make use of the r8a7740 Multiplatform support code with the generic SoC machine vector.

Quoted 8 lines
Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Kconfig                           |   15 -
 arch/arm/mach-shmobile/Makefile                          |    1
 arch/arm/mach-shmobile/Makefile.boot                     |    1
 arch/arm/mach-shmobile/board-armadillo800eva-reference.c |  199 --------------
 4 files changed, 216 deletions(-)

Hi Simon,

Thanks for your help picking up this series. I noticed that in your git repository this particular patch is missing the Kconfig and Makefile bits. If this is intentional and you intend to remove those portions in a separate patch somewhere down the line then that's of course fine with me. If not then please consider including them. =)

Cheers,

/ magnus

#2 lore raw
In reply to Magnus Damm
Quoted 18 lines · Magnus Damm
Quoted 8 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Now when the r8a7740 generic multiplatform case has the same features as the DT reference board code then get rid of the Armadillo800EVA DT reference C board code. DT Reference code in the future shall make use of the r8a7740 Multiplatform support code with the generic SoC machine vector.

Quoted 8 lines
Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Kconfig                           |   15 -
 arch/arm/mach-shmobile/Makefile                          |    1
 arch/arm/mach-shmobile/Makefile.boot                     |    1
 arch/arm/mach-shmobile/board-armadillo800eva-reference.c |  199 --------------
 4 files changed, 216 deletions(-)
Quoted 7 lines

Hi Simon,

Thanks for your help picking up this series. I noticed that in your git repository this particular patch is missing the Kconfig and Makefile bits. If this is intentional and you intend to remove those portions in a separate patch somewhere down the line then that's of course fine with me. If not then please consider including them. =)

Thanks, that was not intentional.
I'll re-apply your patch.

author maintainer
#3 lore raw
In reply to Magnus Damm
Quoted 21 lines · Simon Horman
Quoted 20 lines · Magnus Damm
Quoted 8 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Now when the r8a7740 generic multiplatform case has the same features as the DT reference board code then get rid of the Armadillo800EVA DT reference C board code. DT Reference code in the future shall make use of the r8a7740 Multiplatform support code with the generic SoC machine vector.

Quoted 8 lines
Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Kconfig                           |   15 -
 arch/arm/mach-shmobile/Makefile                          |    1
 arch/arm/mach-shmobile/Makefile.boot                     |    1
 arch/arm/mach-shmobile/board-armadillo800eva-reference.c |  199 --------------
 4 files changed, 216 deletions(-)

Hi Simon,

Quoted 8 lines
Quoted 5 lines

Thanks for your help picking up this series. I noticed that in your git repository this particular patch is missing the Kconfig and Makefile bits. If this is intentional and you intend to remove those portions in a separate patch somewhere down the line then that's of course fine with me. If not then please consider including them. =)

Thanks, that was not intentional.
I'll re-apply your patch.

Thanks!

/ magnus