Skip to contentSkip to conversation

i2c: exynos: add support for HSI2C module on Exynos7

PATCH New Naveen Krishna Chatradhi 3 participants 4 messages Aug 27, 2014 – Sep 3, 2014

Subsystems (3)
Device tree bindings Arm Samsung Exynos I2C subsystem host drivers
lore
Share & tools
lore

Naveen Krishna Chatradhi

author
#0 lore raw

PATCH 7/14 i2c: exynos: add support for HSI2C module on Exynos7

The HSI2C module on Exynos7 differs in the transfer status bits. Transfer status bits were moved to INT_ENABLE and INT_STATUS registers

This patch adds support for the HSI2C module on Exynos7.
1. Implementes a "hw" field in the variant struct to distinguish the hardware.
2. Updates the dt-new compatible in dt-binding documenation

Signed-off-by Naveen Krishna Chatradhi <[email protected]>

To: linux-i2c at vger.kernel.org
Cc: Wolfram Sang <[email protected]>

---
 .../devicetree/bindings/i2c/i2c-exynos5.txt        |    2 +
 drivers/i2c/busses/i2c-exynos5.c                   |   71 ++++++++++++++++++--
 2 files changed, 67 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-exynos5.txt +2 -0
index d4745e3..2dbc0b6 100644
@@ -12,6 +12,8 @@ Required properties:
 				on Exynos5250 and Exynos5420 SoCs.
 	-> "samsung,exynos5260-hsi2c", for i2c compatible with HSI2C available
 				on Exynos5260 SoCs.
+	-> "samsung,exynos7-hsi2c", for i2c compatible with HSI2C available
+				on Exynos7 SoCs.
 
   - reg: physical base address of the controller and length of memory mapped
     region.
drivers/i2c/busses/i2c-exynos5.c +65 -6

146 lines not on this page · raw message

Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 8/14 i2c: exynos5: Add Kconfig dependencies

The i2c-exynos5.c driver can be reused for the HSI2C controller on Exynos7 SoCs from Samsung.

This patch adds the Kconfig dependency to choose i2c-exynos5.c for CONFIG_ARCH_EXYNOS7.

Signed-off-by Naveen Krishna Chatradhi <[email protected]>

To: linux-i2c at vger.kernel.org
Cc: Wolfram Sang <[email protected]>

---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
index 2ac87fa..bd18fa6 100644
@@ -465,7 +465,7 @@ config I2C_EG20T
 
 config I2C_EXYNOS5
 	tristate "Exynos5 high-speed I2C driver"
-	depends on ARCH_EXYNOS5 && OF
+	depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF
 	default y
 	help
 	  High-speed I2C controller on Exynos5 based Samsung SoCs.
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 8/14 i2c: exynos5: Add Kconfig dependencies

Quoted 18 lines · Naveen Krishna Chatradhi

The i2c-exynos5.c driver can be reused for the HSI2C controller on Exynos7 SoCs from Samsung.

This patch adds the Kconfig dependency to choose i2c-exynos5.c for CONFIG_ARCH_EXYNOS7.

Signed-off-by Naveen Krishna Chatradhi <[email protected]>

To: linux-i2c at vger.kernel.org
Cc: Wolfram Sang <[email protected]>

---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +0 -0
index 2ac87fa..bd18fa6 100644

drivers/i2c/busses/Kconfig config I2C_EG20T · line 468

Quoted 5 lines
drivers/i2c/busses/Kconfig +1 -1
@@ -465,7 +465,7 @@ config I2C_EG20T
 
 config I2C_EXYNOS5
 	tristate "Exynos5 high-speed I2C driver"
-	depends on ARCH_EXYNOS5 && OF
+	depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF

Ick, this will keep growing. Please use ARCH_EXYNOS instead. Yes, this means you need to add it to the arm64 Kconfig and select it from ARCH_EXYNOS7.

-Olof

#3 lore raw

PATCH 8/14 i2c: exynos5: Add Kconfig dependencies

Hi Olof,

Quoted 20 lines · Olof Johansson
Quoted 19 lines · Naveen Krishna Chatradhi

The i2c-exynos5.c driver can be reused for the HSI2C controller on Exynos7 SoCs from Samsung.

This patch adds the Kconfig dependency to choose i2c-exynos5.c for CONFIG_ARCH_EXYNOS7.

Signed-off-by Naveen Krishna Chatradhi <[email protected]>

To: linux-i2c at vger.kernel.org
Cc: Wolfram Sang <[email protected]>

---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +0 -0
index 2ac87fa..bd18fa6 100644
@@ -465,7 +465,7 @@ config I2C_EG20T
Quoted 8 lines

drivers/i2c/busses/Kconfig config I2C_EG20T · line 468

Quoted 4 lines
drivers/i2c/busses/Kconfig +1 -1
 config I2C_EXYNOS5
      tristate "Exynos5 high-speed I2C driver"
-     depends on ARCH_EXYNOS5 && OF
+     depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF

Ick, this will keep growing. Please use ARCH_EXYNOS instead. Yes, this means you need to add it to the arm64 Kconfig and select it from ARCH_EXYNOS7.

Ok, will repost with ARCH_EXYNOS. Thanks.

Quoted 4 lines

-Olof

Signature · 2 lines
Shine bright,
(: Nav :)