Skip to contentSkip to conversation

ARM: dts: Add DT changes for display on snow

PATCH Superseded Ajay Kumar 4 participants 9 messages Aug 27, 2014 – Aug 28, 2014

Subsystems (2)
Device tree bindings Arm Samsung Exynos

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Ajay Kumar

author
#0 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

Signed-off-by Ajay Kumar <[email protected]>

---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5250-snow.dts |   41 ++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos5250-snow.dts +22 -19
index f2b8c41..1ac9709 100644
@@ -9,6 +9,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "exynos5250.dtsi"
 #include "exynos5250-cros-common.dtsi"
 

@@ -181,7 +182,7 @@
 					dcdc3 {
 						ti,enable-ext-control;
 					};
-					fet1 {
+					fet1: fet1 {
 						regulator-name = "vcd_led";
 						ti,overcurrent-wait = <3>;
 					};

@@ -204,7 +205,7 @@
 						regulator-always-on;
 						ti,overcurrent-wait = <3>;
 					};
-					fet6 {
+					fet6: fet6 {
 						regulator-name = "lcd_vdd";
 						ti,overcurrent-wait = <3>;
 					};

@@ -253,6 +254,15 @@
 			pinctrl-0 = <&max98095_en>;
 			pinctrl-names = "default";
 		};
+
+		ptn3460: lvds-bridge at 20 {
+			compatible = "nxp,ptn3460";
+			reg = <0x20>;
+			powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
+			reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
+			edid-emulation = <5>;
+			panel = <&panel>;
+		};
 	};
 
 	i2s0: i2s at 03830000 {

@@ -300,11 +310,13 @@
 		vdd_pll-supply = <&ldo8_reg>;
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm 0 1000000 0>;
 		brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
 		default-brightness-level = <7>;
+		enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
+		power-supply = <&fet1>;
 		pinctrl-0 = <&pwm0_out>;
 		pinctrl-names = "default";
 	};

@@ -314,6 +326,12 @@
 		samsung,invert-vclk;
 	};
 
+	panel: panel {
+		compatible = "chunghwa,claa101wb01";
+		power-supply = <&fet6>;
+		backlight = <&backlight>;
+	};
+
 	dp-controller at 145B0000 {
 		status = "okay";
 		pinctrl-names = "default";

@@ -325,22 +343,7 @@
 		samsung,link-rate = <0x0a>;
 		samsung,lane-count = <2>;
 		samsung,hpd-gpio = <&gpx0 7 0>;
-
-		display-timings {
-			native-mode = <&timing1>;
-
-			timing1: timing at 1 {
-				clock-frequency = <70589280>;
-				hactive = <1366>;
-				vactive = <768>;
-				hfront-porch = <40>;
-				hback-porch = <40>;
-				hsync-len = <32>;
-				vback-porch = <10>;
-				vfront-porch = <12>;
-				vsync-len = <6>;
-			};
-		};
+		bridge = <&ptn3460>;
 	};
 };
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/2 ARM: dts: Add DT changes for display on peach_pit

Add DT nodes for ps8622 bridge chip and panel.
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on peach_pit.

Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

Signed-off-by Ajay Kumar <[email protected]>

---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5420-peach-pit.dts |   36 +++++++++++++++-------------
 1 file changed, 19 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5420-peach-pit.dts +19 -17
index 228a6b1..1070a31 100644
@@ -30,11 +30,12 @@
 		i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm 0 1000000 0>;
 		brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
 		default-brightness-level = <7>;
+		power-supply = <&tps65090_fet1>;
 		pinctrl-0 = <&pwm0_out>;
 		pinctrl-names = "default";
 	};

@@ -100,6 +101,12 @@
 		regulator-boot-on;
 		regulator-always-on;
 	};
+
+	panel: panel {
+		compatible = "chunghwa,claa101wb01";
+		power-supply = <&tps65090_fet6>;
+		backlight = <&backlight>;
+	};
 };
 
 &dp {

@@ -113,22 +120,7 @@
 	samsung,link-rate = <0x06>;
 	samsung,lane-count = <2>;
 	samsung,hpd-gpio = <&gpx2 6 0>;
-
-	display-timings {
-		native-mode = <&timing1>;
-
-		timing1: timing at 1 {
-			clock-frequency = <70589280>;
-			hactive = <1366>;
-			vactive = <768>;
-			hfront-porch = <40>;
-			hback-porch = <40>;
-			hsync-len = <32>;
-			vback-porch = <10>;
-			vfront-porch = <12>;
-			vsync-len = <6>;
-		};
-	};
+	bridge = <&ps8625>;
 };
 
 &fimd {

@@ -155,6 +147,16 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&max98090_irq>;
 	};
+
+	ps8625: lvds-bridge at 48 {
+		compatible = "parade,ps8625";
+		reg = <0x48>;
+		sleep-gpios = <&gpx3 5 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpy7 7 GPIO_ACTIVE_HIGH>;
+		lane-count = <2>;
+		panel = <&panel>;
+		use-external-pwm;
+	};
 };
 
 &hsi2c_9 {
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

In reply to Ajay Kumar
Quoted 7 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Thanks,
Mark.

Quoted 116 lines
Signed-off-by Ajay Kumar <[email protected]>

---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5250-snow.dts |   41 ++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos5250-snow.dts +22 -19
index f2b8c41..1ac9709 100644
@@ -9,6 +9,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "exynos5250.dtsi"
 #include "exynos5250-cros-common.dtsi"
 

@@ -181,7 +182,7 @@
 					dcdc3 {
 						ti,enable-ext-control;
 					};
-					fet1 {
+					fet1: fet1 {
 						regulator-name = "vcd_led";
 						ti,overcurrent-wait = <3>;
 					};

@@ -204,7 +205,7 @@
 						regulator-always-on;
 						ti,overcurrent-wait = <3>;
 					};
-					fet6 {
+					fet6: fet6 {
 						regulator-name = "lcd_vdd";
 						ti,overcurrent-wait = <3>;
 					};

@@ -253,6 +254,15 @@
 			pinctrl-0 = <&max98095_en>;
 			pinctrl-names = "default";
 		};
+
+		ptn3460: lvds-bridge at 20 {
+			compatible = "nxp,ptn3460";
+			reg = <0x20>;
+			powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
+			reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
+			edid-emulation = <5>;
+			panel = <&panel>;
+		};
 	};
 
 	i2s0: i2s at 03830000 {

@@ -300,11 +310,13 @@
 		vdd_pll-supply = <&ldo8_reg>;
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm 0 1000000 0>;
 		brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
 		default-brightness-level = <7>;
+		enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
+		power-supply = <&fet1>;
 		pinctrl-0 = <&pwm0_out>;
 		pinctrl-names = "default";
 	};

@@ -314,6 +326,12 @@
 		samsung,invert-vclk;
 	};
 
+	panel: panel {
+		compatible = "chunghwa,claa101wb01";
+		power-supply = <&fet6>;
+		backlight = <&backlight>;
+	};
+
 	dp-controller at 145B0000 {
 		status = "okay";
 		pinctrl-names = "default";

@@ -325,22 +343,7 @@
 		samsung,link-rate = <0x0a>;
 		samsung,lane-count = <2>;
 		samsung,hpd-gpio = <&gpx0 7 0>;
-
-		display-timings {
-			native-mode = <&timing1>;
-
-			timing1: timing at 1 {
-				clock-frequency = <70589280>;
-				hactive = <1366>;
-				vactive = <768>;
-				hfront-porch = <40>;
-				hback-porch = <40>;
-				hsync-len = <32>;
-				vback-porch = <10>;
-				vfront-porch = <12>;
-				vsync-len = <6>;
-			};
-		};
+		bridge = <&ptn3460>;
 	};
 };
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

Quoted 5 lines · Mark Rutland
Quoted 4 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Quoted 8 lines
Quoted 3 lines

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Actual display used is "AUO,B116XTN0", for which no data currently exists in panel file. Instead of adding a new panel_desc for B116XTN0, why not we reuse existing ones? what is the "identifier" you are talking about?

Ajay

Quoted 119 lines

Thanks,
Mark.

Quoted 116 lines
Signed-off-by Ajay Kumar <[email protected]>

---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5250-snow.dts |   41 ++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos5250-snow.dts +22 -20
index f2b8c41..1ac9709 100644
@@ -9,6 +9,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "exynos5250.dtsi"
 #include "exynos5250-cros-common.dtsi"
 

@@ -181,7 +182,7 @@
                                      dcdc3 {
                                              ti,enable-ext-control;
                                      };
-                                     fet1 {
+                                     fet1: fet1 {
                                              regulator-name = "vcd_led";
                                              ti,overcurrent-wait = <3>;
                                      };

@@ -204,7 +205,7 @@
                                              regulator-always-on;
                                              ti,overcurrent-wait = <3>;
                                      };
-                                     fet6 {
+                                     fet6: fet6 {
                                              regulator-name = "lcd_vdd";
                                              ti,overcurrent-wait = <3>;
                                      };

@@ -253,6 +254,15 @@
                      pinctrl-0 = <&max98095_en>;
                      pinctrl-names = "default";
              };
+
+             ptn3460: lvds-bridge at 20 {
+                     compatible = "nxp,ptn3460";
+                     reg = <0x20>;
+                     powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
+                     reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
+                     edid-emulation = <5>;
+                     panel = <&panel>;
+             };
      };
 
      i2s0: i2s at 03830000 {

@@ -300,11 +310,13 @@
              vdd_pll-supply = <&ldo8_reg>;
      };
 
-     backlight {
+     backlight: backlight {
              compatible = "pwm-backlight";
              pwms = <&pwm 0 1000000 0>;
              brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
              default-brightness-level = <7>;
+             enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
+             power-supply = <&fet1>;
              pinctrl-0 = <&pwm0_out>;
              pinctrl-names = "default";
      };

@@ -314,6 +326,12 @@
              samsung,invert-vclk;
      };
 
+     panel: panel {
+             compatible = "chunghwa,claa101wb01";
+             power-supply = <&fet6>;
+             backlight = <&backlight>;
+     };
+
      dp-controller at 145B0000 {
              status = "okay";
              pinctrl-names = "default";

@@ -325,22 +343,7 @@
              samsung,link-rate = <0x0a>;
              samsung,lane-count = <2>;
              samsung,hpd-gpio = <&gpx0 7 0>;
-
-             display-timings {
-                     native-mode = <&timing1>;
-
-                     timing1: timing at 1 {
-                             clock-frequency = <70589280>;
-                             hactive = <1366>;
-                             vactive = <768>;
-                             hfront-porch = <40>;
-                             hback-porch = <40>;
-                             hsync-len = <32>;
-                             vback-porch = <10>;
-                             vfront-porch = <12>;
-                             vsync-len = <6>;
-                     };
-             };
+             bridge = <&ptn3460>;
      };
 };
 
--

1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

Quoted 10 lines · Ajay kumar
Quoted 9 lines · Mark Rutland
Quoted 7 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

Quoted 7 lines
Quoted 4 lines

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Actual display used is "AUO,B116XTN0", for which no data currently exists in panel file. Instead of adding a new panel_desc for B116XTN0, why not we reuse existing ones? what is the "identifier" you are talking about?

The compatible string.

So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";

That way if we need specific data we can add it later.

What vendor is AU0? Can we add a vendor-prefix in parallel?

Thanks,
Mark.

Quoted 122 lines

Ajay

Quoted 119 lines

Thanks,
Mark.

Quoted 116 lines
Signed-off-by Ajay Kumar <[email protected]>

---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5250-snow.dts |   41 ++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos5250-snow.dts +22 -20
index f2b8c41..1ac9709 100644
@@ -9,6 +9,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "exynos5250.dtsi"
 #include "exynos5250-cros-common.dtsi"
 

@@ -181,7 +182,7 @@
                                      dcdc3 {
                                              ti,enable-ext-control;
                                      };
-                                     fet1 {
+                                     fet1: fet1 {
                                              regulator-name = "vcd_led";
                                              ti,overcurrent-wait = <3>;
                                      };

@@ -204,7 +205,7 @@
                                              regulator-always-on;
                                              ti,overcurrent-wait = <3>;
                                      };
-                                     fet6 {
+                                     fet6: fet6 {
                                              regulator-name = "lcd_vdd";
                                              ti,overcurrent-wait = <3>;
                                      };

@@ -253,6 +254,15 @@
                      pinctrl-0 = <&max98095_en>;
                      pinctrl-names = "default";
              };
+
+             ptn3460: lvds-bridge at 20 {
+                     compatible = "nxp,ptn3460";
+                     reg = <0x20>;
+                     powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
+                     reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
+                     edid-emulation = <5>;
+                     panel = <&panel>;
+             };
      };
 
      i2s0: i2s at 03830000 {

@@ -300,11 +310,13 @@
              vdd_pll-supply = <&ldo8_reg>;
      };
 
-     backlight {
+     backlight: backlight {
              compatible = "pwm-backlight";
              pwms = <&pwm 0 1000000 0>;
              brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
              default-brightness-level = <7>;
+             enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
+             power-supply = <&fet1>;
              pinctrl-0 = <&pwm0_out>;
              pinctrl-names = "default";
      };

@@ -314,6 +326,12 @@
              samsung,invert-vclk;
      };
 
+     panel: panel {
+             compatible = "chunghwa,claa101wb01";
+             power-supply = <&fet6>;
+             backlight = <&backlight>;
+     };
+
      dp-controller at 145B0000 {
              status = "okay";
              pinctrl-names = "default";

@@ -325,22 +343,7 @@
              samsung,link-rate = <0x0a>;
              samsung,lane-count = <2>;
              samsung,hpd-gpio = <&gpx0 7 0>;
-
-             display-timings {
-                     native-mode = <&timing1>;
-
-                     timing1: timing at 1 {
-                             clock-frequency = <70589280>;
-                             hactive = <1366>;
-                             vactive = <768>;
-                             hfront-porch = <40>;
-                             hback-porch = <40>;
-                             hsync-len = <32>;
-                             vback-porch = <10>;
-                             vfront-porch = <12>;
-                             vsync-len = <6>;
-                     };
-             };
+             bridge = <&ptn3460>;
      };
 };
 
--

1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

Quoted 15 lines · Mark Rutland
Quoted 14 lines · Ajay kumar
Quoted 13 lines · Mark Rutland
Quoted 7 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Quoted 7 lines
Quoted 3 lines

Actual display used is "AUO,B116XTN0", for which no data currently exists in panel file. Instead of adding a new panel_desc for B116XTN0, why not we reuse existing ones? what is the "identifier" you are talking about?

The compatible string.

So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";

Sorry, hardware engineer says actual LCD name is "auo,b116xw03".

Quoted 1 line

That way if we need specific data we can add it later.

I think we can add a new panel_desc for "auo,b116xw03".
Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has LCD dimension 223x125.
What is Thierry's opinion on adding this new LCD?

Quoted 1 line

What vendor is AU0? Can we add a vendor-prefix in parallel?

its "auo" (already present: AU Optronics Corporation)

Ajay

Quoted 125 lines

Thanks,
Mark.

Quoted 122 lines

Ajay

Quoted 119 lines

Thanks,
Mark.

Quoted 116 lines
Signed-off-by Ajay Kumar <[email protected]>

---
Changes since V1:
-- Remove "simple-panel" compatible string.
-- Use GPIO_ACTIVE_HIGH instead of 0.
-- Change panel node naming from "panel-simple" to "panel".

 arch/arm/boot/dts/exynos5250-snow.dts |   41 ++++++++++++++++++---------------
 1 file changed, 22 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos5250-snow.dts +22 -20
index f2b8c41..1ac9709 100644
@@ -9,6 +9,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "exynos5250.dtsi"
 #include "exynos5250-cros-common.dtsi"
 

@@ -181,7 +182,7 @@
                                      dcdc3 {
                                              ti,enable-ext-control;
                                      };
-                                     fet1 {
+                                     fet1: fet1 {
                                              regulator-name = "vcd_led";
                                              ti,overcurrent-wait = <3>;
                                      };

@@ -204,7 +205,7 @@
                                              regulator-always-on;
                                              ti,overcurrent-wait = <3>;
                                      };
-                                     fet6 {
+                                     fet6: fet6 {
                                              regulator-name = "lcd_vdd";
                                              ti,overcurrent-wait = <3>;
                                      };

@@ -253,6 +254,15 @@
                      pinctrl-0 = <&max98095_en>;
                      pinctrl-names = "default";
              };
+
+             ptn3460: lvds-bridge at 20 {
+                     compatible = "nxp,ptn3460";
+                     reg = <0x20>;
+                     powerdown-gpios = <&gpy2 5 GPIO_ACTIVE_HIGH>;
+                     reset-gpios = <&gpx1 5 GPIO_ACTIVE_HIGH>;
+                     edid-emulation = <5>;
+                     panel = <&panel>;
+             };
      };
 
      i2s0: i2s at 03830000 {

@@ -300,11 +310,13 @@
              vdd_pll-supply = <&ldo8_reg>;
      };
 
-     backlight {
+     backlight: backlight {
              compatible = "pwm-backlight";
              pwms = <&pwm 0 1000000 0>;
              brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
              default-brightness-level = <7>;
+             enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
+             power-supply = <&fet1>;
              pinctrl-0 = <&pwm0_out>;
              pinctrl-names = "default";
      };

@@ -314,6 +326,12 @@
              samsung,invert-vclk;
      };
 
+     panel: panel {
+             compatible = "chunghwa,claa101wb01";
+             power-supply = <&fet6>;
+             backlight = <&backlight>;
+     };
+
      dp-controller at 145B0000 {
              status = "okay";
              pinctrl-names = "default";

@@ -325,22 +343,7 @@
              samsung,link-rate = <0x0a>;
              samsung,lane-count = <2>;
              samsung,hpd-gpio = <&gpx0 7 0>;
-
-             display-timings {
-                     native-mode = <&timing1>;
-
-                     timing1: timing at 1 {
-                             clock-frequency = <70589280>;
-                             hactive = <1366>;
-                             vactive = <768>;
-                             hfront-porch = <40>;
-                             hback-porch = <40>;
-                             hsync-len = <32>;
-                             vback-porch = <10>;
-                             vfront-porch = <12>;
-                             vsync-len = <6>;
-                     };
-             };
+             bridge = <&ptn3460>;
      };
 };
 
--

1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

Quoted 16 lines · Ajay kumar
Quoted 15 lines · Mark Rutland
Quoted 14 lines · Ajay kumar
Quoted 13 lines · Mark Rutland
Quoted 7 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Actual display used is "AUO,B116XTN0", for which no data currently exists in panel file. Instead of adding a new panel_desc for B116XTN0, why not we reuse existing ones? what is the "identifier" you are talking about?

The compatible string.

So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";

Sorry, hardware engineer says actual LCD name is "auo,b116xw03".

Ok.

Quoted 8 lines
Quoted 1 line

That way if we need specific data we can add it later.

I think we can add a new panel_desc for "auo,b116xw03".
Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has LCD dimension 223x125.
What is Thierry's opinion on adding this new LCD?

Quoted 1 line

What vendor is AU0? Can we add a vendor-prefix in parallel?

its "auo" (already present: AU Optronics Corporation)

Ah, whoops. Mistook 'O' for '0'.

Thanks,
Mark.

#7 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

In reply to Ajay kumar
Quoted 22 lines · Ajay kumar
Quoted 21 lines · Mark Rutland
Quoted 10 lines · Ajay kumar
Quoted 9 lines · Mark Rutland
Quoted 7 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

Quoted 7 lines
Quoted 4 lines

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Actual display used is "AUO,B116XTN0", for which no data currently exists in panel file. Instead of adding a new panel_desc for B116XTN0, why not we reuse existing ones? what is the "identifier" you are talking about?

The compatible string.

Quoted 8 lines
Quoted 1 line

So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";

Sorry, hardware engineer says actual LCD name is "auo,b116xw03".

Quoted 1 line

That way if we need specific data we can add it later.

I think we can add a new panel_desc for "auo,b116xw03".
Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has LCD dimension 223x125.
What is Thierry's opinion on adding this new LCD?

I think you should simply add a new panel_desc for the panel. It may use similar timings, but it's likely not "compatible" in the way required by device tree. As you say, dimensions are different and those may have an influence on the DPI setting. There's really no reason why this should share the panel_desc with another panel.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140828/45546ce0/attachment-0001.sig>

#8 lore raw

PATCH v2 1/2 ARM: dts: Add DT changes for display on snow

Quoted 32 lines · Thierry Reding
Quoted 22 lines · Ajay kumar
Quoted 21 lines · Mark Rutland
Quoted 10 lines · Ajay kumar
Quoted 9 lines · Mark Rutland
Quoted 7 lines · Ajay Kumar

Add DT nodes for ptn3460 bridge chip and panel.
Add backlight enable pin and backlight power supply for pwm-backlight. Also add bridge phandle needed by dp to enable display on snow.

Note that, snow doesn't support "chunghwa,claa101wb01" panel, but still we choose to reuse the binding since "chunghwa,claa101wb01" has similar LCD timings.

Quoted 7 lines
Quoted 4 lines

What does it actually have?

It's fine to have "chunghwa,claa101wb01" as a fallback but we should have an identifier for the actual display, too.

Actual display used is "AUO,B116XTN0", for which no data currently exists in panel file. Instead of adding a new panel_desc for B116XTN0, why not we reuse existing ones? what is the "identifier" you are talking about?

The compatible string.

Quoted 8 lines
Quoted 1 line

So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";

Sorry, hardware engineer says actual LCD name is "auo,b116xw03".

Quoted 1 line

That way if we need specific data we can add it later.

I think we can add a new panel_desc for "auo,b116xw03".
Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has LCD dimension 223x125.
What is Thierry's opinion on adding this new LCD?

Quoted 7 lines

I think you should simply add a new panel_desc for the panel. It may use similar timings, but it's likely not "compatible" in the way required by device tree. As you say, dimensions are different and those may have an influence on the DPI setting. There's really no reason why this should share the panel_desc with another panel.

Thierry

This sounds sane to me.

Mark.