Skip to contentSkip to conversation

irqchip: keystone: Add irq controller ip driver

DISCUSSION Dan Carpenter 1 participant 1 message Aug 28, 2014 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Grygorii Strashko,

The patch 89323f8c504a: "irqchip: keystone: Add irq controller ip driver" from Jul 23, 2014, leads to the following static checker warning:

	drivers/irqchip/irq-keystone.c:166 keystone_irq_probe()
	warn: unsigned 'kirq->irq' is never less than zero.

drivers/irqchip/irq-keystone.c
164
165 kirq->irq = platform_get_irq(pdev, 0);

   166          if (kirq->irq < 0) {
                    ^^^^^^^^^^^^^

167 dev_err(dev, "no irq resource %d\n", kirq->irq);
168 return kirq->irq;
169 }
170

regards,
dan carpenter