samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
PATCH 1/1 samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
The commit (SHA1: 8fc171318e352) reintroduced correct values for vendor and product IDs required for UMS gadget to work properly either at Windows or Linux.
This data was missing for GONI target, so this commit corrects this mistake.
--- include/configs/s5p_goni.h | 2 ++ 1 file changed, 2 insertions(+)
include/configs/s5p_goni.h +2 -0
@@ -91,6 +91,8 @@#define CONFIG_G_DNL_PRODUCT_NUM 0x6601#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525 +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5#define CONFIG_G_DNL_MANUFACTURER "Samsung"/* Actual modem binary size is 16MiB. Add 2MiB for bad block handling */
Signature · 1 line
2.0.0.rc2
PATCH 1/1 samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
Quoted 17 lines · Lukasz Majewski
The commit (SHA1:
8fc171318e352) reintroduced correct values for vendor and product IDs required for UMS gadget to work properly either at Windows or Linux.This data was missing for GONI target, so this commit corrects this mistake.
Signed-off-by Lukasz Majewski <[email protected]>--- include/configs/s5p_goni.h | 2 ++ 1 file changed, 2 insertions(+)include/configs/s5p_goni.h +0
-0
include/configs/s5p_goni.h line 98
Quoted 8 lines
include/configs/s5p_goni.h +2
-0@@ -91,6 +91,8 @@#define CONFIG_G_DNL_PRODUCT_NUM 0x6601#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525 +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5#define CONFIG_G_DNL_MANUFACTURER "Samsung"/* Actual modem binary size is 16MiB. Add 2MiB for bad block handling */
PATCH 1/1 samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
Hi Tom,
Quoted 25 lines · Lukasz Majewski
Quoted 24 lines
The commit (SHA1:
8fc171318e352) reintroduced correct values for vendor and product IDs required for UMS gadget to work properly either at Windows or Linux.This data was missing for GONI target, so this commit corrects this mistake.
Signed-off-by Lukasz Majewski <[email protected]>--- include/configs/s5p_goni.h | 2 ++ 1 file changed, 2 insertions(+)include/configs/s5p_goni.h +2
-0@@ -91,6 +91,8 @@#define CONFIG_G_DNL_PRODUCT_NUM 0x6601#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525 +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5#define CONFIG_G_DNL_MANUFACTURER "Samsung"
Quoted 5 lines
Quoted 3 lines
include/configs/s5p_goni.h +0
-0/* Actual modem binary size is 16MiB. Add 2MiB for bad block handling */
Acked-by Robert Baldyga <[email protected]>
Tom, since Robert - the maintainer of the GONI board has acked the patch and the patch itself adds only missing defines, could you pull this patch to mainline ASAP?
It fixes build breaks caused by the GONI board :-)
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH 1/1 samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
Quoted 33 lines · Lukasz Majewski
Hi Tom,
Quoted 25 lines · Lukasz Majewski
Quoted 24 lines
The commit (SHA1:
8fc171318e352) reintroduced correct values for vendor and product IDs required for UMS gadget to work properly either at Windows or Linux.This data was missing for GONI target, so this commit corrects this mistake.
Signed-off-by Lukasz Majewski <[email protected]>--- include/configs/s5p_goni.h | 2 ++ 1 file changed, 2 insertions(+)include/configs/s5p_goni.h +2
-0@@ -91,6 +91,8 @@#define CONFIG_G_DNL_PRODUCT_NUM 0x6601#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525 +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5#define CONFIG_G_DNL_MANUFACTURER "Samsung"Quoted 5 lines
Quoted 3 lines
include/configs/s5p_goni.h +0
-0/* Actual modem binary size is 16MiB. Add 2MiB for bad block handling */
Acked-by Robert Baldyga <[email protected]>
Quoted 6 lines
Tom, since Robert - the maintainer of the GONI board has acked the patch and the patch itself adds only missing defines, could you pull this patch to mainline ASAP?
It fixes build breaks caused by the GONI board :-)
If Tom will merge it to mainline then,
Thanks,
Minkyu Kang.
Quoted 9 lines · ?ukasz Majewski
The commit (SHA1:
8fc171318e352) reintroduced correct values for vendor and product IDs required for UMS gadget to work properly either at Windows or Linux.This data was missing for GONI target, so this commit corrects this mistake.
Signed-off-by Lukasz Majewski <[email protected]>Acked-by Robert Baldyga <[email protected]>Acked-by Minkyu Kang <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140828/9ab5e64d/attachment.pgp>