of: Add NVIDIA Tegra Legacy Interrupt Controller binding

PATCH New Thierry Reding 5 participants 17 messages Aug 28, 2014 – Sep 1, 2014

Subsystems (5)

Device tree bindings Arm (32-bit) Arm sub-architectures Tegra architecture support +1 more subsystems

lore

Share & tools

lore

Thierry Reding

author

2014-08-28 15:31 UTC #0 lore raw

PATCH v4 1/5 of: Add NVIDIA Tegra Legacy Interrupt Controller binding

From: Thierry Reding <[email protected]>

The Legacy Interrupt Controller found on NVIDIA Tegra SoCs is used by the AVP coprocessor and can also serve as a backup for the ARM Cortex CPU's local interrupt controller (GIC).

The LIC is subdivided into multiple identical units, each handling 32 possible interrupt sources.

Signed-off-by Thierry Reding <[email protected]>

---
Changes in v3:
- bracket individual tuples in the "reg" property

 .../interrupt-controller/nvidia,tegra20-ictlr.txt     | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/nvidia,tegra20-ictlr.txt

Documentation/devicetree/bindings/interrupt-controller/nvidia,tegra20-ictlr.txt new file +19 -0

new file mode 100644
index 000000000000..1639389b7360
@@ -0,0 +1,19 @@
+NVIDIA Tegra Legacy Interrupt Controller
+
+The legacy interrupt controller is divided into units that serve 32 interrupts
+each. Tegra20 implements four units, whereas Tegra30 and later implement five.
+
+Required properties:
+- compatible: "nvidia,tegra<chip>-ictlr"
+- reg: Physical base address and length of the controller's registers. There
+  should be one entry for each unit.
+
+Example:
+
+	interrupt-controller at 60004000 {
+		compatible = "nvidia,tegra20-ictlr";
+		reg = <0x60004000 0x40>, /* primary controller */
+		      <0x60004100 0x40>, /* secondary controller */
+		      <0x60004200 0x40>, /* tertiary controller */
+		      <0x60004300 0x40>; /* quaternary controller */
+	};

Signature · 1 line

2.0.4

Thierry Reding

author

2014-08-28 15:31 UTC #1 lore raw

PATCH v4 2/5 ARM: tegra: Add legacy interrupt controller nodes

From: Thierry Reding <[email protected]>

Add device tree nodes for the legacy interrupt controller so that the driver can get the register ranges from device tree rather than hard- coding them.

Signed-off-by Thierry Reding <[email protected]>

---
Changes in v3:
- bracket individual tuples in the "reg" property

Changes in v2:
- add chip-specific compatible string
- drop quinary controller on Tegra20

 arch/arm/boot/dts/tegra114.dtsi | 9 +++++++++
 arch/arm/boot/dts/tegra124.dtsi | 9 +++++++++
 arch/arm/boot/dts/tegra20.dtsi  | 8 ++++++++
 arch/arm/boot/dts/tegra30.dtsi  | 9 +++++++++
 4 files changed, 35 insertions(+)

arch/arm/boot/dts/tegra114.dtsi +9 -0

index a147fa2bfdd2..9bfab8bb765a 100644
@@ -141,6 +141,15 @@
 			(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
 	};
 
+	interrupt-controller at 60004000 {
+		compatible = "nvidia,tegra114-ictlr", "nvidia,tegra30-ictlr";
+		reg = <0x60004000 0x40>, /* primary controller */
+		      <0x60004100 0x40>, /* secondary controller */
+		      <0x60004200 0x40>, /* tertiary controller */
+		      <0x60004300 0x40>, /* quaternary controller */
+		      <0x60004400 0x40>; /* quinary controller */
+	};
+
 	timer at 60005000 {
 		compatible = "nvidia,tegra114-timer", "nvidia,tegra20-timer";
 		reg = <0x60005000 0x400>;

arch/arm/boot/dts/tegra124.dtsi +9 -0

index 82dc48b530e6..8c7523225fd9 100644
@@ -190,6 +190,15 @@
 		status = "disabled";
 	};
 
+	interrupt-controller at 0,60004000 {
+		compatible = "nvidia,tegra124-ictlr", "nvidia,tegra30-ictlr";
+		reg = <0x0 0x60004000 0x0 0x40>, /* primary controller */
+		      <0x0 0x60004100 0x0 0x40>, /* secondary controller */
+		      <0x0 0x60004200 0x0 0x40>, /* tertiary controller */
+		      <0x0 0x60004300 0x0 0x40>, /* quaternary controller */
+		      <0x0 0x60004400 0x0 0x40>; /* quinary controller */
+	};
+
 	timer at 0,60005000 {
 		compatible = "nvidia,tegra124-timer", "nvidia,tegra20-timer";
 		reg = <0x0 0x60005000 0x0 0x400>;

arch/arm/boot/dts/tegra20.dtsi +8 -0

index c6a2d078bdf4..fe2f57d19438 100644
@@ -183,6 +183,14 @@
 		cache-level = <2>;
 	};
 
+	interrupt-controller at 60004000 {
+		compatible = "nvidia,tegra20-ictlr";
+		reg = <0x60004000 0x40>, /* primary controller */
+		      <0x60004100 0x40>, /* secondary controller */
+		      <0x60004200 0x40>, /* tertiary controller */
+		      <0x60004300 0x40>; /* quaternary controller */
+	};
+
 	timer at 60005000 {
 		compatible = "nvidia,tegra20-timer";
 		reg = <0x60005000 0x60>;

arch/arm/boot/dts/tegra30.dtsi +9 -0

index f4693c9c070e..e5da2d252220 100644
@@ -262,6 +262,15 @@
 		cache-level = <2>;
 	};
 
+	interrupt-controller at 60004000 {
+		compatible = "nvidia,tegra30-ictlr";
+		reg = <0x60004000 0x40>, /* primary controller */
+		      <0x60004100 0x40>, /* secondary controller */
+		      <0x60004200 0x40>, /* tertiary controller */
+		      <0x60004300 0x40>, /* quaternary controller */
+		      <0x60004400 0x40>; /* quinary controller */
+	};
+
 	timer at 60005000 {
 		compatible = "nvidia,tegra30-timer", "nvidia,tegra20-timer";
 		reg = <0x60005000 0x400>;

Signature · 1 line

2.0.4

Arnd Bergmann

2014-08-28 16:11 UTC #2 lore raw

PATCH v4 2/5 ARM: tegra: Add legacy interrupt controller nodes

arch/arm/boot/dts/tegra114.dtsi line 154

Quoted 12 lines · On Thursday 28 August 2014 17:31:16 Thierry Reding wrote:

arch/arm/boot/dts/tegra114.dtsi +9 -0

+       interrupt-controller at 60004000 {
+               compatible = "nvidia,tegra114-ictlr", "nvidia,tegra30-ictlr";
+               reg = <0x60004000 0x40>, /* primary controller */
+                     <0x60004100 0x40>, /* secondary controller */
+                     <0x60004200 0x40>, /* tertiary controller */
+                     <0x60004300 0x40>, /* quaternary controller */
+                     <0x60004400 0x40>; /* quinary controller */
+       };
+
        timer at 60005000 {
                compatible = "nvidia,tegra114-timer", "nvidia,tegra20-timer";

Don't you need an interrupt-parent and interrupts property here to point to the GIC interrupts? I would assume this is a nested irqchip.

Arnd

Peter De Schrijver

2014-09-01 08:16 UTC #3 lore raw

PATCH v4 2/5 ARM: tegra: Add legacy interrupt controller nodes

Quoted 14 lines · Arnd Bergmann

arch/arm/boot/dts/tegra114.dtsi line 154

Quoted 12 lines · On Thursday 28 August 2014 17:31:16 Thierry Reding wrote:

arch/arm/boot/dts/tegra114.dtsi +9 -0

+       interrupt-controller at 60004000 {
+               compatible = "nvidia,tegra114-ictlr", "nvidia,tegra30-ictlr";
+               reg = <0x60004000 0x40>, /* primary controller */
+                     <0x60004100 0x40>, /* secondary controller */
+                     <0x60004200 0x40>, /* tertiary controller */
+                     <0x60004300 0x40>, /* quaternary controller */
+                     <0x60004400 0x40>; /* quinary controller */
+       };
+
        timer at 60005000 {
                compatible = "nvidia,tegra114-timer", "nvidia,tegra20-timer";

Quoted 2 lines

Don't you need an interrupt-parent and interrupts property here to point to the GIC interrupts? I would assume this is a nested irqchip.

No. It's not nested. All SoC interrupts are fed into both the LIC and the GIC (as SPIs). The LIC also has an interface towards the flowcontroller which allows waking up the CPU when an interrupt happens, even if the GIC is off. LIC can also route every interrupt it controls to the AVP.

See also section 3.4.1.4 Interrupt routing of the TRM.

Cheers,

Peter.

Thierry Reding

author

2014-08-28 15:31 UTC #4 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

In reply to Thierry Reding

From: Thierry Reding <[email protected]>

Obtains the register ranges for the legacy interrupt controller from DT and provide hard-coded values as fallback.

Signed-off-by Thierry Reding <[email protected]>

---
Changes in v4:
- check for Tegra20 in non-DT fallback using of_machine_is_compatible()
- cleanup warning messages

Changes in v3:
- fixup subject prefix

Changes in v2:
- check for the exact number of controllers expected
- fallback to tegra_chip_id for non-DT
- warn on parsing errors

 arch/arm/mach-tegra/iomap.h |  18 -------
 arch/arm/mach-tegra/irq.c   | 122 ++++++++++++++++++++++++++++++++++++--------
 2 files changed, 101 insertions(+), 39 deletions(-)

arch/arm/mach-tegra/iomap.h +0 ~~-18~~

index ee79808e93a3..52bbb5c8fe84 100644
@@ -28,24 +28,6 @@
 #define TEGRA_ARM_PERIF_BASE		0x50040000
 #define TEGRA_ARM_PERIF_SIZE		SZ_8K
 
-#define TEGRA_ARM_INT_DIST_BASE		0x50041000
-#define TEGRA_ARM_INT_DIST_SIZE		SZ_4K
-
-#define TEGRA_PRIMARY_ICTLR_BASE	0x60004000
-#define TEGRA_PRIMARY_ICTLR_SIZE	SZ_64
-
-#define TEGRA_SECONDARY_ICTLR_BASE	0x60004100
-#define TEGRA_SECONDARY_ICTLR_SIZE	SZ_64
-
-#define TEGRA_TERTIARY_ICTLR_BASE	0x60004200
-#define TEGRA_TERTIARY_ICTLR_SIZE	SZ_64
-
-#define TEGRA_QUATERNARY_ICTLR_BASE	0x60004300
-#define TEGRA_QUATERNARY_ICTLR_SIZE	SZ_64
-
-#define TEGRA_QUINARY_ICTLR_BASE	0x60004400
-#define TEGRA_QUINARY_ICTLR_SIZE	SZ_64
-
 #define TEGRA_TMR1_BASE			0x60005000
 #define TEGRA_TMR1_SIZE			SZ_8

arch/arm/mach-tegra/irq.c +101 ~~-21~~

165 lines not on this page · raw message

Signature · 1 line

2.0.4

Arnd Bergmann

2014-08-28 16:10 UTC #5 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 29 lines · On Thursday 28 August 2014 17:31:17 Thierry Reding wrote:

void __init tegra_init_irq(void)
{

arch/arm/mach-tegra/irq.c +25 -2

-	int i;
-	void __iomem *distbase;
+	unsigned int max_ictlrs = ARRAY_SIZE(ictlr_regs), i;
+	const struct of_device_id *match;
+	struct device_node *np;
+	struct resource res;
+
+	np = of_find_matching_node_and_match(NULL, ictlr_matches, &match);
+	if (np) {
+		const struct tegra_ictlr_soc *soc = match->data;
+
+		for (i = 0; i < soc->num_ictlrs; i++) {
+			if (of_address_to_resource(np, i, &res) < 0)
+				break;
+
+			ictlr_regs[i] = res;
+		}
+
+		WARN(i != soc->num_ictlrs,
+		     "Found %u interrupt controllers in DT; expected %u.\n",
+		     i, soc->num_ictlrs);
+
+		max_ictlrs = soc->num_ictlrs;
+		of_node_put(np);
+	} else {
+		/*
+		 * If no matching device node was found, fall back to using

arch/arm/mach-tegra/irq.c static void tegra114_gic_cpu_pm_registration(void) · line 320

Quoted 10 lines

arch/arm/mach-tegra/irq.c +10 -0

+		 * the chip ID.
+		 */
+
+		/* Tegra30 and later have five interrupt controllers, ... */
+		max_ictlrs = ARRAY_SIZE(ictlr_regs);
+
+		/* ..., but Tegra20 only has four. */
+		if (of_machine_is_compatible("nvidia,tegra20"))
+			max_ictlrs--;
+	}

How about moving the entire file to drivers/irqchip and using the IRQCHIP_DECLARE() helper for the DT case?

For the fallback, you can have an entry into that file that just takes the address and number, which you can call from platform code here.

Arnd

Thierry Reding

author

2014-08-29 07:31 UTC #6 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 45 lines · Arnd Bergmann

Quoted 29 lines · On Thursday 28 August 2014 17:31:17 Thierry Reding wrote:

void __init tegra_init_irq(void)
{

arch/arm/mach-tegra/irq.c +25 -2

-	int i;
-	void __iomem *distbase;
+	unsigned int max_ictlrs = ARRAY_SIZE(ictlr_regs), i;
+	const struct of_device_id *match;
+	struct device_node *np;
+	struct resource res;
+
+	np = of_find_matching_node_and_match(NULL, ictlr_matches, &match);
+	if (np) {
+		const struct tegra_ictlr_soc *soc = match->data;
+
+		for (i = 0; i < soc->num_ictlrs; i++) {
+			if (of_address_to_resource(np, i, &res) < 0)
+				break;
+
+			ictlr_regs[i] = res;
+		}
+
+		WARN(i != soc->num_ictlrs,
+		     "Found %u interrupt controllers in DT; expected %u.\n",
+		     i, soc->num_ictlrs);
+
+		max_ictlrs = soc->num_ictlrs;
+		of_node_put(np);
+	} else {
+		/*
+		 * If no matching device node was found, fall back to using

arch/arm/mach-tegra/irq.c static void tegra114_gic_cpu_pm_registration(void) · line 320

Quoted 10 lines

arch/arm/mach-tegra/irq.c +10 -0

+		 * the chip ID.
+		 */
+
+		/* Tegra30 and later have five interrupt controllers, ... */
+		max_ictlrs = ARRAY_SIZE(ictlr_regs);
+
+		/* ..., but Tegra20 only has four. */
+		if (of_machine_is_compatible("nvidia,tegra20"))
+			max_ictlrs--;
+	}

How about moving the entire file to drivers/irqchip and using the IRQCHIP_DECLARE() helper for the DT case?

Quoted 2 lines

For the fallback, you can have an entry into that file that just takes the address and number, which you can call from platform code here.

I think I did try that at some point, but there were issues that I don't remember. I'll give it another shot.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140829/6793f259/attachment.sig>

Thierry Reding

author

2014-08-29 14:24 UTC #7 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 46 lines · Thierry Reding

Quoted 45 lines · Arnd Bergmann

Quoted 29 lines · On Thursday 28 August 2014 17:31:17 Thierry Reding wrote:

void __init tegra_init_irq(void)
{

arch/arm/mach-tegra/irq.c +25 -2

-	int i;
-	void __iomem *distbase;
+	unsigned int max_ictlrs = ARRAY_SIZE(ictlr_regs), i;
+	const struct of_device_id *match;
+	struct device_node *np;
+	struct resource res;
+
+	np = of_find_matching_node_and_match(NULL, ictlr_matches, &match);
+	if (np) {
+		const struct tegra_ictlr_soc *soc = match->data;
+
+		for (i = 0; i < soc->num_ictlrs; i++) {
+			if (of_address_to_resource(np, i, &res) < 0)
+				break;
+
+			ictlr_regs[i] = res;
+		}
+
+		WARN(i != soc->num_ictlrs,
+		     "Found %u interrupt controllers in DT; expected %u.\n",
+		     i, soc->num_ictlrs);
+
+		max_ictlrs = soc->num_ictlrs;
+		of_node_put(np);
+	} else {
+		/*
+		 * If no matching device node was found, fall back to using

arch/arm/mach-tegra/irq.c static void tegra114_gic_cpu_pm_registration(void) · line 320

Quoted 10 lines

arch/arm/mach-tegra/irq.c +10 -0

+		 * the chip ID.
+		 */
+
+		/* Tegra30 and later have five interrupt controllers, ... */
+		max_ictlrs = ARRAY_SIZE(ictlr_regs);
+
+		/* ..., but Tegra20 only has four. */
+		if (of_machine_is_compatible("nvidia,tegra20"))
+			max_ictlrs--;
+	}

How about moving the entire file to drivers/irqchip and using the IRQCHIP_DECLARE() helper for the DT case?

Quoted 5 lines

Quoted 2 lines
For the fallback, you can have an entry into that file that just takes the address and number, which you can call from platform code here.
I think I did try that at some point, but there were issues that I don't remember. I'll give it another shot.

So I got pretty far with this and the system still boots. But for some reason suspend/resume is now broken. The difference seems to be that earlier the legacy interrupt controller would be registered first, and the GIC second. When the legacy interrupt controller is initialized after the GIC (which happens when I use IRQCHIP_DECLARE), then suspend and resume won't work (for some yet unknown reason). Unfortunately the of_irq_init() code is too clever, so I can't even work around it by changing link order or device tree order.

I'll see if I can find out what causes this combination to malfunction when initialized in the opposite order.

Thierry Reding

author

2014-08-29 15:04 UTC #8 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 62 lines · Thierry Reding

Quoted 46 lines · Thierry Reding
Quoted 45 lines · Arnd Bergmann
Quoted 29 lines · On Thursday 28 August 2014 17:31:17 Thierry Reding wrote:
void __init tegra_init_irq(void)
{
arch/arm/mach-tegra/irq.c +25 -2
-	int i;
-	void __iomem *distbase;
+	unsigned int max_ictlrs = ARRAY_SIZE(ictlr_regs), i;
+	const struct of_device_id *match;
+	struct device_node *np;
+	struct resource res;
+
+	np = of_find_matching_node_and_match(NULL, ictlr_matches, &match);
+	if (np) {
+		const struct tegra_ictlr_soc *soc = match->data;
+
+		for (i = 0; i < soc->num_ictlrs; i++) {
+			if (of_address_to_resource(np, i, &res) < 0)
+				break;
+
+			ictlr_regs[i] = res;
+		}
+
+		WARN(i != soc->num_ictlrs,
+		     "Found %u interrupt controllers in DT; expected %u.\n",
+		     i, soc->num_ictlrs);
+
+		max_ictlrs = soc->num_ictlrs;
+		of_node_put(np);
+	} else {
+		/*
+		 * If no matching device node was found, fall back to using
arch/arm/mach-tegra/irq.c static void tegra114_gic_cpu_pm_registration(void) · line 320
Quoted 10 lines
arch/arm/mach-tegra/irq.c +10 -0
+		 * the chip ID.
+		 */
+
+		/* Tegra30 and later have five interrupt controllers, ... */
+		max_ictlrs = ARRAY_SIZE(ictlr_regs);
+
+		/* ..., but Tegra20 only has four. */
+		if (of_machine_is_compatible("nvidia,tegra20"))
+			max_ictlrs--;
+	}
How about moving the entire file to drivers/irqchip and using the IRQCHIP_DECLARE() helper for the DT case?
Quoted 5 lines
Quoted 2 lines
For the fallback, you can have an entry into that file that just takes the address and number, which you can call from platform code here.
I think I did try that at some point, but there were issues that I don't remember. I'll give it another shot.
So I got pretty far with this and the system still boots. But for some reason suspend/resume is now broken. The difference seems to be that earlier the legacy interrupt controller would be registered first, and the GIC second. When the legacy interrupt controller is initialized after the GIC (which happens when I use IRQCHIP_DECLARE), then suspend and resume won't work (for some yet unknown reason). Unfortunately the of_irq_init() code is too clever, so I can't even work around it by changing link order or device tree order.

Quoted 2 lines

I'll see if I can find out what causes this combination to malfunction when initialized in the opposite order.

The reason for why ordering matters is this line from the GIC driver (see drivers/irqchip/irq-gic.c):

	static int gic_init_bases(...)
	{
		...
		gic_chip.flags |= gic_arch_extn.flags;
		...
	}

So there's an implicit dependency on having the architecture-specific extension initialized before the GIC.

If I manually add in the flags set by the LIC (IRQCHIP_MASK_ON_SUSPEND) the suspend/resume issue that I observed goes away.

Perhaps a better way to handle this would be to add an API that GIC IRQ extensions can use to register with the GIC independent of the initialization order?

In this particular case something like:

	void gic_arch_register(unsigned long flags)
	{
		gic_chip.flags |= flags;
	}

would work irrespective of the ordering. But perhaps something more elaborate would be more futureproof:

	void gic_arch_register(const struct irqchip *extn)
	{
		gic_chip.flags |= extn->flags;
		gic_arch_extn = *extn;
	}

Or perhaps gic_arch_extn could be turned into a pointer so that checks for already registered extension drivers can be more easily done. That is:

	static struct irq_chip *extn;

	void gic_arch_register(const struct irqchip *chip)
	{
		if (WARN(extn != NULL))
			return;

		gic_chip.flags |= chip->flags;
		extn = chip;
	}

Any preferences, or other ideas? Adding Thomas and Jason, perhaps they can provide more input on how to solve this.

Arnd Bergmann

2014-08-29 19:53 UTC #9 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 11 lines · On Friday 29 August 2014 17:04:28 Thierry Reding wrote:

        static struct irq_chip *extn;

        void gic_arch_register(const struct irqchip *chip)
        {
                if (WARN(extn != NULL))
                        return;

                gic_chip.flags |= chip->flags;
                extn = chip;
        }

Quoted 2 lines

Any preferences, or other ideas? Adding Thomas and Jason, perhaps they can provide more input on how to solve this.

I think the entire gic_arch_extn method is done in a rather odd way and we should try to come up with a replacement.

These are the users at the moment:

arch/arm/mach-exynos/pm.c:      gic_arch_extn.irq_set_wake = exynos_irq_set_wake;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_mask = imx_gpc_irq_mask;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_unmask = imx_gpc_irq_unmask;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_set_wake = imx_gpc_irq_set_wake;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.irq_mask = wakeupgen_mask;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.irq_unmask = wakeupgen_unmask;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_W
arch/arm/mach-shmobile/intc-sh73a0.c:   gic_arch_extn.irq_set_wake = sh73a0_set_wake;
arch/arm/mach-shmobile/setup-r8a7779.c: gic_arch_extn.irq_set_wake = r8a7779_set_wake;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_ack = tegra_ack;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_eoi = tegra_eoi;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_mask = tegra_mask;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_unmask = tegra_unmask;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_retrigger = tegra_retrigger;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_set_wake = tegra_set_wake;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND;
arch/arm/mach-ux500/cpu.c:      gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
arch/arm/mach-zynq/common.c:    gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;

I have to admit I don't really understand how these work, but what I'd expect to work better is a way to turn the gic code into more of a library that can be used by specialized drivers. In that case you would register a driver for the tegra gic using IRQCHIP_DECLARE and that driver would call a variation of gic_of_init() or gic_init_bases() with the extra stuff as arguments.

We'd have to hack around the fact that all these platforms currently don't list a specialized compatible string, but at least for the future we should be able to do this without special hacks.

Arnd

Jason Cooper

2014-08-30 15:54 UTC #10 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Arnd,

Quoted 46 lines · Arnd Bergmann

Quoted 11 lines · On Friday 29 August 2014 17:04:28 Thierry Reding wrote:

        static struct irq_chip *extn;

        void gic_arch_register(const struct irqchip *chip)
        {
                if (WARN(extn != NULL))
                        return;

                gic_chip.flags |= chip->flags;
                extn = chip;
        }

Quoted 2 lines

Any preferences, or other ideas? Adding Thomas and Jason, perhaps they can provide more input on how to solve this.

I think the entire gic_arch_extn method is done in a rather odd way and we should try to come up with a replacement.

These are the users at the moment:

arch/arm/mach-exynos/pm.c:      gic_arch_extn.irq_set_wake = exynos_irq_set_wake;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_mask = imx_gpc_irq_mask;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_unmask = imx_gpc_irq_unmask;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_set_wake = imx_gpc_irq_set_wake;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.irq_mask = wakeupgen_mask;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.irq_unmask = wakeupgen_unmask;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_W
arch/arm/mach-shmobile/intc-sh73a0.c:   gic_arch_extn.irq_set_wake = sh73a0_set_wake;
arch/arm/mach-shmobile/setup-r8a7779.c: gic_arch_extn.irq_set_wake = r8a7779_set_wake;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_ack = tegra_ack;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_eoi = tegra_eoi;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_mask = tegra_mask;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_unmask = tegra_unmask;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_retrigger = tegra_retrigger;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_set_wake = tegra_set_wake;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND;
arch/arm/mach-ux500/cpu.c:      gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
arch/arm/mach-zynq/common.c:    gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;

Quoted 3 lines

We'd have to hack around the fact that all these platforms currently don't list a specialized compatible string, but at least for the future we should be able to do this without special hacks.

Thomas was talking about this just the other day:

https://lkml.kernel.org/r/alpine.DEB.2.10.1408271347210.3323 at nanos

thx,

Jason.

Arnd Bergmann

2014-09-01 08:45 UTC #11 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 7 lines · On Saturday 30 August 2014 11:54:59 Jason Cooper wrote:

Quoted 7 lines
I have to admit I don't really understand how these work, but what I'd expect to work better is a way to turn the gic code into more of a library that can be used by specialized drivers. In that case you would register a driver for the tegra gic using IRQCHIP_DECLARE and that driver would call a variation of gic_of_init() or gic_init_bases() with the extra stuff as arguments.

Quoted 7 lines

Quoted 3 lines
We'd have to hack around the fact that all these platforms currently don't list a specialized compatible string, but at least for the future we should be able to do this without special hacks.
Thomas was talking about this just the other day:
https://lkml.kernel.org/r/alpine.DEB.2.10.1408271347210.3323 at nanos

Ah, cool. That seems better than what I had in mind. Yes, let's do that.

Arnd

Thierry Reding

author

2014-09-01 08:47 UTC #12 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

In reply to Arnd Bergmann

Quoted 46 lines · Arnd Bergmann

Quoted 11 lines · On Friday 29 August 2014 17:04:28 Thierry Reding wrote:

        static struct irq_chip *extn;

        void gic_arch_register(const struct irqchip *chip)
        {
                if (WARN(extn != NULL))
                        return;

                gic_chip.flags |= chip->flags;
                extn = chip;
        }

Quoted 2 lines

Any preferences, or other ideas? Adding Thomas and Jason, perhaps they can provide more input on how to solve this.

I think the entire gic_arch_extn method is done in a rather odd way and we should try to come up with a replacement.

These are the users at the moment:

arch/arm/mach-exynos/pm.c:      gic_arch_extn.irq_set_wake = exynos_irq_set_wake;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_mask = imx_gpc_irq_mask;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_unmask = imx_gpc_irq_unmask;
arch/arm/mach-imx/gpc.c:        gic_arch_extn.irq_set_wake = imx_gpc_irq_set_wake;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.irq_mask = wakeupgen_mask;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.irq_unmask = wakeupgen_unmask;
arch/arm/mach-omap2/omap-wakeupgen.c:   gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_W
arch/arm/mach-shmobile/intc-sh73a0.c:   gic_arch_extn.irq_set_wake = sh73a0_set_wake;
arch/arm/mach-shmobile/setup-r8a7779.c: gic_arch_extn.irq_set_wake = r8a7779_set_wake;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_ack = tegra_ack;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_eoi = tegra_eoi;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_mask = tegra_mask;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_unmask = tegra_unmask;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_retrigger = tegra_retrigger;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.irq_set_wake = tegra_set_wake;
arch/arm/mach-tegra/irq.c:      gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND;
arch/arm/mach-ux500/cpu.c:      gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
arch/arm/mach-zynq/common.c:    gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;

Quoted 3 lines

We'd have to hack around the fact that all these platforms currently don't list a specialized compatible string, but at least for the future we should be able to do this without special hacks.

Besides the issue with the missing compatible values, the hardware blocks that provide the additional functionality are separate from the GIC. So they would have to look up the GIC node explicitly.

I suppose that might actually be to our advantage, since these blocks will presumably have a specialized compatible string. So perhaps one solution would be to make the drivers for these separate IP blocks look up the GIC device tree node and call gic_of_init_ext() with a pointer to the IRQ chip implementation of this platform-specific glue to replace gic_arch_extn.

Varka Bhadram

2014-08-29 03:27 UTC #13 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

In reply to Thierry Reding

Quoted 5 lines · Thierry Reding

From: Thierry Reding <[email protected]>
Obtains the register ranges for the legacy interrupt controller from DT and provide hard-coded values as fallback.

(...)

Quoted 7 lines

arch/arm/mach-tegra/irq.c +6 -0

+static const struct tegra_ictlr_soc tegra30_ictlr_soc = {
+	.num_ictlrs = 5,
+};
+
+static const struct of_device_id ictlr_matches[] = {
+	{ .compatible = "nvidia,tegra30-ictlr", .data = &tegra30_ictlr_soc },

arch/arm/mach-tegra/irq.c static void tegra114_gic_cpu_pm_registration(void) · line 283

Quoted 10 lines

arch/arm/mach-tegra/irq.c +10 -0

+	{ .compatible = "nvidia,tegra20-ictlr", .data = &tegra20_ictlr_soc },
+	{ }
+};
+
+static const struct of_device_id gic_matches[] = {
+	{ .compatible = "arm,cortex-a15-gic", },
+	{ .compatible = "arm,cortex-a9-gic", },
+	{ }
+};
+

Missed MODULE_DEVICE_TABLE(of, ...)....?

Signature · 2 lines

Regards,
Varka Bhadram.

Thierry Reding

author

2014-08-29 07:29 UTC #14 lore raw

PATCH v4 3/5 ARM: tegra: Initialize interrupt controller from DT

Quoted 18 lines · Varka Bhadram

Quoted 5 lines · Thierry Reding
From: Thierry Reding <[email protected]>
Obtains the register ranges for the legacy interrupt controller from DT and provide hard-coded values as fallback.
(...)
Quoted 10 lines
arch/arm/mach-tegra/irq.c +10 -0
+static const struct tegra_ictlr_soc tegra30_ictlr_soc = {
+	.num_ictlrs = 5,
+};
+
+static const struct of_device_id ictlr_matches[] = {
+	{ .compatible = "nvidia,tegra30-ictlr", .data = &tegra30_ictlr_soc },
+	{ .compatible = "nvidia,tegra20-ictlr", .data = &tegra20_ictlr_soc },
+	{ }
+};
+

Quoted 8 lines

arch/arm/mach-tegra/irq.c static void tegra114_gic_cpu_pm_registration(void) · line 283
Quoted 7 lines
arch/arm/mach-tegra/irq.c +6 -0
+static const struct of_device_id gic_matches[] = {
+	{ .compatible = "arm,cortex-a15-gic", },
+	{ .compatible = "arm,cortex-a9-gic", },
+	{ }
+};
+
Missed MODULE_DEVICE_TABLE(of, ...)....?

The driver isn't useful as a module, so I don't think that's necessary. I'm not even sure it could be loaded that late in the process. Without it peripheral interrupts don't work properly, so loading this from the filesystem doesn't work (unless it's in an initrd), but perhaps even that won't work. I'm not aware of anyone actually ever trying to build it as a module.

Thierry Reding

author

2014-08-28 15:31 UTC #15 lore raw

PATCH v4 4/5 ARM: tegra: Remove unused GIC initialization

In reply to Thierry Reding

From: Thierry Reding <[email protected]>

Tegra has been booting from DT exclusively for quite some time, so this old code setting up the GIC for non-DT boot is unused and can therefore be removed.

Signed-off-by Thierry Reding <[email protected]>

---
 arch/arm/mach-tegra/irq.c | 9 ---------
 1 file changed, 9 deletions(-)

arch/arm/mach-tegra/irq.c +0 -9

index 636ebfd466cb..b1760aa162f1 100644
@@ -362,14 +362,5 @@ void __init tegra_init_irq(void)
 	gic_arch_extn.irq_set_wake = tegra_set_wake;
 	gic_arch_extn.flags = IRQCHIP_MASK_ON_SUSPEND;
 
-	/*
-	 * Check if there is a devicetree present, since the GIC will be
-	 * initialized elsewhere under DT.
-	 */
-	if (!of_have_populated_dt()) {
-		void __iomem *cpubase = ioremap_nocache(0x50040000, 0x2000);
-		gic_init(0, 29, distbase, cpubase);
-	}
-
 	tegra114_gic_cpu_pm_registration();
 }

Signature · 1 line

2.0.4

Thierry Reding

author

2014-08-28 15:31 UTC #16 lore raw

PATCH v4 5/5 ARM: tegra: Remove unused defines

In reply to Thierry Reding

From: Thierry Reding <[email protected]>

Eventually the aim is to get rid of this file because it cannot be built on ARM64. Until it can be completely removed, eliminate unused entries to make it easier to see which are still used.

Reviewed-by Stephen Warren <[email protected]>

Signed-off-by Thierry Reding <[email protected]>

---
Changes in v3:
- fixup subject prefix

 arch/arm/mach-tegra/iomap.h | 30 ------------------------------
 1 file changed, 30 deletions(-)

arch/arm/mach-tegra/iomap.h +0 ~~-30~~

index 52bbb5c8fe84..c2fd86a9b43f 100644
@@ -28,21 +28,9 @@
 #define TEGRA_ARM_PERIF_BASE		0x50040000
 #define TEGRA_ARM_PERIF_SIZE		SZ_8K
 
-#define TEGRA_TMR1_BASE			0x60005000
-#define TEGRA_TMR1_SIZE			SZ_8
-
-#define TEGRA_TMR2_BASE			0x60005008
-#define TEGRA_TMR2_SIZE			SZ_8
-
 #define TEGRA_TMRUS_BASE		0x60005010
 #define TEGRA_TMRUS_SIZE		SZ_64
 
-#define TEGRA_TMR3_BASE			0x60005050
-#define TEGRA_TMR3_SIZE			SZ_8
-
-#define TEGRA_TMR4_BASE			0x60005058
-#define TEGRA_TMR4_SIZE			SZ_8
-
 #define TEGRA_CLK_RESET_BASE		0x60006000
 #define TEGRA_CLK_RESET_SIZE		SZ_4K

@@ -58,21 +46,6 @@
 #define TEGRA_APB_MISC_BASE		0x70000000
 #define TEGRA_APB_MISC_SIZE		SZ_4K
 
-#define TEGRA_UARTA_BASE		0x70006000
-#define TEGRA_UARTA_SIZE		SZ_64
-
-#define TEGRA_UARTB_BASE		0x70006040
-#define TEGRA_UARTB_SIZE		SZ_64
-
-#define TEGRA_UARTC_BASE		0x70006200
-#define TEGRA_UARTC_SIZE		SZ_256
-
-#define TEGRA_UARTD_BASE		0x70006300
-#define TEGRA_UARTD_SIZE		SZ_256
-
-#define TEGRA_UARTE_BASE		0x70006400
-#define TEGRA_UARTE_SIZE		SZ_256
-
 #define TEGRA_PMC_BASE			0x7000E400
 #define TEGRA_PMC_SIZE			SZ_256

@@ -91,9 +64,6 @@
 #define TEGRA124_EMC_BASE		0x7001B000
 #define TEGRA124_EMC_SIZE		SZ_2K
 
-#define TEGRA_CSITE_BASE		0x70040000
-#define TEGRA_CSITE_SIZE		SZ_256K
-
 /* On TEGRA, many peripherals are very closely packed in
  * two 256MB io windows (that actually only use about 64KB
  * at the start of each).

Signature · 1 line

2.0.4