gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

PATCH In review Axel Lin 3 participants 7 messages Aug 3, 2014 – Sep 2, 2014

Subsystems (2)

DRM drivers DRM drivers for Freescale i.MX 5/6

lore

Share & tools

lore

Axel Lin

author

2014-08-03 02:37 UTC #0 lore raw

PATCH 1/2 gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to avoid build error.

Fixes below build errors:
ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Signed-off-by Axel Lin <[email protected]>

---
 drivers/gpu/ipu-v3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

drivers/gpu/ipu-v3/Kconfig +1 -0

index 2f228a2..01864a5 100644
@@ -2,6 +2,7 @@ config IMX_IPUV3_CORE
 	tristate "IPUv3 core support"
 	depends on SOC_IMX5 || SOC_IMX6Q || SOC_IMX6SL || ARCH_MULTIPLATFORM
 	depends on RESET_CONTROLLER
+	select GENERIC_IRQ_CHIP
 	help
 	  Choose this if you have a i.MX5/6 system and want to use the Image
 	  Processing Unit. This option only enables IPU base support.

Signature · 1 line

1.9.1

Axel Lin

author

2014-08-03 02:38 UTC #1 lore raw

PATCH 2/2 gpu: ipu-v3: Return proper error on ipu_add_client_devices error path

Signed-off-by Axel Lin <[email protected]>

---
 drivers/gpu/ipu-v3/ipu-common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/gpu/ipu-v3/ipu-common.c +3 -1

index 04e7b2e..e340beb 100644
@@ -1116,8 +1116,10 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base)
 				id++, &reg->pdata, sizeof(reg->pdata));
 		}
 
-		if (IS_ERR(pdev))
+		if (IS_ERR(pdev)) {
+			ret = PTR_ERR(pdev);
 			goto err_register;
+		}
 	}
 
 	return 0;

Signature · 1 line

1.9.1

Axel Lin

author

2014-09-02 01:47 UTC #2 lore raw

In reply to Axel Lin

2014-08-03 10:36 GMT+08:00 Axel Lin <[email protected]>:

Quoted 12 lines

This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to avoid build error.
Fixes below build errors:
ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Hi Greg,

I still hit this build error in today's linuex-next tree with below config:
ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL

This driver just moved from staging to gpu. So it's not clear to me who will pick up this patch. Can you pick up this patch?

Thanks,
Axel

Greg Kroah-Hartman

2014-09-02 02:11 UTC #3 lore raw

Quoted 14 lines · Axel Lin

2014-08-03 10:36 GMT+08:00 Axel Lin <[email protected]>:
Quoted 12 lines
This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to avoid build error.
Fixes below build errors:
ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Quoted 8 lines

Hi Greg,
I still hit this build error in today's linuex-next tree with below config:
ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
This driver just moved from staging to gpu. So it's not clear to me who will pick up this patch. Can you pick up this patch?

As the code isn't in the staging tree, why shouldn't it go through the drivers/gpu/* maintainer?

thanks,

greg k-h

Axel Lin

author

2014-09-02 02:25 UTC #4 lore raw

2014-09-02 10:11 GMT+08:00 Greg Kroah-Hartman <[email protected]>:

Quoted 20 lines · Axel Lin

Quoted 19 lines
2014-08-03 10:36 GMT+08:00 Axel Lin <[email protected]>:
Quoted 12 lines
This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to avoid build error.
Fixes below build errors:
ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Hi Greg,
I still hit this build error in today's linuex-next tree with below config:
ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL

Quoted 6 lines

Quoted 3 lines
This driver just moved from staging to gpu. So it's not clear to me who will pick up this patch. Can you pick up this patch?
As the code isn't in the staging tree, why shouldn't it go through the drivers/gpu/* maintainer?

scripts/get_maintainer.pl sent/0001-gpu-ipu-v3-select-GENERIC_IRQ_CHIP-to-fix-build-erro.patch Greg Kroah-Hartman <[email protected]> (commit_signer:1/1=100%) Lucas Stach <[email protected]> (commit_signer:1/1=100%) Philipp Zabel <[email protected]> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:7/7=100%) [email protected] (open list)

I checked the MAINTAINERS file,
I can only find the maintainer for some subfolders of drivers/gpu but no entry for drivers/gpu/ipu-v3.
So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.

Thanks,
Axel

Greg Kroah-Hartman

2014-09-02 03:29 UTC #5 lore raw

Quoted 36 lines · Axel Lin

2014-09-02 10:11 GMT+08:00 Greg Kroah-Hartman <[email protected]>:
Quoted 20 lines · Axel Lin
Quoted 19 lines
2014-08-03 10:36 GMT+08:00 Axel Lin <[email protected]>:
Quoted 12 lines
This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to avoid build error.
Fixes below build errors:
ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Hi Greg,
I still hit this build error in today's linuex-next tree with below config:
ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
Quoted 6 lines
Quoted 3 lines
This driver just moved from staging to gpu. So it's not clear to me who will pick up this patch. Can you pick up this patch?
As the code isn't in the staging tree, why shouldn't it go through the drivers/gpu/* maintainer?
scripts/get_maintainer.pl sent/0001-gpu-ipu-v3-select-GENERIC_IRQ_CHIP-to-fix-build-erro.patch Greg Kroah-Hartman <[email protected]> (commit_signer:1/1=100%) Lucas Stach <[email protected]> (commit_signer:1/1=100%) Philipp Zabel <[email protected]> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:7/7=100%) [email protected] (open list)

Quoted 4 lines

I checked the MAINTAINERS file,
I can only find the maintainer for some subfolders of drivers/gpu but no entry for drivers/gpu/ipu-v3.
So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.

Who moved the file out of staging? I don't think it was me...

I think it is Philipp, who sent the patches through the drm tree, so try those developers.

thanks,

greg k-h

Philipp Zabel

maintainer

2014-09-02 09:15 UTC #6 lore raw

Hi,

Am Montag, den 01.09.2014, 20:28 -0700 schrieb Greg Kroah-Hartman:
[...]

Quoted 9 lines

Quoted 4 lines
I checked the MAINTAINERS file,
I can only find the maintainer for some subfolders of drivers/gpu but no entry for drivers/gpu/ipu-v3.
So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.
Who moved the file out of staging? I don't think it was me...
I think it is Philipp, who sent the patches through the drm tree, so try those developers.

I'll collect gpu/ipu-v3 patches and send them on.
I've pushed this patch to:

git://git.pengutronix.de/git/pza/linux.git topic/ipu-fixes

regards
Philipp