Skip to contentSkip to conversation

ARM: ux500: disable msp2 node on Snowball

PATCH New Linus Walleij 3 participants 3 messages Sep 2, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: ux500: disable msp2 node on Snowball

Analogous to commit 8858d88a25142544843869f0cd3e6654aa7b4aec that fixed commit 70b41abc151f9
"ARM: ux500: move MSP pin control to the device tree" accidentally activated MSP2, giving rise to a boot scroll scream as the kernel attempts to probe a driver for it and fails to obtain DMA channel 14.

For some reason I forgot to fix this on the Snowball. Fix this up by marking the node disabled again.

---
ARM SoC folks: please apply this patch directly to fixes for v3.17, I have no other pending Ux500 fixes.

---
 arch/arm/boot/dts/ste-snowball.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/ste-snowball.dts +0 -1
index 4a2000c620ad..3e97a669f15e 100644
@@ -116,7 +116,6 @@
 		msp2: msp at 80117000 {
 			pinctrl-names = "default";
 			pinctrl-0 = <&msp2_default_mode>;
-			status = "okay";
 		};
 
 		msp3: msp at 80125000 {
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 ARM: ux500: disable msp2 node on Snowball

Quoted 10 lines · Linus Walleij

Analogous to commit 8858d88a25142544843869f0cd3e6654aa7b4aec that fixed commit 70b41abc151f9
"ARM: ux500: move MSP pin control to the device tree" accidentally activated MSP2, giving rise to a boot scroll scream as the kernel attempts to probe a driver for it and fails to obtain DMA channel 14.

For some reason I forgot to fix this on the Snowball. Fix this up by marking the node disabled again.

Quoted 8 lines

---
ARM SoC folks: please apply this patch directly to fixes for v3.17, I have no other pending Ux500 fixes.

---
 arch/arm/boot/dts/ste-snowball.dts | 1 -
 1 file changed, 1 deletion(-)

Ah I see. You fixed the HREF back in Feb, but I guess Snowball didn't benefit from it.

Quoted 12 lines
arch/arm/boot/dts/ste-snowball.dts +0 -1
index 4a2000c620ad..3e97a669f15e 100644
@@ -116,7 +116,6 @@
 		msp2: msp at 80117000 {
 			pinctrl-names = "default";
 			pinctrl-0 = <&msp2_default_mode>;
-			status = "okay";
 		};
 
 		msp3: msp at 80125000 {
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw

PATCH 1/1 ARM: ux500: disable msp2 node on Snowball

In reply to Linus Walleij
Quoted 7 lines · Linus Walleij

Analogous to commit 8858d88a25142544843869f0cd3e6654aa7b4aec that fixed commit 70b41abc151f9
"ARM: ux500: move MSP pin control to the device tree" accidentally activated MSP2, giving rise to a boot scroll scream as the kernel attempts to probe a driver for it and fails to obtain DMA channel 14.

Quoted 8 lines

For some reason I forgot to fix this on the Snowball. Fix this up by marking the node disabled again.

---
ARM SoC folks: please apply this patch directly to fixes for v3.17, I have no other pending Ux500 fixes.

Tested on snowball, and applied to fixes.

Thanks,

Kevin