Skip to contentSkip to conversation

staging: lustre: lov_pack: fix coding style issue

PATCH In review sunwxg 3 participants 3 messages Sep 1, 2014 – Sep 2, 2014 Staging

lore
Share & tools
lore

sunwxg

author
#0 lore raw

PATCH 1/1 staging: lustre: lov_pack: fix coding style issue

From: Sun Wang <[email protected]>

Fix the style error checking by checkpatch.pl
ERROR: space required after that ','

---
 drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/lov/lov_pack.c +1 -1
index 20e5870..62ea223 100644
@@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
 void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
 {
 	lov_dump_lmm_common(level, lmm);
-	CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+	CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
 	lov_dump_lmm_objects(level, lmm->lmm_objects,
 			     le16_to_cpu(lmm->lmm_stripe_count));
 }
#1 lore raw
Quoted 2 lines · sunwxg

Fix the style error checking by checkpatch.pl
ERROR: space required after that ','

[]

drivers/staging/lustre/lustre/lov/lov_pack.c

Quoted 1 line
drivers/staging/lustre/lustre/lov/lov_pack.c +0 -0

[]

drivers/staging/lustre/lustre/lov/lov_pack.c void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm) · line 98

Quoted 6 lines
drivers/staging/lustre/lustre/lov/lov_pack.c +1 -1
@@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
 void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
 {
 	lov_dump_lmm_common(level, lmm);
-	CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+	CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);

I think it better to separate the pre-coalesced
bits of the string like:

"pool name " LOV_POOLNAMEF "\n",