Skip to contentSkip to conversation

Incorrect backport to 2.6.32-stable - NFSD regression.

DISCUSSION NeilBrown 3 participants 3 messages Sep 3, 2014 – Sep 5, 2014

Subsystems (2)
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

2.6.32.30 contains:

commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf

Author: NeilBrown <[email protected]>
Date:   Wed Feb 16 13:08:35 2011 +1100

nfsd: correctly handle return value from nfsd_map_name_to_*

commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.

These functions return an nfs status, not a host_err. So don't try to convert before returning.

This is a regression introduced by 3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers, but missed these two.

But it does *not* contain a backport of
3c726023402a2f3b28f49b9d90ebf9e71151157d.

So rather an fixing a regression, it introduces one.

This patch should be reverted.

See also https://bugzilla.novell.com/show_bug.cgi?id=893787

NeilBrown

#1 lore raw

(Adding Willy to the CC list, in case he misses this email.)

Quoted 27 lines · NeilBrown

2.6.32.30 contains:

commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf

Author: NeilBrown <[email protected]>
Date:   Wed Feb 16 13:08:35 2011 +1100

nfsd: correctly handle return value from nfsd_map_name_to_*

commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.

These functions return an nfs status, not a host_err. So don't try to convert before returning.

This is a regression introduced by 3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers, but missed these two.

But it does *not* contain a backport of
3c726023402a2f3b28f49b9d90ebf9e71151157d.

Quoted 7 lines

So rather an fixing a regression, it introduces one.

This patch should be reverted.

See also https://bugzilla.novell.com/show_bug.cgi?id=893787

NeilBrown

Thanks a lot for reporting this here, Neil. I'll make sure we revert it from the Ubuntu 10.04 LTS kernel.

Cheers,
--
Luís

#2 lore raw

Hi guys,

Quoted 1 line · Luis Henriques

(Adding Willy to the CC list, in case he misses this email.)

Thank you Luis, I indeed missed it!

Quoted 25 lines · NeilBrown
Quoted 24 lines

2.6.32.30 contains:

commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf

Author: NeilBrown <[email protected]>
Date:   Wed Feb 16 13:08:35 2011 +1100

nfsd: correctly handle return value from nfsd_map_name_to_*

commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.

These functions return an nfs status, not a host_err. So don't try to convert before returning.

This is a regression introduced by 3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers, but missed these two.

Quoted 6 lines
Quoted 6 lines

But it does *not* contain a backport of
3c726023402a2f3b28f49b9d90ebf9e71151157d.

So rather an fixing a regression, it introduces one.

This patch should be reverted.

Thanks Neil, I'm queuing this request for next version. I'm slowly catching up from my move and hope to be able to deliver it "soon".

Best regards,
willy