Skip to contentSkip to conversation

hid-apple: fix coding style error

PATCH In review Jonathan Klee 3 participants 3 messages Sep 3, 2014

Subsystems (2)
Kernel janitors HID
lore
Share & tools
lore

Jonathan Klee

author
#0 lore raw

PATCH 1/1 hid-apple: fix coding style error

Hello everyone,
please find attached a patch fixing a coding style error.

Regards,
jklee

From e66b1e0cb9733ab20a73bb3234578006afd02639 Mon Sep 17 00:00:00 2001
From: "Jonathan Klee (jklee)" <[email protected]>
Date: Wed, 3 Sep 2014 15:43:13 +0200
Subject: [PATCH] fix coding style error

---
 drivers/hid/hid-apple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-apple.c +1 -1
index f822fd2..df9348f 100644
@@ -160,7 +160,7 @@ static const struct apple_key_translation swapped_option_cmd_keys[] = {
 	{ KEY_LEFTALT,	KEY_LEFTMETA },
 	{ KEY_LEFTMETA,	KEY_LEFTALT },
 	{ KEY_RIGHTALT,	KEY_RIGHTMETA },
-	{ KEY_RIGHTMETA,KEY_RIGHTALT },
+	{ KEY_RIGHTMETA, KEY_RIGHTALT },
 	{ }
 };
Signature · 1 line
2.1.0
#1 lore raw
Quoted 2 lines · Jonathan Klee

Hello everyone,
please find attached a patch fixing a coding style error.

Patches shouldn't be sent in attachments. Check
Documentation/SubmittingPatches

julia

#2 lore raw
In reply to Jonathan Klee

Thanks for the patch.

Everyone's first patch is rejected.

Don't send patches as attachments. Send them inline. Read the first paragraph of Documentation/email-clients.txt

Quoted 10 lines · Jonathan Klee

Hello everyone,
please find attached a patch fixing a coding style error.

Regards,
jklee

Quoted 1 line

From e66b1e0cb9733ab20a73bb3234578006afd02639 Mon Sep 17 00:00:00 2001

From: "Jonathan Klee (jklee)" <[email protected]>
Date: Wed, 3 Sep 2014 15:43:13 +0200
Subject: [PATCH] fix coding style error

No patch prefix.

Patch description should say something about spaces after commas.

No signed-off-by.

Quoted 10 lines
---
 drivers/hid/hid-apple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-apple.c +0 -0
index f822fd2..df9348f 100644

drivers/hid/hid-apple.c static const struct apple_key_translation swapped_option_cmd_keys[] = { · line 163

Quoted 5 lines
drivers/hid/hid-apple.c +1 -1
@@ -160,7 +160,7 @@ static const struct apple_key_translation swapped_option_cmd_keys[] = {
 	{ KEY_LEFTALT,	KEY_LEFTMETA },
 	{ KEY_LEFTMETA,	KEY_LEFTALT },
 	{ KEY_RIGHTALT,	KEY_RIGHTMETA },
-	{ KEY_RIGHTMETA,KEY_RIGHTALT },
+	{ KEY_RIGHTMETA, KEY_RIGHTALT },

The spacing here is done deliberately to make all the 'K's in the same column. Find something else to change.

regards,
dan carpenter