Skip to contentSkip to conversation

ARM: configs: Remove REGULATOR_VIRTUAL_CONSUMER from defconfigs

PATCH New Mark Brown 4 participants 5 messages Aug 31, 2014 – Sep 4, 2014

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: configs: Remove REGULATOR_VIRTUAL_CONSUMER from defconfigs

The virtual consumer is a test device intended to be used while developing regulator drivers, it should never be used in production. Remove it from all defconfigs to avoid confusion among users.

---
 arch/arm/configs/bcm_defconfig      | 1 -
 arch/arm/configs/ezx_defconfig      | 1 -
 arch/arm/configs/imote2_defconfig   | 1 -
 arch/arm/configs/multi_v7_defconfig | 1 -
 arch/arm/configs/pxa3xx_defconfig   | 1 -
 arch/arm/configs/sunxi_defconfig    | 1 -
 arch/arm/configs/tegra_defconfig    | 1 -
 7 files changed, 7 deletions(-)
arch/arm/configs/bcm_defconfig +0 -1
index fbebcbce1e8c..bc614f44b33d 100644
@@ -83,7 +83,6 @@ CONFIG_I2C_CHARDEV=y
 CONFIG_MFD_BCM590XX=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_USERSPACE_CONSUMER=y
 CONFIG_REGULATOR_BCM590XX=y
 
arch/arm/configs/ezx_defconfig +0 -1
index d95763d5f0d8..eb440aae4283 100644
@@ -230,7 +230,6 @@ CONFIG_POWER_SUPPLY=y
 CONFIG_EZX_PCAP=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_DEBUG=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_USERSPACE_CONSUMER=y
 CONFIG_REGULATOR_PCAP=y
 CONFIG_MEDIA_SUPPORT=y
arch/arm/configs/imote2_defconfig +0 -1
index fd996bb13022..182e54692664 100644
@@ -208,7 +208,6 @@ CONFIG_POWER_SUPPLY=y
 CONFIG_PMIC_DA903X=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_DEBUG=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_USERSPACE_CONSUMER=y
 CONFIG_REGULATOR_DA903X=y
 CONFIG_MEDIA_SUPPORT=y
arch/arm/configs/multi_v7_defconfig +0 -1
index 7cfa5fa5f7ac..05c0e7c789df 100644
@@ -259,7 +259,6 @@ CONFIG_MFD_PALMAS=y
 CONFIG_MFD_TPS65090=y
 CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_AB8500=y
 CONFIG_REGULATOR_AS3722=y
 CONFIG_REGULATOR_BCM590XX=y
arch/arm/configs/pxa3xx_defconfig +0 -1
index 60e313834b3f..5f337d7ceb5b 100644
@@ -77,7 +77,6 @@ CONFIG_BATTERY_DA9030=y
 CONFIG_PMIC_DA903X=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_DEBUG=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_DA903X=y
 CONFIG_FB=y
 CONFIG_FB_PXA=y
arch/arm/configs/sunxi_defconfig +0 -1
index 6c037f956e36..c1a4ca4f6e6d 100644
@@ -75,7 +75,6 @@ CONFIG_POWER_RESET_SUN6I=y
 CONFIG_WATCHDOG=y
 CONFIG_SUNXI_WATCHDOG=y
 CONFIG_MFD_AXP20X=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
arch/arm/configs/tegra_defconfig +0 -1
index 2b8be4850347..b448f58f621a 100644
@@ -168,7 +168,6 @@ CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
-CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_AS3722=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_REGULATOR_MAX8907=y
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 ARM: configs: Remove REGULATOR_VIRTUAL_CONSUMER from defconfigs

Quoted 3 lines · Mark Brown

The virtual consumer is a test device intended to be used while developing regulator drivers, it should never be used in production. Remove it from all defconfigs to avoid confusion among users.

tegra_defconfig isn't a distro configuration, and has plenty of other debug/test options turned on. I'm not sure that removing this option really has much benefit. Still, this likely isn't going to cause any issue, so I guess it's fine. People can always add the option locally if they want.

author
#2 lore raw

PATCH 1/1 ARM: configs: Remove REGULATOR_VIRTUAL_CONSUMER from defconfigs

Quoted 10 lines · Stephen Warren
Quoted 3 lines · Mark Brown

The virtual consumer is a test device intended to be used while developing regulator drivers, it should never be used in production. Remove it from all defconfigs to avoid confusion among users.

tegra_defconfig isn't a distro configuration, and has plenty of other debug/test options turned on. I'm not sure that removing this option really has much benefit. Still, this likely isn't going to cause any issue, so I guess it's fine. People can always add the option locally if they want.

In order to instantiate it you're going to have to generate a custom DT
anyway so I don't think the burden is excessive.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140902/5e47a30d/attachment-0001.sig>

#3 lore raw

PATCH 1/1 ARM: configs: Remove REGULATOR_VIRTUAL_CONSUMER from defconfigs

In reply to Mark Brown
Quoted 7 lines · Mark Brown

The virtual consumer is a test device intended to be used while developing regulator drivers, it should never be used in production. Remove it from all defconfigs to avoid confusion among users.

---
 arch/arm/configs/bcm_defconfig      | 1 -

For bcm_defconfig:

-Matt

#4 lore raw

PATCH 1/1 ARM: configs: Remove REGULATOR_VIRTUAL_CONSUMER from defconfigs

Quoted 5 lines · Matt Porter
Quoted 4 lines · Mark Brown

The virtual consumer is a test device intended to be used while developing regulator drivers, it should never be used in production. Remove it from all defconfigs to avoid confusion among users.

Quoted 8 lines
Quoted 3 lines
---
 arch/arm/configs/bcm_defconfig      | 1 -

For bcm_defconfig:

Applied to next/defconfig, thanks!

Arnd