add more dependencies on atomic operations
cover add more dependencies on atomic operations
More packages were discovered to use atomic operatoins. With this series dependencies are applied to libraries that use atomic operations and packages that explicitly select mentioned libraries.
Alexey Brodkin (2):
libtirpc: add dependency on atomic operations
zeromq: add dependency on atomic operations
package/argus/Config.in | 1 + package/conntrack-tools/Config.in | 1 + package/cppzmq/Config.in | 1 + package/czmq/Config.in | 1 + package/filemq/Config.in | 1 + package/libtirpc/Config.in | 1 + package/lmbench/Config.in | 1 + package/mongrel2/Config.in | 1 + package/nfs-utils/Config.in | 1 + package/php-zmq/Config.in | 1 + package/python-pyzmq/Config.in | 1 + package/quota/Config.in | 1 + package/rpcbind/Config.in | 1 + package/zeromq/Config.in | 1 + package/zmqpp/Config.in | 1 + package/zyre/Config.in | 1 + 16 files changed, 16 insertions(+)
Signature · 1 line
1.9.3
PATCH 1/2 libtirpc: add dependency on atomic operations
Fixes:
http://autobuild.buildroot.net/results/6bb90d3f2b840a1faacf152a1d93a909a2dc98d3
http://autobuild.buildroot.net/results/994a84d192848b90a70e28e5ebaa769701bcaec9
Following packages select "libtirpc", so adding dependency as well:
* argus
* conntrack-tools
* lmbench
* nfs-utils
* quota
* rpcbind
--- package/argus/Config.in | 1 + package/conntrack-tools/Config.in | 1 + package/libtirpc/Config.in | 1 + package/lmbench/Config.in | 1 + package/nfs-utils/Config.in | 1 + package/quota/Config.in | 1 + package/rpcbind/Config.in | 1 + 7 files changed, 7 insertions(+)
package/argus/Config.in +1 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_ARGUS bool "argus" depends on BR2_INET_IPV6 + depends on BR2_ARCH_HAS_ATOMICS # libtirpc depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork() select BR2_PACKAGE_LIBPCAP
package/conntrack-tools/Config.in +1 -0
@@ -3,6 +3,7 @@ config BR2_PACKAGE_CONNTRACK_TOOLS depends on BR2_INET_IPV6 depends on BR2_LARGEFILE depends on BR2_USE_MMU # fork() + depends on BR2_ARCH_HAS_ATOMICS # libtirpc depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc select BR2_PACKAGE_LIBNETFILTER_CONNTRACK select BR2_PACKAGE_LIBNETFILTER_CTHELPER
package/libtirpc/Config.in +1 -0
@@ -7,6 +7,7 @@ config BR2_PACKAGE_LIBTIRPC # used instead of libtirpc. depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_ARCH_HAS_ATOMICS help Libtirpc is a port of Sun's Transport-Independent RPC library to Linux.
package/lmbench/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_LMBENCH bool "lmbench" + depends on BR2_ARCH_HAS_ATOMICS # libtirpc depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC depends on BR2_USE_MMU # fork()
package/nfs-utils/Config.in +1 -0
@@ -5,6 +5,7 @@ comment "nfs-utils needs a toolchain w/ largefile, threads" config BR2_PACKAGE_NFS_UTILS bool "nfs-utils" + depends on BR2_ARCH_HAS_ATOMICS # libtirpc depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC depends on BR2_LARGEFILE
package/quota/Config.in +1 -0
@@ -4,6 +4,7 @@ config BR2_PACKAGE_QUOTA depends on BR2_USE_WCHAR depends on BR2_USE_MMU # fork() depends on !(BR2_microblazeel || BR2_microblazebe) # util-linux + depends on BR2_ARCH_HAS_ATOMICS # libtirpc depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX_BINARIES
package/rpcbind/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_RPCBIND bool "rpcbind" # We really need libtirpc and can't work with the native RPC # implementation of toolchains. + depends on BR2_ARCH_HAS_ATOMICS # libtirpc depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc select BR2_PACKAGE_LIBTIRPC # uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
Signature · 1 line
1.9.3
PATCH 1/2 libtirpc: add dependency on atomic operations
Dear Alexey Brodkin,
Quoted 12 lines · Alexey Brodkin
Fixes:
http://autobuild.buildroot.net/results/6bb90d3f2b840a1faacf152a1d93a909a2dc98d3
http://autobuild.buildroot.net/results/994a84d192848b90a70e28e5ebaa769701bcaec9Following packages select "libtirpc", so adding dependency as well:
* argus
* conntrack-tools
* lmbench
* nfs-utils
* quota
* rpcbind
Quoted 1 line
Signed-off-by Alexey Brodkin <[email protected]>
That's not that simple because you forget to update the comments: they should not be displayed if the architecture doesn't have the atomic intrinsics. And this is where things start to be really, really weird.
package/conntrack-tools/Config.in config BR2_PACKAGE_CONNTRACK_TOOLS · line 6
Quoted 9 lines
package/conntrack-tools/Config.in +1
-0@@ -3,6 +3,7 @@ config BR2_PACKAGE_CONNTRACK_TOOLS depends on BR2_INET_IPV6 depends on BR2_LARGEFILE depends on BR2_USE_MMU # fork() + depends on BR2_ARCH_HAS_ATOMICS # libtirpc
That's not correct: if the toolchain has native RPC support, we do not need libtirpc, so there is no need to depend on BR2_ARCH_HAS_ATOMICS in this case.
I already tried to solve this thing, but it's much more complicated than just adding a bunch of "depends on".
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 libtirpc: add dependency on atomic operations
Hi Thomas,
Quoted 21 lines · Thomas Petazzoni
Dear Alexey Brodkin,
Quoted 1 line
Signed-off-by Alexey Brodkin <[email protected]>That's not that simple because you forget to update the comments: they should not be displayed if the architecture doesn't have the atomic intrinsics. And this is where things start to be really, really weird.
package/conntrack-tools/Config.in config BR2_PACKAGE_CONNTRACK_TOOLS · line 6
Quoted 9 lines
package/conntrack-tools/Config.in +1
-0@@ -3,6 +3,7 @@ config BR2_PACKAGE_CONNTRACK_TOOLS depends on BR2_INET_IPV6 depends on BR2_LARGEFILE depends on BR2_USE_MMU # fork() + depends on BR2_ARCH_HAS_ATOMICS # libtirpcThat's not correct: if the toolchain has native RPC support, we do not need libtirpc, so there is no need to depend on
BR2_ARCH_HAS_ATOMICSin this case.
Quoted 2 lines
I already tried to solve this thing, but it's much more complicated than just adding a bunch of "depends on".
So I assume there's no sense for me to try fixing comments, right? I mean if this won't work either or introduce new problems as you meant.
Then what could be our next steps to accommodate possibility of existence/absence of atomic ops?
This is especially important for ARC where these ops are optional. The simplest solution could be to enable BR2_ARCH_HAS_ATOMICS for ARC by default, but this will just attempt to escape from real problem.
And as I saw from other autobuild results other architectures are affected like Blackfin for example.
If this is that complicated we may try to discuss it in person on Buildroot summit in few weeks.
-Alexey
PATCH 1/2 libtirpc: add dependency on atomic operations
Dear Alexey Brodkin,
Quoted 5 lines · Alexey Brodkin
Quoted 2 lines
I already tried to solve this thing, but it's much more complicated than just adding a bunch of "depends on".
So I assume there's no sense for me to try fixing comments, right? I mean if this won't work either or introduce new problems as you meant.
There is definitely some sense in fixing this stuff. I'm not sure yet on how to do this. I had some discussion with Thomas DS a week ago or so on IRC about this.
Quoted 6 lines
This is especially important for ARC where these ops are optional. The simplest solution could be to enable
BR2_ARCH_HAS_ATOMICSfor ARC by default, but this will just attempt to escape from real problem.And as I saw from other autobuild results other architectures are affected like Blackfin for example.
Yes, sure, we need to fix the problem. It's just not as simple as adding more "depends on", unfortunately :-(
Quoted 2 lines
If this is that complicated we may try to discuss it in person on Buildroot summit in few weeks.
Ah, you're planning on coming to the Buildroot meeting? If so, could you register to http://elinux.org/Buildroot:DeveloperDaysELCE2014, or confirm me that you are coming so that I can add your name to the list of participants?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 libtirpc: add dependency on atomic operations
Hi Thomas,
Quoted 8 lines · Thomas Petazzoni
Dear Alexey Brodkin,
On Mon, 8 Sep 2014 09:23:02 +0000, Alexey Brodkin wrote:
Ah, you're planning on coming to the Buildroot meeting? If so, could you register to http://elinux.org/Buildroot:DeveloperDaysELCE2014, or confirm me that you are coming so that I can add your name to the list of participants?
Do you mind to add another atomic ops discussion as another item to "Topics to discuss" during the event?
-Alexey
PATCH 1/2 libtirpc: add dependency on atomic operations
Dear Alexey Brodkin,
Quoted 7 lines · Alexey Brodkin
Quoted 4 lines
Ah, you're planning on coming to the Buildroot meeting? If so, could you register to http://elinux.org/Buildroot:DeveloperDaysELCE2014, or confirm me that you are coming so that I can add your name to the list of participants?
Do you mind to add another atomic ops discussion as another item to "Topics to discuss" during the event?
I've added it. But to be honest, I hope to be able to make a proposal to solve the problem before the meeting.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 libtirpc: add dependency on atomic operations
Hi Thomas,
Quoted 9 lines · Thomas Petazzoni
Dear Alexey Brodkin,
Quoted 5 lines · Alexey Brodkin
Quoted 4 lines
Ah, you're planning on coming to the Buildroot meeting? If so, could you register to http://elinux.org/Buildroot:DeveloperDaysELCE2014, or confirm me that you are coming so that I can add your name to the list of participants?
Quoted 5 lines
Quoted 2 lines
Do you mind to add another atomic ops discussion as another item to "Topics to discuss" during the event?
I've added it. But to be honest, I hope to be able to make a proposal to solve the problem before the meeting.
Good to know it! Please let me know if I may somehow help you with it.
-Alexey
PATCH 2/2 zeromq: add dependency on atomic operations
In reply to Alexey BrodkinAs it is seen from http://autobuild.buildroot.org/results/3bd/3bda860a269dd9a4e38533cc9350892c68102618
"zeromq" uses "___sync_add_and_fetch_2" & "___sync_fetch_and_add_2" in "libpgm"
so make it dependent on atomic operations.
Following packages select "zeromq", so adding dependency as well:
* cppzmq
* czmq
* filemq
* mongrel2
* php-zmq
* python-pyzmq
* zmqpp
* zyre
--- package/cppzmq/Config.in | 1 + package/czmq/Config.in | 1 + package/filemq/Config.in | 1 + package/mongrel2/Config.in | 1 + package/php-zmq/Config.in | 1 + package/python-pyzmq/Config.in | 1 + package/zeromq/Config.in | 1 + package/zmqpp/Config.in | 1 + package/zyre/Config.in | 1 + 9 files changed, 9 insertions(+)
package/cppzmq/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_CPPZMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help C++ binding for zeromq (ZeroMQ, 0MQ, zmq).
package/czmq/Config.in +1 -0
@@ -7,6 +7,7 @@ config BR2_PACKAGE_CZMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq help High-level C Binding for 0MQ
package/filemq/Config.in +1 -0
@@ -8,6 +8,7 @@ config BR2_PACKAGE_FILEMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq depends on BR2_USE_MMU # czmq help FileMQ is a publish-subscribe file service based on 0MQ.
package/mongrel2/Config.in +1 -0
@@ -14,6 +14,7 @@ config BR2_PACKAGE_MONGREL2 depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq depends on BR2_LARGEFILE # zeromq -> util-linux depends on BR2_USE_WCHAR # zeromq -> util-linux + depends on BR2_ARCH_HAS_ATOMICS # zeromq # {get,make,swap}context functions present in # {e,}glibc and in uClibc's master branch. Source has arm workaround depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
package/php-zmq/Config.in +1 -0
@@ -10,6 +10,7 @@ config BR2_PACKAGE_PHP_ZMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help ZeroMQ messaging bindings for PHP
package/python-pyzmq/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_PYZMQ depends on BR2_USE_WCHAR # zeromq depends on BR2_INSTALL_LIBSTDCPP # zeromq depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help This package contains the python language binding for zeromq.
package/zeromq/Config.in +1 -0
@@ -9,6 +9,7 @@ config BR2_PACKAGE_ZEROMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_ARCH_HAS_ATOMICS select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX_LIBUUID help
package/zmqpp/Config.in +1 -0
@@ -8,6 +8,7 @@ config BR2_PACKAGE_ZMQPP depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help C++ binding for zeromq (ZeroMQ, 0MQ, zmq).
package/zyre/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_ZYRE depends on BR2_LARGEFILE # zeromq depends on BR2_USE_WCHAR # zeromq depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq depends on BR2_USE_MMU # czmq # uClibc toolchains provided by ADI don't have AI_ADDRCONFIG # support, needed by czmq
Signature · 1 line
1.9.3
PATCH 2/2 zeromq: add dependency on atomic operations
Dear Alexey Brodkin,
package/cppzmq/Config.in config BR2_PACKAGE_CPPZMQ · line 11
Quoted 12 lines · Alexey Brodkin
package/cppzmq/Config.in +1
-0@@ -5,6 +5,7 @@ config BR2_PACKAGE_CPPZMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help C++ binding for zeromq (ZeroMQ, 0MQ, zmq).
Same thing here: you should change the comment to *not* display it if the architecture doesn't have atomic intrinsics.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 2/2 zeromq: add dependency on atomic operations
Hi Thomas,
Quoted 4 lines · Thomas Petazzoni
Dear Alexey Brodkin,
On Mon, 8 Sep 2014 10:32:44 +0400, Alexey Brodkin wrote:
Quoted 15 lines
package/cppzmq/Config.in config BR2_PACKAGE_CPPZMQ · line 11
Quoted 12 lines
package/cppzmq/Config.in +1
-0@@ -5,6 +5,7 @@ config BR2_PACKAGE_CPPZMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help C++ binding for zeromq (ZeroMQ, 0MQ, zmq).Same thing here: you should change the comment to *not* display it if the architecture doesn't have atomic intrinsics.
I assume comments from the previous patch apply here as well, right? Especially since atomic ops are only used in "libpgm", i.e. if only BR2_PACKAGE_ZEROMQ_PGM is enabled.
-Alexey
PATCH 2/2 zeromq: add dependency on atomic operations
Dear Alexey Brodkin,
Quoted 23 lines · Alexey Brodkin
Hi Thomas,
Quoted 4 lines · Thomas Petazzoni
Dear Alexey Brodkin,
On Mon, 8 Sep 2014 10:32:44 +0400, Alexey Brodkin wrote:
Quoted 15 lines
package/cppzmq/Config.in config BR2_PACKAGE_CPPZMQ · line 11
Quoted 12 lines
package/cppzmq/Config.in +1
-0@@ -5,6 +5,7 @@ config BR2_PACKAGE_CPPZMQ depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq + depends on BR2_ARCH_HAS_ATOMICS # zeromq select BR2_PACKAGE_ZEROMQ help C++ binding for zeromq (ZeroMQ, 0MQ, zmq).Same thing here: you should change the comment to *not* display it if the architecture doesn't have atomic intrinsics.
Quoted 3 lines
I assume comments from the previous patch apply here as well, right? Especially since atomic ops are only used in "libpgm", i.e. if only
BR2_PACKAGE_ZEROMQ_PGMis enabled.
If atomic operations are only used when BR2_PACKAGE_ZEROMQ_PGM is enabled, why do we need to propagate all those dependencies then? If a package selects BR2_PACKAGE_ZEROMQ and not BR2_PACKAGE_ZEROMQ_PGM, there's no reason to propagate the dependency.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com