portmap not building static
PATCH 1/1 portmap not building static
Portmap builds and links, however, does not get built correctly when BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of portmap. Fixed.
---
package/portmap/portmap.mk 2014-09-08 10:38:06.264120676 -0500 renamed from package/portmap/portmap.mk 2014-02-27 14:51:23.000000000 -0600 +1 -1
@@ -15,7 +15,7 @@ endif define PORTMAP_BUILD_CMDS - CFLAGS="$(TARGET_CFLAGS)" \ + CFLAGS="$(TARGET_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS)" \ $(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS) endef
PATCH 1/1 portmap not building static
Dear ANDY KENNEDY,
The title of the patch should be:
portmap: fix static linking
Quoted 5 lines · ANDY KENNEDY
Portmap builds and links, however, does not get built correctly when
BR2_PREFER_STATIC_LIBis selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to thePREFER_STATIC_LIBtags. LDFLAGS was not being passed into the build of portmap. Fixed.
Remove the "Fixed." from the commit log, this is not needed.
package/portmap/portmap.mk 2014-09-08 10:38:06.264120676 -0500 line 20
Quoted 11 lines
diff -Naur
a/package/portmap/portmap.mkb/package/portmap/portmap.mkpackage/portmap/portmap.mk 2014-09-08 10:38:06.264120676 -0500 renamed from package/portmap/portmap.mk 2014-02-27 14:51:23.000000000 -0600 +1
-1@@ -15,7 +15,7 @@ endif define PORTMAP_BUILD_CMDS - CFLAGS="$(TARGET_CFLAGS)" \ + CFLAGS="$(TARGET_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS)" \ $(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS) endef
I would prefer the following fix:
package/portmap/portmap.mk +1 -2
@@ -17,8 +17,7 @@ PORTMAP_FLAGS += NO_FORK=1 endif define PORTMAP_BUILD_CMDS - CFLAGS="$(TARGET_CFLAGS)" \ - $(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS) + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) $(PORTMAP_FLAGS) endef define PORTMAP_INSTALL_TARGET_CMDS
By using $(TARGET_CONFIGURE_OPTS), we ensure that all usually useful variables are passed.
Can you resend an updated version with those changes?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com