Skip to contentSkip to conversation

parted not building static

PATCH New ANDY KENNEDY 2 participants 3 messages Sep 8, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parted not building static

Parted would not build when PREFER_STATIC_LIB was selected. The configure error reports "Add --disable-dynamic-loading" as the fix. Added this fix.

---

package/parted/parted.mk 2014-09-08 10:37:39.288121610 -0500 renamed from package/parted/parted.mk 2014-02-27 14:51:23.000000000 -0600 +4 -0
diff -Naur a/package/parted/parted.mk b/package/parted/parted.mk
@@ -19,6 +19,10 @@
 PARTED_CONF_OPT += --without-readline
 endif
 
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+PARTED_CONF_OPT += --disable-dynamic-loading
+endif
+
 ifeq ($(BR2_PACKAGE_LVM2),y)
 PARTED_DEPENDENCIES += lvm2
 PARTED_CONF_OPT += --enable-device-mapper
#1 lore raw

PATCH 1/1 parted not building static

Dear ANDY KENNEDY,

package/parted/parted.mk 2014-09-08 10:37:39.288121610 -0500 line 24

Quoted 3 lines · ANDY KENNEDY
package/parted/parted.mk 2014-09-08 10:37:39.288121610 -0500 renamed from package/parted/parted.mk 2014-02-27 14:51:23.000000000 -0600 +3 -0
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+PARTED_CONF_OPT += --disable-dynamic-loading
+endif

Your Buildroot tree is probably not up-to-date because this has already been fixed by Gustavo in commit ea7061f40e04f6a475705a579529978de1b9cc91 (June 2014). This commit is part of the 2014.08 release.

Thanks for your patch!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 parted not building static

Quoted 1 line

Your Buildroot tree is probably not up-to-date because this has already

Not even that. I'm using the released version of 2014.02 to diff against.

I didn't do my due diligence on this one. I figured that was probably not something that anyone else would have seen.

I _SHOULD_ have done a sync with today and checked against that.

Sorry about that. Shouldn't have wasted your time.

Andy