percpu: fix locking regression in the failure path of pcpu_alloc()
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): 540d6d8e.bX1TYtX2p4laJeSu%[email protected]
A message that is not in the archive (sent off-list or not yet received): alpine.DEB.2.10.1409081121210.2406@hadrien
Tejun Heo
maintainerPATCH 1/1 percpu: fix locking regression in the failure path of pcpu_alloc()
Quoted 1 line
From
23cb8981ed929b4dd48141401cd0fd31e0fa4ed0Mon Sep 17 00:00:00 2001
From: Tejun Heo <[email protected]>
Date: Tue, 9 Sep 2014 08:02:45 +0900
While updating locking, b38d08f3181c ("percpu: restructure locking") broke pcpu_create_chunk() creation path in pcpu_alloc(). It returns without releasing pcpu_alloc_mutex. Fix it.
Signed-off-by Tejun Heo <[email protected]>
Reported-by Julia Lawall <[email protected]>
---
Applied to percpu/for-3.18.
Thanks a lot!
mm/percpu.c | 1 + 1 file changed, 1 insertion(+)
mm/percpu.c +1 -0
@@ -974,6 +974,7 @@ restart:if (list_empty (&pcpu_slot[pcpu_nr_slots -1 ])) { chunk =pcpu_create_chunk ();if (!chunk) { +mutex_unlock (&pcpu_alloc_mutex); err ="failed to allocate new chunk" ; goto fail; }
Signature · 1 line
1.9.3