Skip to contentSkip to conversation

fix cm-t54 serial console power supply

PATCH New Dmitry Lifshitz 3 participants 5 messages Sep 4, 2014 – Sep 9, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

cover fix cm-t54 serial console power supply

Essential fix of CM-T54 serial console power supply and minor update of SBC-T54 DT model property.

Dmitry Lifshitz (2):
ARM: dts: cm-t54: fix serial console power supply.
ARM: dts: sbc-t54: fix model property

 arch/arm/boot/dts/omap5-cm-t54.dts  |    5 ++---
 arch/arm/boot/dts/omap5-sbc-t54.dts |    4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/2 ARM: dts: cm-t54: fix serial console power supply.

LDO8 regulator is used for act led and serial cosole power supply.

Its DT status is declared as "disabled", however the serial console was functional until Commit 318dbb02b ("regulator: palmas: Fix SMPS enable/disable/is_enabled") wich properly turns off LDO8 on boot.

Fix serial cosole power supply (and act led) on boot by turning LDO8 on.

---
 arch/arm/boot/dts/omap5-cm-t54.dts |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap5-cm-t54.dts +2 -3
index b8698ca..429471a 100644
@@ -353,13 +353,12 @@
 				};
 
 				ldo8_reg: ldo8 {
-					/* VDD_3v0: Does not go anywhere */
+					/* VDD_3V_GP: act led/serial console */
 					regulator-name = "ldo8";
 					regulator-min-microvolt = <3000000>;
 					regulator-max-microvolt = <3000000>;
+					regulator-always-on;
 					regulator-boot-on;
-					/* Unused */
-					status = "disabled";
 				};
 
 				ldo9_reg: ldo9 {
Signature · 1 line
1.7.5.4
#2 lore raw

PATCH 1/2 ARM: dts: cm-t54: fix serial console power supply.

Quoted 9 lines · Dmitry Lifshitz

LDO8 regulator is used for act led and serial cosole power supply.

Its DT status is declared as "disabled", however the serial console was functional until Commit 318dbb02b ("regulator: palmas: Fix SMPS enable/disable/is_enabled") wich properly turns off LDO8 on boot.

Fix serial cosole power supply (and act led) on boot by turning LDO8 on.

- Paul

#3 lore raw

PATCH 1/2 ARM: dts: cm-t54: fix serial console power supply.

Quoted 8 lines · Paul Walmsley
Quoted 6 lines · Dmitry Lifshitz

LDO8 regulator is used for act led and serial cosole power supply.

Its DT status is declared as "disabled", however the serial console was functional until Commit 318dbb02b ("regulator: palmas: Fix SMPS enable/disable/is_enabled") wich properly turns off LDO8 on boot.

Quoted 5 lines
Quoted 3 lines

Fix serial cosole power supply (and act led) on boot by turning LDO8 on.

Applying this into omap-for-v3.17/fixes-v2, the second into omap-for-v3.18/dt thanks.

Tony

#4 lore raw

PATCH 2/2 ARM: dts: sbc-t54: fix model property

In reply to Dmitry Lifshitz

CM-T54 CoM can be used with various custom baseboards, other than SB-T54 (supplied with SBC-T54 single board computer).

Update model property of SBC-T54 DT to clarify this.

---
 arch/arm/boot/dts/omap5-sbc-t54.dts |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5-sbc-t54.dts +2 -2
index aa98fea..8e89793 100644
@@ -1,11 +1,11 @@
 /*
- * Suppport for CompuLab SBC-T54 with CM-T54
+ * Suppport for CompuLab CM-T54 on SB-T54 baseboard
  */
 
 #include "omap5-cm-t54.dts"
 
 / {
-	model = "CompuLab SBC-T54 with CM-T54";
+	model = "CompuLab CM-T54 on SB-T54";
 	compatible = "compulab,omap5-sbc-t54", "compulab,omap5-cm-t54", "ti,omap5";
 };
 
Signature · 1 line
1.7.5.4