Skip to contentSkip to conversation

percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix

PATCH In review Mel Gorman 5 participants 6 messages Sep 8, 2014 – Sep 9, 2014 x86

lore
Share & tools
lore

Mel Gorman

author
#0 lore raw

PATCH 1/1 percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix

A commit in linux-next was causing boot to fail and bisection identified the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_". The commit ID is worthless as it's a linux-next commit. One of the changes in that patch looks very suspicious. Reverting the full patch fixes boot as does this fixlet.

---
 arch/x86/kernel/apic/x2apic_cluster.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/apic/x2apic_cluster.c +1 -0
index 1f5d5f2..e658f21 100644
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
 	 * and be sure it's manipulated with irq off.
 	 */
 	ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+	cpumask_copy(ipi_mask_ptr, mask);
 
 	/*
 	 * The idea is to send one IPI per cluster.
#1 lore raw
Quoted 3 lines · Mel Gorman

A commit in linux-next was causing boot to fail and bisection identified the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_". The commit ID is worthless as it's a linux-next commit. One of the changes

It is actually a stable commit ID. I'll add the commit ID in the change log.

Quoted 2 lines

in that patch looks very suspicious. Reverting the full patch fixes boot as does this fixlet.

Applying to percpu/for-3.18-consistent-ops.

Thanks.

Signature · 1 line
tejun
#2 lore raw
In reply to Mel Gorman
Quoted 5 lines · Mel Gorman

A commit in linux-next was causing boot to fail and bisection identified the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_". The commit ID is worthless as it's a linux-next commit. One of the changes in that patch looks very suspicious. Reverting the full patch fixes boot as does this fixlet.

I already acked a patch like this today.

#3 lore raw
Quoted 9 lines · Christoph Lameter
Quoted 5 lines · Mel Gorman

A commit in linux-next was causing boot to fail and bisection identified the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_". The commit ID is worthless as it's a linux-next commit. One of the changes in that patch looks very suspicious. Reverting the full patch fixes boot as does this fixlet.

I already acked a patch like this today.

It isn't in my inbox.

Thanks.

Signature · 1 line
tejun
Tested-by
#4 lore raw
Quoted 4 lines · Tejun Heo <tj <at> kernel.org> writes:
Quoted 1 line · Christoph Lameter

I already acked a patch like this today.

It isn't in my inbox.

It was "[PATCH] x86, apic: Fix unmasked CPU initialization"
<http://www.spinics.net/lists/kernel/msg1820725.html>

Sorry you weren't included; I used get_maintainer.pl for the recipient list.

I also posted it with a smaller recipient list including you on Friday under the title
"[PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask"
<http://www.spinics.net/lists/kernel/msg1819784.html>

Good to see it's solved now anyway. Since I've been using the same patch for the last few days,

Acked-by on v1 1/1
#5 lore raw
In reply to Mel Gorman
Quoted 7 lines · Mel Gorman

A commit in linux-next was causing boot to fail and bisection identified the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_". The commit ID is worthless as it's a linux-next commit. One of the changes in that patch looks very suspicious. Reverting the full patch fixes boot as does this fixlet.

I assume that since this is ipi_mask_ptr that the boot hangs instead of doing anything else.