question about two ASoC commits
Hi
Can anyone tell me what is the reasoning of the following two commits
commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings
commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings
with these two commits, now we have
#define SND_SOC_DAIFMT_GATED (0 << 4)
#define SND_SOC_DAIFMT_NB_NF (0 << 8)
in soc-dai.h
what's the good to shift 0 with different numbers? no matter the number, they both equal to 0.
IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT) should have different value, isn't it?
Thanks,
Jiada
Quoted 11 lines · jiwang
Can anyone tell me what is the reasoning of the following two commits
commit: 5d16333 ASoC:SND_SOC_DAIFMT_NB_NFbecome 0 as default settings
commit: eef28e1 ASoC:SND_SOC_DAIFMT_GATEDbecome 0 as default settingswith these two commits, now we have
#defineSND_SOC_DAIFMT_GATED(0 << 4)
#defineSND_SOC_DAIFMT_NB_NF(0 << 8)
insoc-dai.h
what's the good to shift 0 with different numbers? no matter the number, they both equal to 0.
Quoted 2 lines
IMO all bit flags which share same variable (in this case
SND_SOC_DAIFMT) should have different value, isn't it?
As the commit message says this is so that we have a default value which does something sensible.
A message that is not in the archive (sent off-list or not yet received): 857E9EDCA6C0904DB3357321AA9123EBE61DF1E9@NA-MBX-01.mgc.mentorg.com
Hi Mark
From: Mark Brown [mailto:[email protected]] Sent: Tuesday, September 09, 2014 7:20 PM To: Wang, Jiada (ESD) Cc: Liam Girdwood; Jaroslav Kysela; Takashi Iwai; Frkuska, Joshua; [email protected]; [email protected] Subject: Re: question about two ASoC commits On Tue, Sep 09, 2014 at 05:36:36PM +0900, jiwang wrote:
Quoted 13 lines
Quoted 5 lines
Can anyone tell me what is the reasoning of the following two commits
commit: 5d16333 ASoC:SND_SOC_DAIFMT_NB_NFbecome 0 as default settings
commit: eef28e1 ASoC:SND_SOC_DAIFMT_GATEDbecome 0 as default settingsQuoted 8 lines
with these two commits, now we have
#defineSND_SOC_DAIFMT_GATED(0 << 4)
#defineSND_SOC_DAIFMT_NB_NF(0 << 8)
insoc-dai.h
what's the good to shift 0 with different numbers? no matter the number, they both equal to 0.
IMO all bit flags which share same variable (in this caseSND_SOC_DAIFMT) should have different value, isn't it?
Quoted 1 line
As the commit message says this is so that we have a default value which does something sensible.
Yes I can read this from commit message,
But I am not very sure why not initialize dai format variable in driver itself.
further more, by having
commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default
DAI hardware signal inversions Macros are declared as following
#define SND_SOC_DAIFMT_NB_NF (0 << 8) /* normal bit clock + frame */ #define SND_SOC_DAIFMT_NB_IF (2 << 8) /* normal BCLK + inv FRM */ #define SND_SOC_DAIFMT_IB_NF (3 << 8) /* invert BCLK + nor FRM */ #define SND_SOC_DAIFMT_IB_IF (4 << 8) /* invert BCLK + FRM */
Now we are having undefined hole between NB_NF and NB_IF,
don't you think it's better to shift all the others down by 1, to keep them coherent? so that when new mode (although it's likely there won't be) needs to be added, it can be appended to the last,otherwise it may cause confuse, either to choose (1 << 8) or (5 << 8)
Thanks,
Jiada
Quoted 3 lines · jiwang
Yes I can read this from commit message,
But I am not very sure why not initialize dai format variable in driver itself.
If the user doesn't specify anything we have to pick a default, this is the quickest and simplest way of doing that.
Quoted 2 lines
Now we are having undefined hole between
NB_NFandNB_IF,
don't you think it's better to shift all the others down by 1, to keep them coherent?
Sure, feel free to submit a patch.