arc: Fix warning if atomics are selected
PATCH 1/1 arc: Fix warning if atomics are selected
If atomic instructions were selected for ARC, there was a warning, like:
"(BR2_ARC_ATOMIC_EXT) selects BR2_ARCH_HAS_ATOMICS which has unmet direct dependencies". This patch removes the reason of this warning by adding a respective configuration entry.
--- arch/Config.in.arc | 3 +++ 1 file changed, 3 insertions(+)
arch/Config.in.arc +3 -0
@@ -1,3 +1,6 @@ +config BR2_ARCH_HAS_ATOMICS + bool + # Choise of atomic instructions presence config BR2_ARC_ATOMIC_EXT bool "Atomic extension (LLOCK/SCOND instructions)"
Signature · 1 line
1.8.4.1
PATCH 1/1 arc: Fix warning if atomics are selected
Dear Anton Kolesov,
Quoted 15 lines · Anton Kolesov
If atomic instructions were selected for ARC, there was a warning, like:
"(BR2_ARC_ATOMIC_EXT) selectsBR2_ARCH_HAS_ATOMICSwhich has unmet direct dependencies". This patch removes the reason of this warning by adding a respective configuration entry.Signed-off-by Anton Kolesov <[email protected]>--- arch/Config.in.arc | 3 +++ 1 file changed, 3 insertions(+)arch/Config.in.arc +0
-0
arch/Config.in.arc line 2
Quoted 2 lines
arch/Config.in.arc +2
-0@@ -1,3 +1,6 @@ +config BR2_ARCH_HAS_ATOMICS + bool
No. This option is already defined in arch/Config.in. There's no point in redefining it anywhere else.
Can you give me a .config that shows the warning you had?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 arc: Fix warning if atomics are selected
Hi Thomas,
defconfig is pretty simple:
BR2_arcle=y
BR2_ARC_ATOMIC_EXT=y
When I do anything with such configuration (like savedefconfig or menuconfig), I observe the following warning:
warning: (BR2_ARC_ATOMIC_EXT) selects BR2_ARCH_HAS_ATOMICS which has unmet direct dependencies (BR2_arm || BR2_armeb || BR2_aarch64
|| BR2_avr32 || BR2_bfin || BR2_m68k || BR2_microblazeel || BR2_microblazebe || BR2_mips || BR2_mips64 || BR2_mipsel || BR2_mips64el || BR2_nios2 || BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || BR2_sh || BR2_sh64 || BR2_sparc || BR2_i386 || BR2_x86_64 || BR2_xtensa)
That is using current master branch.
Anton
Quoted 42 lines
-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
Sent: 10 September 2014 17:19
To: Anton Kolesov
Cc: buildroot at uclibc.org
Subject: Re: [Buildroot] [PATCH] arc: Fix warning if atomics are selectedDear Anton Kolesov,
Quoted 2 lines · Anton Kolesov
If atomic instructions were selected for ARC, there was a warning, like:
"(BR2_ARC_ATOMIC_EXT) selectsBR2_ARCH_HAS_ATOMICSwhich hasunmet direct
Quoted 13 lines
dependencies". This patch removes the reason of this warning by adding a respective configuration entry.
Signed-off-by Anton Kolesov <[email protected]>--- arch/Config.in.arc | 3 +++ 1 file changed, 3 insertions(+)arch/Config.in.arc +0
-0arch/Config.in.arc line 2
Quoted 2 lines
arch/Config.in.arc +2
-0@@ -1,3 +1,6 @@ +config BR2_ARCH_HAS_ATOMICS + boolNo. This option is already defined in
arch/Config.in. There's no point in redefining it anywhere else.Can you give me a .config that shows the warning you had?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH 1/1 arc: Fix warning if atomics are selected
Dear Anton Kolesov,
Quoted 7 lines · Anton Kolesov
defconfig is pretty simple:
BR2_arcle=y
BR2_ARC_ATOMIC_EXT=yWhen I do anything with such configuration (like savedefconfig or menuconfig), I observe the following warning:
Quoted 8 lines
warning: (
BR2_ARC_ATOMIC_EXT) selectsBR2_ARCH_HAS_ATOMICSwhich has unmet direct dependencies (BR2_arm||BR2_armeb||BR2_aarch64|| BR2_avr32 || BR2_bfin || BR2_m68k || BR2_microblazeel || BR2_microblazebe || BR2_mips || BR2_mips64 || BR2_mipsel || BR2_mips64el || BR2_nios2 || BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || BR2_sh || BR2_sh64 || BR2_sparc || BR2_i386 || BR2_x86_64 || BR2_xtensa)That is using current master branch.
There is indeed something weird going on here with the kconfig logic. We have:
config BR2_ARCH_HAS_ATOMICS
bool
in arch/Config.in, i.e defined for all architectures.
Then, most architectures (except ARC) are doing:
config BR2_ARCH_HAS_ATOMICS
default y
because they all have atomic operations in all cases.
But ARC is just doing:
config BR2_ARC_ATOMIC_EXT
bool "Atomic extension (LLOCK/SCOND instructions)" select BR2_ARCH_HAS_ATOMICS
But for some reason, kconfig decides that BR2_ARCH_HAS_ATOMICS is only available for the other architectures, not ARC. Seems like the trick used by Yann to declare the type of BR2_ARCH_HAS_ATOMICS in arch/Config.in, and then its value in each individual arch/Config.in.<foo> doesn't work when you do just a select.
One solution would be:
arch/Config.in.arc +3 -1
@@ -1,7 +1,9 @@ # Choise of atomic instructions presence +config BR2_ARCH_HAS_ATOMICS + default y if BR2_ARC_ATOMIC_EXT + config BR2_ARC_ATOMIC_EXT bool "Atomic extension (LLOCK/SCOND instructions)" - select BR2_ARCH_HAS_ATOMICS config BR2_ARCH default "arc" if BR2_arcle
Which is basically very close to what you were proposing. But I'm still not convinced, so I'm Cc'ing Yann to get an idea on what's going on here.
Thanks for the report!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com