Use only elfutils package to provide the libelf library

PATCH New Gregory CLEMENT 4 participants 14 messages Aug 28, 2014 – Sep 13, 2014

lore

Share & tools

lore

Gregory CLEMENT

author

2014-08-28 12:21 UTC #0 lore raw

v3 cover Use only elfutils package to provide the libelf library

Hi,

The libelf is currently provided by 2 packages libelf and elfutils. The first package provides an old version of the libelf which is no more compatible with a recent version of ltrace. Having both libraries could lead to the link on the wrong one during the build. It is what happened for ltrace.

To avoid this kind of issue, this patch set switch the dependency from libelf to elfutils and finally removed the libelf package.

I built and fully tested ltrace on ARM.
I built and just ran avrdude on ARM.
I didn't build kexec-lite.

Thanks,

Changelog:
v1 -> v2:
- Propagated the dependencies from elfutils for kexec-lite and avrdude
- Fixed the subject of the avrdude patch
- Use the -D flag to generate the patch: only the mention of the deleted files is kept. This allows to have a very light patch but one will be able to apply the patch only by using git.

v2 -> v3:
- moved the config option of the libelf package to Config.in.legacy

Gregory CLEMENT (4):
ltrace: Removes the libelf dependency
avrdude: Depend on elfutils instead of libelf to get the libelf
library
kexec-lite: Depends on elfutils instead of libelf to get the libelf
library
libelf: Removes the package

 Config.in.legacy                                |     9 +
 package/Config.in                               |     1 -
 package/avrdude/Config.in                       |     6 +-
 package/avrdude/avrdude.mk                      |     2 +-
 package/kexec-lite/Config.in                    |     4 +-
 package/kexec-lite/kexec-lite.mk                |     2 +-
 package/libelf/Config.in                        |     7 -
 package/libelf/libelf-0.8.10-Elf64-fixups.patch | 12361 ----------------------
 package/libelf/libelf.mk                        |    23 -
 package/ltrace/Config.in                        |     1 -
 package/ltrace/ltrace.mk                        |     2 +-
 11 files changed, 20 insertions(+), 12398 deletions(-)
 delete mode 100644 package/libelf/Config.in
 delete mode 100644 package/libelf/libelf-0.8.10-Elf64-fixups.patch
 delete mode 100644 package/libelf/libelf.mk

Signature · 1 line

1.9.1

Gregory CLEMENT

author

2014-08-28 12:21 UTC #1 lore raw

PATCH v3 1/4 ltrace: Removes the libelf dependency

The libelf is currently provided by 2 packages libelf and elfutils. The first package provides an old version of the libelf which is no more compatible with a recent version of ltrace. This patch removes the dependency on the libelf package and only keep the elfuils package which provides the accurate version of libelf for ltrace.

It will also allow to remove the libelf package and to avoid conflicts with two packages providing the same library.

Signed-off-by Gregory CLEMENT <[email protected]>

---
 package/ltrace/Config.in | 1 -
 package/ltrace/ltrace.mk | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

package/ltrace/Config.in +0 -1

index 8cabfa2..dc759d8 100644
@@ -6,7 +6,6 @@ config BR2_PACKAGE_LTRACE
 	# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756764.
 	depends on (BR2_i386 || BR2_arm \
 		|| BR2_powerpc || BR2_sparc || BR2_x86_64)
-	select BR2_PACKAGE_LIBELF
 	select BR2_PACKAGE_ELFUTILS
 	depends on BR2_LARGEFILE # elfutils
 	depends on BR2_USE_WCHAR # elfutils

package/ltrace/ltrace.mk +1 -1

index 0a3a90c..48bf7bd 100644
@@ -6,7 +6,7 @@
 
 LTRACE_VERSION = 0896ce554f80afdcba81d9754f6104f863dea803
 LTRACE_SITE = git://anonscm.debian.org/collab-maint/ltrace.git
-LTRACE_DEPENDENCIES = libelf elfutils
+LTRACE_DEPENDENCIES = elfutils
 LTRACE_CONF_OPT = --disable-werror
 LTRACE_LICENSE = GPLv2
 LTRACE_LICENSE_FILES = COPYING

Signature · 1 line

1.9.1

Yann E. MORIN

2014-09-10 20:14 UTC #2 lore raw

PATCH v3 1/4 ltrace: Removes the libelf dependency

Gregory, All,

On 2014-08-28 14:21 +0200, Gregory CLEMENT spake thusly:

Quoted 11 lines

The libelf is currently provided by 2 packages libelf and elfutils. The first package provides an old version of the libelf which is no more compatible with a recent version of ltrace. This patch removes the dependency on the libelf package and only keep the elfuils package which provides the accurate version of libelf for ltrace.
It will also allow to remove the libelf package and to avoid conflicts with two packages providing the same library.
Signed-off-by Gregory CLEMENT <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 37 lines

---
 package/ltrace/Config.in | 1 -
 package/ltrace/ltrace.mk | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

package/ltrace/Config.in +0 -1

index 8cabfa2..dc759d8 100644
@@ -6,7 +6,6 @@ config BR2_PACKAGE_LTRACE
 	# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756764.
 	depends on (BR2_i386 || BR2_arm \
 		|| BR2_powerpc || BR2_sparc || BR2_x86_64)
-	select BR2_PACKAGE_LIBELF
 	select BR2_PACKAGE_ELFUTILS
 	depends on BR2_LARGEFILE # elfutils
 	depends on BR2_USE_WCHAR # elfutils

package/ltrace/ltrace.mk +1 -1

index 0a3a90c..48bf7bd 100644
@@ -6,7 +6,7 @@
 
 LTRACE_VERSION = 0896ce554f80afdcba81d9754f6104f863dea803
 LTRACE_SITE = git://anonscm.debian.org/collab-maint/ltrace.git
-LTRACE_DEPENDENCIES = libelf elfutils
+LTRACE_DEPENDENCIES = elfutils
 LTRACE_CONF_OPT = --disable-werror
 LTRACE_LICENSE = GPLv2
 LTRACE_LICENSE_FILES = COPYING

Signature · 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Peter Korsgaard

2014-09-13 21:58 UTC #3 lore raw

PATCH v3 1/4 ltrace: Removes the libelf dependency

In reply to Gregory CLEMENT

Quoted 9 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gregory" == Gregory CLEMENT <[email protected]> writes:
The libelf is currently provided by 2 packages libelf and elfutils. The first package provides an old version of the libelf which is no more compatible with a recent version of ltrace. This patch removes the dependency on the libelf package and only keep the elfuils package which provides the accurate version of libelf for ltrace.

Quoted 4 lines

It will also allow to remove the libelf package and to avoid conflicts with two packages providing the same library.
Signed-off-by Gregory CLEMENT <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Gregory CLEMENT

author

2014-08-28 12:21 UTC #4 lore raw

PATCH v3 2/4 avrdude: Depend on elfutils instead of libelf to get the libelf library

In reply to Gregory CLEMENT

The elfutils package provides a more recent version of the libelf, so let's use it. It will allow to remove the libelf package and to avoid conflicts with two packages providing the same library.

Signed-off-by Gregory CLEMENT <[email protected]>

---
 package/avrdude/Config.in  | 6 +++++-
 package/avrdude/avrdude.mk | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

package/avrdude/Config.in +5 -1

index 8eac014..9a9b3fb 100644
@@ -1,10 +1,14 @@
 config BR2_PACKAGE_AVRDUDE
 	bool "avrdude"
-	select BR2_PACKAGE_LIBELF
+	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_LIBUSB
 	select BR2_PACKAGE_LIBUSB_COMPAT
 	select BR2_PACKAGE_NCURSES
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_LARGEFILE # elfutils
+	depends on BR2_USE_WCHAR # elfutils
+	depends on !BR2_avr32 # elfutils
+	depends on !BR2_bfin # elfutils
 	help
 	  avrdude is a programmer for Atmel AVR microcontrollers
 	  this package provides a version with new linuxspi driver

package/avrdude/avrdude.mk +1 -1

index 7876c1d..03d6490 100644
@@ -12,7 +12,7 @@ AVRDUDE_SUBDIR = avrdude
 # Sources coming from git, without generated configure and Makefile.in
 # files.
 AVRDUDE_AUTORECONF = YES
-AVRDUDE_DEPENDENCIES = libelf libusb libusb-compat ncurses \
+AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
 	host-flex host-bison
 AVRDUDE_LICENSE = GPLv2+
 AVRDUDE_LICENSE_FILES = avrdude/COPYING

Signature · 1 line

1.9.1

Yann E. MORIN

2014-09-10 20:18 UTC #5 lore raw

PATCH v3 2/4 avrdude: Depend on elfutils instead of libelf to get the libelf library

Gregory, All,

On 2014-08-28 14:21 +0200, Gregory CLEMENT spake thusly:

Quoted 5 lines

The elfutils package provides a more recent version of the libelf, so let's use it. It will allow to remove the libelf package and to avoid conflicts with two packages providing the same library.
Signed-off-by Gregory CLEMENT <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 11 lines

---
 package/avrdude/Config.in  | 6 +++++-
 package/avrdude/avrdude.mk | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

package/avrdude/Config.in +0 -0

index 8eac014..9a9b3fb 100644
@@ -1,10 +1,14 @@
 config BR2_PACKAGE_AVRDUDE

package/avrdude/Config.in line 10

Quoted 10 lines

package/avrdude/Config.in +4 -1

 	bool "avrdude"
-	select BR2_PACKAGE_LIBELF
+	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_LIBUSB
 	select BR2_PACKAGE_LIBUSB_COMPAT
 	select BR2_PACKAGE_NCURSES
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_LARGEFILE # elfutils
+	depends on BR2_USE_WCHAR # elfutils
+	depends on !BR2_avr32 # elfutils

At first, I was very surprised that an AVR-related package would be unavaivlable for avr32. But that's not incoherent, in fact: this can be used on the target to program an AVR (not avr32!) device.

That it does not work on avr32 is a pity, though... :-(

Anyway, acked.

Regards,
Yann E. MORIN.

Quoted 24 lines

package/avrdude/Config.in +1 -0

+	depends on !BR2_bfin # elfutils
 	help
 	  avrdude is a programmer for Atmel AVR microcontrollers
 	  this package provides a version with new linuxspi driver

package/avrdude/avrdude.mk +1 -1

index 7876c1d..03d6490 100644
@@ -12,7 +12,7 @@ AVRDUDE_SUBDIR = avrdude
 # Sources coming from git, without generated configure and Makefile.in
 # files.
 AVRDUDE_AUTORECONF = YES
-AVRDUDE_DEPENDENCIES = libelf libusb libusb-compat ncurses \
+AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
 	host-flex host-bison
 AVRDUDE_LICENSE = GPLv2+
 AVRDUDE_LICENSE_FILES = avrdude/COPYING

Signature · 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Peter Korsgaard

2014-09-13 22:01 UTC #6 lore raw

PATCH v3 2/4 avrdude: Depend on elfutils instead of libelf to get the libelf library

In reply to Gregory CLEMENT

Quoted 22 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gregory" == Gregory CLEMENT <[email protected]> writes:
The elfutils package provides a more recent version of the libelf, so let's use it. It will allow to remove the libelf package and to avoid conflicts with two packages providing the same library.
Signed-off-by Gregory CLEMENT <[email protected]>
---
 package/avrdude/Config.in  | 6 +++++-
 package/avrdude/avrdude.mk | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)
package/avrdude/Config.in +1 -1
index 8eac014..9a9b3fb 100644
@@ -1,10 +1,14 @@
 config BR2_PACKAGE_AVRDUDE
 	bool "avrdude"
-	select BR2_PACKAGE_LIBELF
+	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_LIBUSB

package/avrdude/Config.in line 14

Quoted 10 lines

package/avrdude/Config.in +4 -0

 	select BR2_PACKAGE_LIBUSB_COMPAT
 	select BR2_PACKAGE_NCURSES
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_LARGEFILE # elfutils
+	depends on BR2_USE_WCHAR # elfutils
+	depends on !BR2_avr32 # elfutils
+	depends on !BR2_bfin # elfutils
 	help
 	  avrdude is a programmer for Atmel AVR microcontrollers
 	  this package provides a version with new linuxspi driver

You forgot to update the toolchain options comment below.

Committed with that fixed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Gregory CLEMENT

author

2014-08-28 12:21 UTC #7 lore raw

PATCH v3 3/4 kexec-lite: Depends on elfutils instead of libelf to get the libelf library

In reply to Gregory CLEMENT

The elfutils package provides a more recent version of the libelf, so let's use it. It will allow to remove the libelf package and to avoid conflicts with two packages providing the same library.

Signed-off-by Gregory CLEMENT <[email protected]>

---
 package/kexec-lite/Config.in     | 4 +++-
 package/kexec-lite/kexec-lite.mk | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

package/kexec-lite/Config.in +3 -1

index 944ee29..dd9713e 100644
@@ -2,7 +2,9 @@ config BR2_PACKAGE_KEXEC_LITE
 	bool "kexec-lite"
 	depends on BR2_powerpc || BR2_powerpc64
 	depends on !BR2_PREFER_STATIC_LIB # dtc
-	select BR2_PACKAGE_LIBELF
+	depends on BR2_LARGEFILE # elfutils
+	depends on BR2_USE_WCHAR # elfutils
+	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_DTC
 	select BR2_PACKAGE_DTC_PROGRAMS
 	help

package/kexec-lite/kexec-lite.mk +1 -1

index 7028c6e..7e3c8d3 100644
@@ -7,7 +7,7 @@
 KEXEC_LITE_VERSION = fb8543fea3beb0522b5a63a74ea1a845dbd7b954
 KEXEC_LITE_SITE = $(call github,antonblanchard,kexec-lite,$(KEXEC_LITE_VERSION))
 KEXEC_LITE_LICENSE = GPLv2+
-KEXEC_LITE_DEPENDENCIES = libelf dtc
+KEXEC_LITE_DEPENDENCIES = elfutils dtc
 
 define KEXEC_LITE_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all

Signature · 1 line

1.9.1

Yann E. MORIN

2014-09-10 22:12 UTC #8 lore raw

PATCH v3 3/4 kexec-lite: Depends on elfutils instead of libelf to get the libelf library

Gregory, All,

On 2014-08-28 14:21 +0200, Gregory CLEMENT spake thusly:

Quoted 5 lines

The elfutils package provides a more recent version of the libelf, so let's use it. It will allow to remove the libelf package and to avoid conflicts with two packages providing the same library.
Signed-off-by Gregory CLEMENT <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 40 lines

---
 package/kexec-lite/Config.in     | 4 +++-
 package/kexec-lite/kexec-lite.mk | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

package/kexec-lite/Config.in +3 -1

index 944ee29..dd9713e 100644
@@ -2,7 +2,9 @@ config BR2_PACKAGE_KEXEC_LITE
 	bool "kexec-lite"
 	depends on BR2_powerpc || BR2_powerpc64
 	depends on !BR2_PREFER_STATIC_LIB # dtc
-	select BR2_PACKAGE_LIBELF
+	depends on BR2_LARGEFILE # elfutils
+	depends on BR2_USE_WCHAR # elfutils
+	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_DTC
 	select BR2_PACKAGE_DTC_PROGRAMS
 	help

package/kexec-lite/kexec-lite.mk +1 -1

index 7028c6e..7e3c8d3 100644
@@ -7,7 +7,7 @@
 KEXEC_LITE_VERSION = fb8543fea3beb0522b5a63a74ea1a845dbd7b954
 KEXEC_LITE_SITE = $(call github,antonblanchard,kexec-lite,$(KEXEC_LITE_VERSION))
 KEXEC_LITE_LICENSE = GPLv2+
-KEXEC_LITE_DEPENDENCIES = libelf dtc
+KEXEC_LITE_DEPENDENCIES = elfutils dtc
 
 define KEXEC_LITE_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all

Signature · 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Peter Korsgaard

2014-09-13 22:08 UTC #9 lore raw

PATCH v3 3/4 kexec-lite: Depends on elfutils instead of libelf to get the libelf library

In reply to Gregory CLEMENT

Quoted 17 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gregory" == Gregory CLEMENT <[email protected]> writes:
The elfutils package provides a more recent version of the libelf, so let's use it. It will allow to remove the libelf package and to avoid conflicts with two packages providing the same library.
Signed-off-by Gregory CLEMENT <[email protected]>
---
 package/kexec-lite/Config.in     | 4 +++-
 package/kexec-lite/kexec-lite.mk | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
package/kexec-lite/Config.in +0 -0
index 944ee29..dd9713e 100644

package/kexec-lite/Config.in config BR2_PACKAGE_KEXEC_LITE · line 10

Quoted 10 lines

package/kexec-lite/Config.in +3 -1

@@ -2,7 +2,9 @@ config BR2_PACKAGE_KEXEC_LITE
 	bool "kexec-lite"
 	depends on BR2_powerpc || BR2_powerpc64
 	depends on !BR2_PREFER_STATIC_LIB # dtc
-	select BR2_PACKAGE_LIBELF
+	depends on BR2_LARGEFILE # elfutils
+	depends on BR2_USE_WCHAR # elfutils
+	select BR2_PACKAGE_ELFUTILS
 	select BR2_PACKAGE_DTC
 	select BR2_PACKAGE_DTC_PROGRAMS
 	help

Same as for avrdude, we should update the toolchain options comment to match.

Committed with that fixed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Gregory CLEMENT

author

2014-08-28 12:21 UTC #10 lore raw

PATCH v3 4/4 libelf: Removes the package

In reply to Gregory CLEMENT

The elfutils package provides a more recent version of the libelf. Some packages such as ltrace need this more recent version. Having two packages providing the same library leads to some conflicts or dependency problems. For instance at the end we had only one libelf.a when the 2 packages were selected.

Signed-off-by Gregory CLEMENT <[email protected]>

---
 Config.in.legacy                                |     9 +
 package/Config.in                               |     1 -
 package/libelf/Config.in                        |     7 -
 package/libelf/libelf-0.8.10-Elf64-fixups.patch | 12361 ----------------------
 package/libelf/libelf.mk                        |    23 -
 5 files changed, 9 insertions(+), 12392 deletions(-)
 delete mode 100644 package/libelf/Config.in
 delete mode 100644 package/libelf/libelf-0.8.10-Elf64-fixups.patch
 delete mode 100644 package/libelf/libelf.mk

Config.in.legacy +9 -0

index 23962a2..5b1460c 100644
@@ -101,6 +101,15 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2014.08"
 
+config BR2_PACKAGE_LIBELF
+	bool "libelf has been removed"
+	select BR2_PACKAGE_ELFUTILS
+	select BR2_LEGACY
+	help
+	  The libelf package provided an old version of the libelf library
+	  and is deprecated. The libelf library is now provided by the
+	  elfutils package.
+
 config BR2_KERNEL_HEADERS_3_8
 	bool "kernel headers version 3.8.x are no longer supported"
 	select BR2_KERNEL_HEADERS_3_9

package/Config.in +0 -1

index 0e10cdf..da528ad 100644
@@ -841,7 +841,6 @@ menu "Other"
 	source "package/libcofi/Config.in"
 	source "package/libdaemon/Config.in"
 	source "package/libee/Config.in"
-	source "package/libelf/Config.in"
 	source "package/libev/Config.in"
 	source "package/libevdev/Config.in"
 	source "package/libevent/Config.in"

package/libelf/Config.in deleted +0 -0

deleted file mode 100644
index 600ef68..0000000

package/libelf/libelf-0.8.10-Elf64-fixups.patch deleted +0 -0

deleted file mode 100644
index 86a064a..0000000

package/libelf/libelf.mk deleted +0 -0

deleted file mode 100644
index 0c37697..0000000

Signature · 1 line

1.9.1

Yann E. MORIN

2014-09-13 21:01 UTC #11 lore raw

PATCH v3 4/4 libelf: Removes the package

Gregory, All,

On 2014-08-28 14:21 +0200, Gregory CLEMENT spake thusly:

Quoted 7 lines

The elfutils package provides a more recent version of the libelf. Some packages such as ltrace need this more recent version. Having two packages providing the same library leads to some conflicts or dependency problems. For instance at the end we had only one libelf.a when the 2 packages were selected.
Signed-off-by Gregory CLEMENT <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

Sorry for the delay for that last review...

Regards,
Yann E. MORIN.

Quoted 59 lines

---
 Config.in.legacy                                |     9 +
 package/Config.in                               |     1 -
 package/libelf/Config.in                        |     7 -
 package/libelf/libelf-0.8.10-Elf64-fixups.patch | 12361 ----------------------
 package/libelf/libelf.mk                        |    23 -
 5 files changed, 9 insertions(+), 12392 deletions(-)
 delete mode 100644 package/libelf/Config.in
 delete mode 100644 package/libelf/libelf-0.8.10-Elf64-fixups.patch
 delete mode 100644 package/libelf/libelf.mk

Config.in.legacy +9 -0

index 23962a2..5b1460c 100644
@@ -101,6 +101,15 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2014.08"
 
+config BR2_PACKAGE_LIBELF
+	bool "libelf has been removed"
+	select BR2_PACKAGE_ELFUTILS
+	select BR2_LEGACY
+	help
+	  The libelf package provided an old version of the libelf library
+	  and is deprecated. The libelf library is now provided by the
+	  elfutils package.
+
 config BR2_KERNEL_HEADERS_3_8
 	bool "kernel headers version 3.8.x are no longer supported"
 	select BR2_KERNEL_HEADERS_3_9

package/Config.in +0 -1

index 0e10cdf..da528ad 100644
@@ -841,7 +841,6 @@ menu "Other"
 	source "package/libcofi/Config.in"
 	source "package/libdaemon/Config.in"
 	source "package/libee/Config.in"
-	source "package/libelf/Config.in"
 	source "package/libev/Config.in"
 	source "package/libevdev/Config.in"
 	source "package/libevent/Config.in"

package/libelf/Config.in deleted +0 -0

deleted file mode 100644
index 600ef68..0000000

package/libelf/libelf-0.8.10-Elf64-fixups.patch deleted +0 -0

deleted file mode 100644
index 86a064a..0000000

package/libelf/libelf.mk deleted +0 -0

deleted file mode 100644
index 0c37697..0000000

Signature · 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Peter Korsgaard

2014-09-13 22:09 UTC #12 lore raw

PATCH v3 4/4 libelf: Removes the package

In reply to Gregory CLEMENT

Quoted 9 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gregory" == Gregory CLEMENT <[email protected]> writes:
The elfutils package provides a more recent version of the libelf. Some packages such as ltrace need this more recent version. Having two packages providing the same library leads to some conflicts or dependency problems. For instance at the end we had only one libelf.a when the 2 packages were selected.
Signed-off-by Gregory CLEMENT <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard

Thomas Petazzoni

2014-08-28 14:14 UTC #13 lore raw

v3 cover Use only elfutils package to provide the libelf library

In reply to Gregory CLEMENT

Jeremy, Wojciech,

As the original authors of the kexec-lite and avrdude packages respectively, would you mind checking if the below patch series, which removes the libelf package in favour of the libelf bundled with elfutils does not break avrdude and kexec-lite ?

Thanks!

Thomas

Quoted 52 lines · Gregory CLEMENT

Hi,
The libelf is currently provided by 2 packages libelf and elfutils. The first package provides an old version of the libelf which is no more compatible with a recent version of ltrace. Having both libraries could lead to the link on the wrong one during the build. It is what happened for ltrace.
To avoid this kind of issue, this patch set switch the dependency from libelf to elfutils and finally removed the libelf package.
I built and fully tested ltrace on ARM.
I built and just ran avrdude on ARM.
I didn't build kexec-lite.
Thanks,
Changelog:
v1 -> v2:
- Propagated the dependencies from elfutils for kexec-lite and avrdude
- Fixed the subject of the avrdude patch
- Use the -D flag to generate the patch: only the mention of the deleted files is kept. This allows to have a very light patch but one will be able to apply the patch only by using git.
v2 -> v3:
- moved the config option of the libelf package to Config.in.legacy
Gregory CLEMENT (4):
ltrace: Removes the libelf dependency
avrdude: Depend on elfutils instead of libelf to get the libelf
library
kexec-lite: Depends on elfutils instead of libelf to get the libelf
library
libelf: Removes the package
 Config.in.legacy                                |     9 +
 package/Config.in                               |     1 -
 package/avrdude/Config.in                       |     6 +-
 package/avrdude/avrdude.mk                      |     2 +-
 package/kexec-lite/Config.in                    |     4 +-
 package/kexec-lite/kexec-lite.mk                |     2 +-
 package/libelf/Config.in                        |     7 -
 package/libelf/libelf-0.8.10-Elf64-fixups.patch | 12361 ----------------------
 package/libelf/libelf.mk                        |    23 -
 package/ltrace/Config.in                        |     1 -
 package/ltrace/ltrace.mk                        |     2 +-
 11 files changed, 20 insertions(+), 12398 deletions(-)
 delete mode 100644 package/libelf/Config.in
 delete mode 100644 package/libelf/libelf-0.8.10-Elf64-fixups.patch
 delete mode 100644 package/libelf/libelf.mk

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com