Skip to contentSkip to conversation

input: atkbd - Fix broken keyboard in another LG laptop

PATCH In review Jaime Velasco Juan 2 participants 4 messages Sep 10, 2014 – Sep 11, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: atkbd - Fix broken keyboard in another LG laptop

This model has the same quirk as others, see 3d725caa9dcc "Input:
atkbd - fix keyboard not working on some LG laptops"

---
 drivers/input/keyboard/atkbd.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/input/keyboard/atkbd.c +7 -0
index 2dd1d0d..a58653c 100644
@@ -1802,6 +1802,13 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 		},
 		.callback = atkbd_deactivate_fixup,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "LW60-F27B"),
+		},
+		.callback = atkbd_deactivate_fixup,
+	},
 	{ }
 };
 
Signature · 1 line
2.1.0
maintainer
#1 lore raw

Hi Jamie,

Quoted 3 lines · Jaime Velasco Juan

This model has the same quirk as others, see 3d725caa9dcc "Input:
atkbd - fix keyboard not working on some LG laptops"

How about the patch below instead?

Thanks!

Signature · 24 lines
Dmitry

Input: atkbd - do not try 'deactivate' keyboard on any LG laptops

From: Dmitry Torokhov <[email protected]>

We are getting more and more reports about LG laptops not having
functioning keyboard if we try to deactivate keyboard during probe.
Given that having keyboard deactivated is merely "nice to have"
instead of a hard requirement for probing, let's disable it on all
LG boxes instead of trying to hunt down particular models.

This change is prompted by patches trying to add "LG Electronics"/"ROCKY"
and "LG Electronics"/"LW60-F27B" to the DMI list.

https://bugzilla.kernel.org/show_bug.cgi?id=77051

Cc: [email protected]
Reported-by: Jaime Velasco Juan <[email protected]>
Reported-by: Georgios Tsalikis <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---
 drivers/input/keyboard/atkbd.c |    8 --------
 1 file changed, 8 deletions(-)
drivers/input/keyboard/atkbd.c +0 -8
index 2dd1d0d..6f5d795 100644
@@ -1791,14 +1791,6 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "LW25-B7HV"),
-		},
-		.callback = atkbd_deactivate_fixup,
-	},
-	{
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "P1-J273B"),
 		},
 		.callback = atkbd_deactivate_fixup,
 	},
#2 lore raw
Quoted 9 lines · Dmitry Torokhov

Hi Jamie,

Quoted 3 lines · Jaime Velasco Juan

This model has the same quirk as others, see 3d725caa9dcc "Input:
atkbd - fix keyboard not working on some LG laptops"

How about the patch below instead?

It works for me just the same, thanks.

Regards

Quoted 45 lines
Signature · 24 lines
Dmitry

Input: atkbd - do not try 'deactivate' keyboard on any LG laptops

From: Dmitry Torokhov <[email protected]>

We are getting more and more reports about LG laptops not having
functioning keyboard if we try to deactivate keyboard during probe.
Given that having keyboard deactivated is merely "nice to have"
instead of a hard requirement for probing, let's disable it on all
LG boxes instead of trying to hunt down particular models.

This change is prompted by patches trying to add "LG Electronics"/"ROCKY"
and "LG Electronics"/"LW60-F27B" to the DMI list.

https://bugzilla.kernel.org/show_bug.cgi?id=77051

Cc: [email protected]
Reported-by: Jaime Velasco Juan <[email protected]>
Reported-by: Georgios Tsalikis <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---
 drivers/input/keyboard/atkbd.c |    8 --------
 1 file changed, 8 deletions(-)
drivers/input/keyboard/atkbd.c +0 -8
index 2dd1d0d..6f5d795 100644
@@ -1791,14 +1791,6 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "LW25-B7HV"),
-		},
-		.callback = atkbd_deactivate_fixup,
-	},
-	{
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "P1-J273B"),
 		},
 		.callback = atkbd_deactivate_fixup,
 	},
maintainer
#3 lore raw
Quoted 5 lines · Jaime Velasco Juan
Quoted 3 lines · Dmitry Torokhov

Hi Jamie,

On Wed, Sep 10, 2014 at 07:06:14PM +0100, Jaime Velasco Juan wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

This model has the same quirk as others, see 3d725caa9dcc "Input:
atkbd - fix keyboard not working on some LG laptops"

How about the patch below instead?

It works for me just the same, thanks.

Thanks, I'll add you as also "tested-by" and queue for the next push.

Signature · 1 line
Dmitry