staging: android: checkpatch fixes for sw_sync files
PATCH 1/1 staging: android: checkpatch fixes for sw_sync files
- add line after declaration
- allignment should match open parenthesis
- remove unnecessary new line
Signed-off-by Purnendu Kapadia <[email protected]>
--- drivers/staging/android/sw_sync.c | 9 +++++---- drivers/staging/android/sw_sync.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-)
drivers/staging/android/sw_sync.c +5 -4
@@ -48,11 +48,11 @@ EXPORT_SYMBOL(sw_sync_pt_create);static struct sync_pt *sw_sync_pt_dup (struct sync_pt *sync_pt) { -struct sw_sync_pt *pt = (struct sw_sync_pt *) sync_pt; +struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;struct sw_sync_timeline *obj = (struct sw_sync_timeline *)sync_pt_parent (sync_pt); -return (struct sync_pt *)sw_sync_pt_create (obj, pt->value); +return (struct sync_pt *)sw_sync_pt_create (obj, pt->value); }static int sw_sync_pt_has_signaled (struct sync_pt *sync_pt)
@@ -94,9 +94,10 @@ static void sw_sync_timeline_value_str(struct sync_timeline *sync_timeline, }static void sw_sync_pt_value_str (struct sync_pt *sync_pt, -char *str,int size) +char *str,int size) {struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt; +snprintf (str, size,"%d" , pt->value); }
@@ -110,7 +111,6 @@ static struct sync_timeline_ops sw_sync_timeline_ops = { .pt_value_str = sw_sync_pt_value_str, }; -struct sw_sync_timeline *sw_sync_timeline_create (const char *name) { struct sw_sync_timeline *obj = (struct sw_sync_timeline *)
@@ -156,6 +156,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)static int sw_sync_release (struct inode *inode,struct file *file) {struct sw_sync_timeline *obj = file->private_data; +sync_timeline_destroy (&obj->obj);return 0 ; }
drivers/staging/android/sw_sync.h +1 -1
@@ -50,7 +50,7 @@ static inline void sw_sync_timeline_inc(struct sw_sync_timeline *obj, u32 inc) }static inline struct sync_pt *sw_sync_pt_create (struct sw_sync_timeline *obj, -u32 value) +u32 value) {return NULL ; }
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 9 lines · Purnendu Kapadia
- add line after declaration
- allignment should match open parenthesis
- remove unnecessary new lineSigned-off-by Purnendu Kapadia <[email protected]>--- drivers/staging/android/sw_sync.c | 9 +++++---- drivers/staging/android/sw_sync.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-)
This doesn't apply at all to my tree, what did you make it against?
Always work against linux-next, or my staging-next branch of staging.git to ensure you don't duplicate work that has already been done.
thanks,
greg k-h